RanchiMall/FLO-wallet-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8c8e8c2e93
FLO-wallet-core/src
History
Dwayne C. Litzenberger 8c8e8c2e93 Fix bugs on 'unsigned char' platforms. 
In ISO C++, the signedness of 'char' is undefined.  On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86).  This is indicated by compiler warnings like this:

 bignum.h: In constructor 'CBigNum::CBigNum(char)':
 bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]

 util.cpp: In function 'bool IsHex(const string&)':
 util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]

In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.

Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
2012-04-18 00:33:32 -04:00
..
json Back out spacing changes to json spirit code 2012-01-19 14:32:45 -05:00
obj Boost unit-testing framework. 2011-06-27 14:12:48 -04:00
obj-test Rename src/obj/test to src/obj-test to workaround bug in older GNU Make 2012-01-23 14:27:08 -05:00
qt Add missing breaks in optionmodel's switch case 2012-04-17 23:27:59 +02:00
test Fix tests after recent refactors 2012-04-17 20:37:47 +02:00
addrman.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
addrman.h Move proto version to version.h. Reduce header deps a bit more. 2012-04-17 20:02:38 +02:00
allocators.h Remove headers.h 2012-04-17 20:00:55 +02:00
base58.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
bignum.h Fix bugs on 'unsigned char' platforms. 2012-04-18 00:33:32 -04:00
bitcoinrpc.cpp Merge remote-tracking branch 'jgarzik/mempool' 2012-04-17 20:12:48 +02:00
bitcoinrpc.h Update all copyrights to 2012 2012-02-07 11:28:30 -05:00
checkpoints.cpp Remove headers.h 2012-04-17 20:00:55 +02:00
checkpoints.h Remove headers.h 2012-04-17 20:00:55 +02:00
compat.h Remove headers.h 2012-04-17 20:00:55 +02:00
crypter.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
crypter.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
db.cpp Merge pull request #1114 from sipa/lesssync 2012-04-17 14:23:31 -07:00
db.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
init.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
init.h Remove headers.h 2012-04-17 20:00:55 +02:00
irc.cpp Remove headers.h 2012-04-17 20:00:55 +02:00
irc.h Fix #626: RecvLine wrong error message 2012-02-19 19:06:42 +01:00
key.cpp Update all copyrights to 2012 2012-02-07 11:28:30 -05:00
key.h Fix tests after recent refactors 2012-04-17 20:37:47 +02:00
keystore.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
keystore.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
main.cpp Merge remote-tracking branch 'jgarzik/mempool' 2012-04-17 20:12:48 +02:00
main.h Merge remote-tracking branch 'jgarzik/mempool' 2012-04-17 20:12:48 +02:00
makefile.linux-mingw Move CWalletDB code to new walletdb module. 2012-04-17 20:00:55 +02:00
makefile.mingw Move CWalletDB code to new walletdb module. 2012-04-17 20:00:55 +02:00
makefile.osx Move CWalletDB code to new walletdb module. 2012-04-17 20:00:55 +02:00
makefile.unix Move CWalletDB code to new walletdb module. 2012-04-17 20:00:55 +02:00
mruset.h Begin doxygen-compatible comments 2012-03-26 16:48:23 +02:00
net.cpp Remove headers.h 2012-04-17 20:00:55 +02:00
net.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
netbase.cpp Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned 2012-04-15 16:58:32 -04:00
netbase.h Remove headers.h 2012-04-17 20:00:55 +02:00
noui.cpp Remove headers.h 2012-04-17 20:00:55 +02:00
protocol.cpp Fix loop index var types, fixing many minor sign comparison warnings 2012-04-15 16:52:09 -04:00
protocol.h Move proto version to version.h. Reduce header deps a bit more. 2012-04-17 20:02:38 +02:00
rpcdump.cpp Remove headers.h 2012-04-17 20:00:55 +02:00
script.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
script.h Fix bugs on 'unsigned char' platforms. 2012-04-18 00:33:32 -04:00
serialize.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
strlcpy.h Remove headers.h 2012-04-17 20:00:55 +02:00
ui_interface.h Bugfix: Replace "URL" with "URI" where we aren't actually working with URLs 2012-04-06 12:53:37 -04:00
uint256.h Fix bugs on 'unsigned char' platforms. 2012-04-18 00:33:32 -04:00
util.cpp Fix bugs on 'unsigned char' platforms. 2012-04-18 00:33:32 -04:00
util.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
version.cpp version.h: separate client, net sections. Move more constants to this file. 2012-04-12 12:23:58 -04:00
version.h Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31 2012-04-17 12:16:46 -04:00
wallet.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
wallet.h Further reduce header dependencies 2012-04-17 20:03:42 +02:00
walletdb.cpp Further reduce header dependencies 2012-04-17 20:03:42 +02:00
walletdb.h Move CWalletDB code to new walletdb module. 2012-04-17 20:00:55 +02:00