FLO-wallet-core/src/test
Wladimir J. van der Laan 6859ad2936
Merge #10706: Improve wallet fee logic and fix GUI bugs
11590d3 Properly bound check conf_target in wallet RPC calls (Alex Morcos)
fd29d3d Remove checking of mempool min fee from estimateSmartFee. (Alex Morcos)
2fffaa9 Make QT fee displays use GetMinimumFee instead of estimateSmartFee (Alex Morcos)
1983ca6 Use CoinControl to pass custom fee setting from QT. (Alex Morcos)
03ee701 Refactor to use CoinControl in GetMinimumFee and FeeBumper (Alex Morcos)
ecd81df Make CoinControl a required argument to CreateTransaction (Alex Morcos)

Pull request description:

  This builds on #10589  (first 5 commits from that PR, last 5 commits are new)

  The first couple commits refactor to use the CCoinControl class to pass fee calculation parameters around.

  This allows for fixing the buggy interaction in QT between the global payTxFee which can be modified by the RPC call settxfee or temporarily modified by the QT custom fee settings.  Before these changes the GUI could sometimes send a transaction with a recently set payTxFee and not respect the settings displayed in the GUI.   After these changes, using the GUI does not involve the global transaction confirm target or payTxFee.

  The prospective fee displays in the smart fee slider and the coin control dialog are changed to use the fee calculation from GetMinimumFee, this simplifies the code and makes them slightly more correct in edge cases.

  Maxing the fee calculation with the mempool min fee is move from estimateSmartFee to GetMinimumFee.

  This fixes a long standing bug, and should be tagged for 0.15 as it is holding up finalizing the estimatesmartfee RPC API before release.

Tree-SHA512: 4d36a1bd5934aa62f3806d380fcafbef73e9fe5bdf190fc5259a3e3a13349e5ce796e50e7068c46dc630ccf56d061bce5804f0bfe2e082bb01ca725b63efd4c1
2017-07-17 09:25:33 +02:00
..
data Replace MAX_OPCODE for OP_NOP10. 2017-07-11 16:45:42 +09:00
addrman_tests.cpp Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
allocator_tests.cpp Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
amount_tests.cpp
arith_uint256_tests.cpp Fixed multiple typos 2017-06-22 19:18:10 +03:00
base32_tests.cpp
base58_tests.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
base64_tests.cpp
bip32_tests.cpp scripted-diff: Fully remove BOOST_FOREACH 2017-06-05 20:10:50 +02:00
blockencodings_tests.cpp scripted-diff: Use new naming style for insecure_rand* functions 2017-06-07 12:08:39 -07:00
bloom_tests.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
bswap_tests.cpp
checkqueue_tests.cpp Merge #10521: Limit variable scope 2017-06-09 13:09:24 -07:00
coins_tests.cpp Simplify return values of GetCoin/HaveCoin(InCache) 2017-06-26 16:16:26 -07:00
compress_tests.cpp
crypto_tests.cpp Merge #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of 2017-06-08 20:26:40 +02:00
cuckoocache_tests.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
dbwrapper_tests.cpp Use range based for loop 2017-07-16 17:03:33 +02:00
DoS_tests.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
getarg_tests.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
hash_tests.cpp scripted-diff: Use new naming style for insecure_rand* functions 2017-06-07 12:08:39 -07:00
key_tests.cpp
limitedmap_tests.cpp
main_tests.cpp
Makefile
mempool_tests.cpp
merkle_tests.cpp scripted-diff: Use new naming style for insecure_rand* functions 2017-06-07 12:08:39 -07:00
miner_tests.cpp Simplify "bool x = y ? true : false" to "bool x = y" 2017-06-11 15:44:01 +02:00
multisig_tests.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
net_tests.cpp Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
netbase_tests.cpp [refactor] move SplitHostPort() into utilstrencodings 2017-07-12 17:06:15 -04:00
pmt_tests.cpp Merge #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of 2017-06-08 20:26:40 +02:00
policyestimator_tests.cpp Remove checking of mempool min fee from estimateSmartFee. 2017-07-14 23:41:40 -04:00
pow_tests.cpp scripted-diff: Use new naming style for insecure_rand* functions 2017-06-07 12:08:39 -07:00
prevector_tests.cpp scripted-diff: Remove BOOST_REVERSE_FOREACH 2017-06-22 03:48:50 +02:00
raii_event_tests.cpp
random_tests.cpp Add FastRandomContext::rand256() and ::randbytes() 2017-06-05 12:44:44 -07:00
README.md
reverselock_tests.cpp
rpc_tests.cpp Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of 2017-06-06 21:29:16 +02:00
sanity_tests.cpp
scheduler_tests.cpp [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution} 2017-06-07 20:38:03 +02:00
script_P2SH_tests.cpp Only pass things committed to by tx's witness hash to CScriptCheck 2017-06-01 11:56:06 -07:00
script_tests.cpp Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
scriptnum10.h
scriptnum_tests.cpp
serialize_tests.cpp
sighash_tests.cpp Merge #10524: [tests] Remove printf(...) 2017-06-08 09:43:09 +02:00
sigopcount_tests.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
skiplist_tests.cpp Merge #10321: Use FastRandomContext for all tests 2017-06-07 15:12:14 -07:00
streams_tests.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
test_bitcoin_fuzzy.cpp Switch CCoinsView and chainstate db from per-txid to per-txout 2017-06-01 12:59:38 -07:00
test_bitcoin_main.cpp
test_bitcoin.cpp Flush CValidationInterface callbacks prior to destruction 2017-07-07 12:55:57 -04:00
test_bitcoin.h Give CMainSignals a reference to the global scheduler 2017-07-07 11:33:18 -04:00
testutil.cpp
testutil.h
timedata_tests.cpp
torcontrol_tests.cpp torcontrol: Handle escapes in Tor QuotedStrings 2017-05-16 18:22:25 +12:00
transaction_tests.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
txvalidationcache_tests.cpp Do not shadow upper local variable state. 2017-07-08 09:30:35 +02:00
uint256_tests.cpp
univalue_tests.cpp
util_tests.cpp scripted-diff: Use new naming style for insecure_rand* functions 2017-06-07 12:08:39 -07:00
versionbits_tests.cpp Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the bitcoind tests manually, launch src/test/test_bitcoin.

To add more bitcoind tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the bitcoin-qt tests manually, launch src/qt/test/test_bitcoin-qt

To add more bitcoin-qt tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Note on adding test cases

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since bitcoin already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is setup to compile an executable called test_bitcoin that runs all of the unit tests. The main source file is called test_bitcoin.cpp. To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, examine uint256_tests.cpp.

For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.