From bd1a08bfa1925b5390359e16d62c1a7965706e7f Mon Sep 17 00:00:00 2001 From: Daniel Cousens Date: Sat, 24 May 2014 14:33:02 +1000 Subject: [PATCH] ecdsa: use signum() over compareTo --- src/ecdsa.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ecdsa.js b/src/ecdsa.js index 7d73a6d..4fd95b3 100644 --- a/src/ecdsa.js +++ b/src/ecdsa.js @@ -64,15 +64,16 @@ function verifyRaw(ecparams, e, r, s, Q) { var n = ecparams.getN() var G = ecparams.getG() - if (r.compareTo(BigInteger.ONE) < 0 || r.compareTo(n) >= 0) { + if (r.signum() === 0 || r.compareTo(n) >= 0) { return false } - if (s.compareTo(BigInteger.ONE) < 0 || s.compareTo(n) >= 0) { + if (s.signum() === 0 || s.compareTo(n) >= 0) { return false } var c = s.modInverse(n) + var u1 = e.multiply(c).mod(n) var u2 = r.multiply(c).mod(n)