From bc001ce3a31077007e3c0b6e6c0caf2083499fcf Mon Sep 17 00:00:00 2001 From: Martin Boehm Date: Fri, 22 May 2020 11:19:37 +0200 Subject: [PATCH] Make logs cleaner by not logging public API errors in websocket --- server/websocket.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/websocket.go b/server/websocket.go index eea868fe..436c61af 100644 --- a/server/websocket.go +++ b/server/websocket.go @@ -420,7 +420,9 @@ func (s *WebsocketServer) onRequest(c *websocketChannel, req *websocketReq) { glog.V(1).Info("Client ", c.id, " onRequest ", req.Method, " success") s.metrics.WebsocketRequests.With(common.Labels{"method": req.Method, "status": "success"}).Inc() } else { - glog.Error("Client ", c.id, " onMessage ", req.Method, ": ", errors.ErrorStack(err), ", data ", string(req.Params)) + if apiErr, ok := err.(*api.APIError); !ok || !apiErr.Public { + glog.Error("Client ", c.id, " onMessage ", req.Method, ": ", errors.ErrorStack(err), ", data ", string(req.Params)) + } s.metrics.WebsocketRequests.With(common.Labels{"method": req.Method, "status": "failure"}).Inc() e := resultError{} e.Error.Message = err.Error()