From d15ed57f611c19de6a17cf459f24f3eea34d3e6c Mon Sep 17 00:00:00 2001 From: Jakub Matys Date: Fri, 20 Jul 2018 12:50:30 +0200 Subject: [PATCH] Removed TestSendRawTransaction because of instability --- bchain/coins/bch/bcashrpc_test.go | 8 -------- bchain/coins/btc/bitcoinrpc_test.go | 8 -------- bchain/coins/dash/dashrpc_test.go | 8 -------- bchain/coins/namecoin/namecoinrpc_test.go | 4 ---- bchain/coins/vertcoin/vertcoinrpc_test.go | 4 ---- bchain/coins/zec/zcashrpc_test.go | 8 -------- bchain/tests/rpc/rpc.go | 14 -------------- 7 files changed, 54 deletions(-) diff --git a/bchain/coins/bch/bcashrpc_test.go b/bchain/coins/bch/bcashrpc_test.go index b4ff9bf8..7056125b 100644 --- a/bchain/coins/bch/bcashrpc_test.go +++ b/bchain/coins/bch/bcashrpc_test.go @@ -76,10 +76,6 @@ func TestBCashRPC_GetMempoolEntry(t *testing.T) { tests.mainnet.TestGetMempoolEntry(t) } -func TestBCashRPC_SendRawTransaction(t *testing.T) { - tests.mainnet.TestSendRawTransaction(t) -} - func TestBCashRPC_EstimateSmartFee(t *testing.T) { tests.mainnet.TestEstimateSmartFee(t) } @@ -124,10 +120,6 @@ func TestBCashTestnetRPC_GetMempoolEntry(t *testing.T) { tests.testnet.TestGetMempoolEntry(t) } -func TestBCashTestnetRPC_SendRawTransaction(t *testing.T) { - tests.testnet.TestSendRawTransaction(t) -} - func TestBCashTestnetRPC_EstimateSmartFee(t *testing.T) { tests.testnet.TestEstimateSmartFee(t) } diff --git a/bchain/coins/btc/bitcoinrpc_test.go b/bchain/coins/btc/bitcoinrpc_test.go index ede88504..882a1bd7 100644 --- a/bchain/coins/btc/bitcoinrpc_test.go +++ b/bchain/coins/btc/bitcoinrpc_test.go @@ -77,10 +77,6 @@ func TestBitcoinRPC_GetMempoolEntry(t *testing.T) { tests.mainnet.TestGetMempoolEntry(t) } -func TestBitcoinRPC_SendRawTransaction(t *testing.T) { - tests.mainnet.TestSendRawTransaction(t) -} - func TestBitcoinRPC_EstimateSmartFee(t *testing.T) { tests.mainnet.TestEstimateSmartFee(t) } @@ -125,10 +121,6 @@ func TestBitcoinTestnetRPC_GetMempoolEntry(t *testing.T) { tests.testnet.TestGetMempoolEntry(t) } -func TestBitcoinTestnetRPC_SendRawTransaction(t *testing.T) { - tests.testnet.TestSendRawTransaction(t) -} - func TestBitcoinTestnetRPC_EstimateSmartFee(t *testing.T) { tests.testnet.TestEstimateSmartFee(t) } diff --git a/bchain/coins/dash/dashrpc_test.go b/bchain/coins/dash/dashrpc_test.go index 99b56a4b..98662672 100644 --- a/bchain/coins/dash/dashrpc_test.go +++ b/bchain/coins/dash/dashrpc_test.go @@ -68,10 +68,6 @@ func TestDashRPC_MempoolSync(t *testing.T) { tests.mainnet.TestMempoolSync(t) } -func TestDashRPC_SendRawTransaction(t *testing.T) { - tests.mainnet.TestSendRawTransaction(t) -} - func TestDashRPC_EstimateSmartFee(t *testing.T) { tests.mainnet.TestEstimateSmartFee(t) } @@ -112,10 +108,6 @@ func TestDashTestnetRPC_MempoolSync(t *testing.T) { tests.testnet.TestMempoolSync(t) } -func TestDashTestnetRPC_SendRawTransaction(t *testing.T) { - tests.testnet.TestSendRawTransaction(t) -} - func TestDashTestnetRPC_EstimateSmartFee(t *testing.T) { tests.testnet.TestEstimateSmartFee(t) } diff --git a/bchain/coins/namecoin/namecoinrpc_test.go b/bchain/coins/namecoin/namecoinrpc_test.go index 5b458641..d50ef581 100644 --- a/bchain/coins/namecoin/namecoinrpc_test.go +++ b/bchain/coins/namecoin/namecoinrpc_test.go @@ -65,10 +65,6 @@ func TestNamecoinRPC_GetMempoolEntry(t *testing.T) { rpcTest.TestGetMempoolEntry(t) } -func TestNamecoinRPC_SendRawTransaction(t *testing.T) { - rpcTest.TestSendRawTransaction(t) -} - func TestNamecoinRPC_EstimateSmartFee(t *testing.T) { rpcTest.TestEstimateSmartFee(t) } diff --git a/bchain/coins/vertcoin/vertcoinrpc_test.go b/bchain/coins/vertcoin/vertcoinrpc_test.go index dcf3de14..aa4c615e 100644 --- a/bchain/coins/vertcoin/vertcoinrpc_test.go +++ b/bchain/coins/vertcoin/vertcoinrpc_test.go @@ -63,10 +63,6 @@ func TestVertcoinRPC_GetMempoolEntry(t *testing.T) { rpcTest.TestGetMempoolEntry(t) } -func TestVertcoinRPC_SendRawTransaction(t *testing.T) { - rpcTest.TestSendRawTransaction(t) -} - func TestVertcoinRPC_EstimateSmartFee(t *testing.T) { rpcTest.TestEstimateSmartFee(t) } diff --git a/bchain/coins/zec/zcashrpc_test.go b/bchain/coins/zec/zcashrpc_test.go index d65e68c8..f98520c6 100644 --- a/bchain/coins/zec/zcashrpc_test.go +++ b/bchain/coins/zec/zcashrpc_test.go @@ -67,10 +67,6 @@ func TestZCashRPC_MempoolSync(t *testing.T) { tests.mainnet.TestMempoolSync(t) } -func TestZCashRPC_SendRawTransaction(t *testing.T) { - tests.mainnet.TestSendRawTransaction(t) -} - func TestZCashRPC_EstimateSmartFee(t *testing.T) { tests.mainnet.TestEstimateSmartFee(t) } @@ -111,10 +107,6 @@ func TestZCashTestnetRPC_MempoolSync(t *testing.T) { tests.testnet.TestMempoolSync(t) } -func TestZCashTestnetRPC_SendRawTransaction(t *testing.T) { - tests.testnet.TestSendRawTransaction(t) -} - func TestZCashTestnetRPC_EstimateSmartFee(t *testing.T) { tests.testnet.TestEstimateSmartFee(t) } diff --git a/bchain/tests/rpc/rpc.go b/bchain/tests/rpc/rpc.go index 901f5498..4386baa1 100644 --- a/bchain/tests/rpc/rpc.go +++ b/bchain/tests/rpc/rpc.go @@ -339,20 +339,6 @@ func (rt *Test) TestGetMempoolEntry(t *testing.T) { t.Skip("Skipping test, all attempts to get mempool entry failed due to network state changes") } -func (rt *Test) TestSendRawTransaction(t *testing.T) { - rt.skipUnconnected(t) - - for txid, tx := range rt.TestData.TxDetails { - _, err := rt.Client.SendRawTransaction(tx.Hex) - if err != nil { - if err, ok := err.(*bchain.RPCError); ok && err.Code == -27 { - continue - } - } - t.Errorf("SendRawTransaction() for %s returned unexpected error: %#v", txid, err) - } -} - func (rt *Test) TestEstimateSmartFee(t *testing.T) { rt.skipUnconnected(t)