RanchiMall/fcoin
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bip151: add minimum packet size.

Browse Source
This commit is contained in:
Christopher Jeffrey 2016-07-27 01:40:07 -07:00
parent 594bbc8b1d
commit 01471d6e63
No known key found for this signature in database
GPG Key ID: 8962AB9DE6666BBD
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/bcoin/bip151.js
View File

@ -289,7 +289,7 @@ BIP151Stream.prototype.verify = function verify(tag) {
*/ */
BIP151Stream.prototype.feed = function feed(data) { BIP151Stream.prototype.feed = function feed(data) {
var chunk, payload, tag, p, cmd, body; var chunk, size, payload, tag, p, cmd, body;
while (data) { while (data) {
if (!this.hasHeader) { if (!this.hasHeader) {
@ -305,18 +305,21 @@ BIP151Stream.prototype.feed = function feed(data) {
this.pendingHeaderTotal = 0; this.pendingHeaderTotal = 0;
this.pendingHeader.length = 0; this.pendingHeader.length = 0;
this.waiting = this.decryptSize(chunk) + 16; size = this.decryptSize(chunk);
// Allow 3 batched packets of max message size. // Allow 3 batched packets of max message size (12mb).
// Not technically standard, but this protects us // Not technically standard, but this protects us
// from buffering tons of data due to either an // from buffering tons of data due to either an
// potential dos'er or a cipher state mismatch. // potential dos'er or a cipher state mismatch.
if (this.waiting - 32 > constants.MAX_MESSAGE * 3) { // Note that 6 is the minimum size:
this.waiting = 0; // cmd=varint(1) string(1) length(4) data(0)
this.emit('error', new Error('Packet too large.')); if (size < 6 || size > constants.MAX_MESSAGE * 3) {
assert(this.waiting === 0);
this.emit('error', new Error('Bad packet size.'));
continue; continue;
} }
this.waiting = size + 16;
this.hasHeader = true; this.hasHeader = true;
data = chunk.slice(4); data = chunk.slice(4);