RanchiMall/fcoin
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #243 from mnaamani/fix-net-listen

Browse Source 
net/http: correctly reject promise return by listen()
This commit is contained in:
Christopher Jeffrey (JJ) 2017-07-23 07:01:56 -07:00 committed by GitHub
commit 296492e7f8
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/http/base.js
View File

@ -812,10 +812,10 @@ HTTPBase.prototype.address = function address() {
HTTPBase.prototype.listen = function listen(port, host) {
return new Promise((resolve, reject) => {
let addr;
this.server.listen(port, host, (err) => {
if (err)
return reject(err);
this.server.once('error', reject)
this.server.listen(port, host, () => {
addr = this.address();
this.emit('listening', addr);

3
lib/net/tcp.js
View File

@ -41,7 +41,8 @@ tcp.createServer = function createServer() {
ee.listen = function listen(port, host) {
return new Promise((resolve, reject) => {
server.listen(port, host, wrap(resolve, reject));
server.once('error', reject)
server.listen(port, host, resolve);
});
};