RanchiMall/fcoin
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

script: enforce stack size on unexecuted branches.

Browse Source 
This primarily only affects zero-length scripts. An input script which pushed
this many items onto the stack without failing _is not possible_, but with
segwit, it is possible. However, a witness program would fail due to cleanstack
before there would be any kind of consensus fault. In other words, without this
fix, we still remain in consensus with bitcoin core, but ideally we should want
to fail for the same reason.
This commit is contained in:
Christopher Jeffrey 2017-08-25 08:08:31 -07:00
parent 7145d21c9c
commit 5fae0c50a1
No known key found for this signature in database
GPG Key ID: 8962AB9DE6666BBD
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/script/script.js
View File

@ -589,8 +589,11 @@ Script.prototype.execute = function execute(stack, flags, tx, index, value, vers
if (op.isDisabled())
throw new ScriptError('DISABLED_OPCODE', op, ip);
if (negate && !op.isBranch())
if (negate && !op.isBranch()) {
if (stack.length + alt.length > consensus.MAX_SCRIPT_STACK)
throw new ScriptError('STACK_SIZE', op, ip);
continue;
}
if (op.data) {
if (minimal && !op.isMinimal())