From 6ae273f84d3ca24b3d7252933393c4d38b2b6ce3 Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Fri, 18 Dec 2015 15:43:17 -0800 Subject: [PATCH] tx.verify: compare top stack item against zero instead of one. --- lib/bcoin/script.js | 3 ++- lib/bcoin/tx.js | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bcoin/script.js b/lib/bcoin/script.js index 99856b04..0a4b0114 100644 --- a/lib/bcoin/script.js +++ b/lib/bcoin/script.js @@ -767,7 +767,8 @@ script.exec = function(input, output, tx, i) { var stack = []; script.execute(input, stack, tx, i); var res = script.execute(output, stack, tx, i); - if (!res || stack.length === 0 || !utils.isEqual(stack.pop(), [ 1 ])) + // if (!res || stack.length === 0 || new bn(stack.pop()).cmp(0) !== 0) + if (!res || stack.length === 0 || utils.isEqual(stack.pop(), [ 0 ])) return false; return true; }; diff --git a/lib/bcoin/tx.js b/lib/bcoin/tx.js index cde33766..f9218ae2 100644 --- a/lib/bcoin/tx.js +++ b/lib/bcoin/tx.js @@ -594,8 +594,7 @@ TX.prototype.verify = function verify(index, force) { // Might be necessary for arithmetic: // if (stack.length === 0 || new bn(stack.pop()).cmp(0) !== 0) - - if (stack.length === 0 || !utils.isEqual(stack.pop(), [ 1 ])) + if (stack.length === 0 || utils.isEqual(stack.pop(), [ 0 ])) return false; if (bcoin.script.isScripthash(prev)) {