From 7e5b6a2ff7cbd5f16e03bdd2e3be1ba30fd24632 Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Sun, 12 Jun 2016 12:08:34 -0700 Subject: [PATCH] minor optimization. --- lib/bcoin/chain.js | 3 +-- lib/bcoin/coinview.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/bcoin/chain.js b/lib/bcoin/chain.js index 40d5da52..c2e9b847 100644 --- a/lib/bcoin/chain.js +++ b/lib/bcoin/chain.js @@ -849,8 +849,7 @@ Chain.prototype._checkInputs = function _checkInputs(block, prev, state, callbac utils.forEachSerial(block.txs, function(tx, next) { // Ensure tx is not double spending an output. if (!tx.isCoinbase()) { - view.fill(tx); - if (!tx.hasCoins()) { + if (!view.fillCoins(tx)) { assert(!historical, 'BUG: Spent inputs in historical data!'); return next(new VerifyError(block, 'invalid', diff --git a/lib/bcoin/coinview.js b/lib/bcoin/coinview.js index 83950f18..4ac42b0c 100644 --- a/lib/bcoin/coinview.js +++ b/lib/bcoin/coinview.js @@ -102,7 +102,7 @@ CoinView.prototype.spend = function spend(hash, index) { * @returns {Boolean} True if all inputs were filled. */ -CoinView.prototype.fill = function fill(tx) { +CoinView.prototype.fillCoins = function fillCoins(tx) { var res = true; var i, input, prevout;