From 9cd2e5438be02114183f9257c9b621d18245945c Mon Sep 17 00:00:00 2001
From: Christopher Jeffrey <chjjeffrey@gmail.com>
Date: Wed, 20 Apr 2016 02:52:58 -0700
Subject: [PATCH] add alert tests.

---
 lib/bcoin/script.js      |   4 ++--
 test/data/alertTests.raw | Bin 0 -> 1279 bytes
 test/protocol-test.js    |  20 ++++++++++++++++++++
 3 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 test/data/alertTests.raw

diff --git a/lib/bcoin/script.js b/lib/bcoin/script.js
index 876ade68..b4407eff 100644
--- a/lib/bcoin/script.js
+++ b/lib/bcoin/script.js
@@ -3605,14 +3605,14 @@ Script.fromString = function fromString(code) {
         code[i] = op;
         continue;
       }
-      if (op[0] === '[')
-        op = op.slice(1, -1);
       if (/^-?\d+$/.test(op)) {
         op = new bn(op, 10);
         op = Script.array(op);
         code[i] = op;
         continue;
       }
+      if (op[0] === '[')
+        op = op.slice(1, -1);
       if (op.indexOf('0x') === 0)
         op = op.slice(2);
       assert(utils.isHex(op), 'Unknown opcode.');
diff --git a/test/data/alertTests.raw b/test/data/alertTests.raw
new file mode 100644
index 0000000000000000000000000000000000000000..01f50680b95aa307a1a013b643ded4ae0bc47162
GIT binary patch
literal 1279
zcmZ={WME*h0b&qn2n6vM7$78=$-oe4#}5(Vb<9aEDp5$z&&^HED`AK53>n-FT$vOZ
zT6;>jOMiNBjj`hU_HgHQ?~0yVcV6r{KVN{qoVTd1?j)0f{?x_?$@^IxUUY29f16*-
z{-FM@nZvZ(TZ|lvBLA-{pO8$HOBng}gA+^gi!(B<4D<~34D>;|P+cYob(un1evtxH
zu>x2zgPVa1lY-RE%g6XV)mGXqWBmT=!_|Y)_kR4}7A7R>c<YzTK2EP5CIw#U7^^G!
zyI#1iYmfUGcJ%^}ZN_gYj{vKGw+dcZNUh#pMU+#S(4C6RH^S<41)NUT0r~)_2jT;L
zDV6R}k%fHq6E&`O{0#K9x)vUB?aK2XPVq{5r`GK=V^T2e7is$0UUISb)}LOPX^%8l
zERssxzgVmG;&avOt_%Fke6aa|2|4P)(Vl`4xIz#Y8tEt`C*~!m<`gR!LfoWxeba3D
zC8C_JAIetRS8K6Oth0Vw$FhI#<Lic@mp83j!lYpCyvN*L-8m{@S?=d~r@kfZoRGHn
zEOWpNlQk#8QUxN_QQWi#niQGIbQ2_1wom>0E!g1h&KK=J$_^x?-%R>l_4VpRoijgP
z&DbIlds%@=!Hs|Q$%9_UR_lD=jto@ZWi)^P&3X0fwJdjAvK+dmdHF6@N3p;h#SLVL
z0Wkw{0R?f?PV@b-k5Wyi>i4_%Bo<$lHv6ySF0|S7Vr$;KnH3w}K4Ve{5mx)@H;>VG
zV)PxY<k=|#+K<1QXq>7R{(M)t&dXdm1tqJ%LW&jLQ5abT(~;1uVuU5DK-_v|qEX;l
z`;Ea8OG>`yYWv(O?P7~*yl?IK{6}Bi%Enc$ObUtn4ofyOb8$Z~I;nGod;9)Xj~<*9
zKa_r_FRL*-b5><S7;;L3xs?s(R#4d4I{^zAOt;CnmSyHZGK9Ldf__qFo_<cTwL)rg
zM!teNB+Z4N?N`dL+3RZgsMG%R&HcvL8m73{@t<wpn6&I0qtEvmCWW|s;o98L`ZMw`
bo(5^`dVZ5xb+T{GmC|zo{n}P5`Wv+YY=?}R

literal 0
HcmV?d00001

diff --git a/test/protocol-test.js b/test/protocol-test.js
index 2857f7ce..66fb3256 100644
--- a/test/protocol-test.js
+++ b/test/protocol-test.js
@@ -1,7 +1,10 @@
 var assert = require('assert');
 var bcoin = require('../')();
 var constants = bcoin.protocol.constants;
+var network = bcoin.protocol.network;
 var utils = bcoin.utils;
+var fs = require('fs');
+var alertData = fs.readFileSync(__dirname + '/data/alertTests.raw');
 
 describe('Protocol', function() {
   var version = require('../package.json').version;
@@ -181,6 +184,23 @@ describe('Protocol', function() {
       'de5c0500000017a9141d9ca71efa36d814424ea6ca1437e67287aebe348' +
       '700000000', 'hex');
     var tx = bcoin.protocol.parser.parseTX(rawTwoTxs);
+    delete tx._raw;
     assert.deepEqual(bcoin.protocol.framer.tx(tx), rawFirstTx);
   });
+
+  it('should parse, reserialize, and verify alert packets', function() {
+    var p = new bcoin.reader(alertData);
+    p.start();
+    while (p.left()) {
+      var details = bcoin.protocol.parser.parseAlert(p);
+      var hash = utils.dsha256(details.payload);
+      var signature = details.signature;
+      assert(bcoin.ec.verify(hash, signature, network.alertKey));
+      delete details.payload;
+      var data = bcoin.protocol.framer.alert(details);
+      details = bcoin.protocol.parser.parseAlert(data);
+      assert(bcoin.ec.verify(hash, signature, network.alertKey));
+    }
+    p.end();
+  });
 });