test/parser: add version test for height and relay / fix typo.

lib/bcoin/peer.js

@@ -101,7 +101,6 @@ Peer.prototype._init = function init() {
     height: this.options.startHeight != null
       ? this.options.startHeight
       : 0,
-      //: this.pool.chain.index.heights[this.pool.chain.index.heights.length-1],
     relay: this.options.relay
   }));
 

lib/bcoin/protocol/parser.js

@@ -123,7 +123,7 @@ Parser.prototype.parseVersion = function parseVersion(p) {
   var nonce = { lo: readU32(p, 72), hi: readU32(p, 76) };
 
   // Start height
-  var weight = readU32(p, 81);
+  var height = readU32(p, 81);
 
   // Relay
   var relay = p.length >= 86 ? p[85] === 1 : true;
@@ -133,7 +133,7 @@ Parser.prototype.parseVersion = function parseVersion(p) {
     services: services,
     ts: ts,
     nonce: nonce,
-    weight: weight,
+    height: height,
     relay: relay
   };
 };

test/protocol-test.js

@@ -25,6 +25,13 @@ describe('Protocol', function() {
   packetTest('version', {}, function(payload) {
     assert.equal(payload.v, 70002);
     assert.equal(payload.relay, false);
+    assert.equal(payload.height, 0);
+  });
+
+  packetTest('version', { relay: true, height: 10 }, function(payload) {
+    assert.equal(payload.v, 70002);
+    assert.equal(payload.relay, true);
+    assert.equal(payload.height, 10);
   });
 
   packetTest('verack', {}, function(payload) {