RanchiMall/fcoin
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #214 from samlanning/is-float

Browse Source 
Various improvements to float parsing
This commit is contained in:
Christopher Jeffrey (JJ) 2017-05-12 13:26:26 -07:00 committed by GitHub
commit bff9ea2c16
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/btc/amount.js
View File

@ -488,7 +488,7 @@ Amount.parse = function parse(value, exp, num) {
Amount.parseUnsafe = function parseUnsafe(value, exp, num) { Amount.parseUnsafe = function parseUnsafe(value, exp, num) {
if (typeof value === 'string') { if (typeof value === 'string') {
assert(util.isFloat(value), 'Non-BTC value for conversion.'); assert(util.isFloat(value), 'Non-BTC value for conversion.');
value = parseFloat(value, 10); value = parseFloat(value);
} else { } else {
assert(util.isNumber(value), 'Non-BTC value for conversion.'); assert(util.isNumber(value), 'Non-BTC value for conversion.');
assert(num, 'Cannot parse number.'); assert(num, 'Cannot parse number.');

5
lib/utils/util.js
View File

@ -392,6 +392,11 @@ util.isHex256 = function isHex256(hash) {
/** /**
* Test whether a string qualifies as a float. * Test whether a string qualifies as a float.
*
* This is stricter than checking if the result of parseFloat() is NaN
* as, e.g. parseFloat successfully parses the string '1.2.3' as 1.2, and
* we also check that the value is a string.
*
* @param {String?} value * @param {String?} value
* @returns {Boolean} * @returns {Boolean}
*/ */