RanchiMall/fcoin
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/http: correctly reject promise return by listen()

Browse Source
This commit is contained in:
Mokhtar Naamani 2017-07-19 00:21:35 +03:00
parent 26ade82a0b
commit c9f736d33f
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/http/base.js
View File

@ -812,10 +812,10 @@ HTTPBase.prototype.address = function address() {
HTTPBase.prototype.listen = function listen(port, host) { HTTPBase.prototype.listen = function listen(port, host) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
let addr; let addr;
this.server.listen(port, host, (err) => {
if (err)
return reject(err);
this.server.once('error', reject)
this.server.listen(port, host, () => {
addr = this.address(); addr = this.address();
this.emit('listening', addr); this.emit('listening', addr);

3
lib/net/tcp.js
View File

@ -41,7 +41,8 @@ tcp.createServer = function createServer() {
ee.listen = function listen(port, host) { ee.listen = function listen(port, host) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
server.listen(port, host, wrap(resolve, reject)); server.once('error', reject)
server.listen(port, host, resolve);
}); });
}; };