From d3f94dbc6a0241f4ae24b9c0361e2f417fb6d85a Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Tue, 7 Feb 2017 13:56:30 -0800 Subject: [PATCH] mempool: force broadcasting on addTX fail. --- lib/mempool/mempool.js | 4 ++-- lib/net/pool.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/mempool/mempool.js b/lib/mempool/mempool.js index e1ff64fe..b7f66aca 100644 --- a/lib/mempool/mempool.js +++ b/lib/mempool/mempool.js @@ -1304,7 +1304,7 @@ Mempool.prototype.storeOrphan = function storeOrphan(tx, missing) { this.logger.debug('Ignoring large orphan: %s', tx.txid()); if (!tx.hasWitness()) this.rejects.add(tx.hash()); - return; + return []; } for (i = 0; i < missing.length; i++) { @@ -1312,7 +1312,7 @@ Mempool.prototype.storeOrphan = function storeOrphan(tx, missing) { if (this.hasReject(prev)) { this.logger.debug('Not storing orphan %s (rejected parents).', tx.txid()); this.rejects.add(tx.hash()); - return; + return []; } } diff --git a/lib/net/pool.js b/lib/net/pool.js index 012a1a6b..c69ef6ad 100644 --- a/lib/net/pool.js +++ b/lib/net/pool.js @@ -2179,7 +2179,7 @@ Pool.prototype._handleTX = co(function* handleTX(peer, packet) { throw err; } - if (missing) { + if (missing && missing.length > 0) { this.logger.debug( 'Requesting %d missing transactions (%s).', missing.length, peer.hostname());