From e59feaf695062229a9091d05c9a4ce05c0e4a0cf Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Wed, 25 May 2016 14:10:55 -0700 Subject: [PATCH] minor. --- lib/bcoin/ec.js | 5 +---- lib/bcoin/utils.js | 10 +++++++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/bcoin/ec.js b/lib/bcoin/ec.js index 27fa3f58..20bf06b8 100644 --- a/lib/bcoin/ec.js +++ b/lib/bcoin/ec.js @@ -208,10 +208,7 @@ ec.privateKeyVerify = function privateKeyVerify(key) { key = new bn(key); - if (key.cmpn(0) === 0 || key.cmp(ec.elliptic.curve.n) >= 0) - return false; - - return true; + return key.cmpn(0) !== 0 && key.cmp(ec.elliptic.curve.n) < 0; }; /** diff --git a/lib/bcoin/utils.js b/lib/bcoin/utils.js index dfbdba11..561a1624 100644 --- a/lib/bcoin/utils.js +++ b/lib/bcoin/utils.js @@ -858,12 +858,15 @@ utils.parseHost = function parseHost(addr) { if (typeof addr === 'object') return addr; - if (addr.indexOf(']') !== -1) + if (addr[0] === '[') { + addr = addr.substring(1); parts = addr.split(/\]:?/); - else + assert(parts.length === 2); + } else { parts = addr.split(':'); + } - host = parts[0].replace(/[\[\]]/g, ''); + host = parts[0]; port = +parts[1] || 0; if (utils.ip.version(host) !== -1) @@ -915,6 +918,7 @@ utils.ip.version = function version(ip) { /** * Test whether a buffer is an ipv4-mapped ipv6 address. + * @param {Buffer} ip * @returns {Boolean} */