Use string joins instead of concatenation for efficiency.

2015-03-17 21:57:06 +09:00 · 2015-03-17 21:57:06 +09:00 · bbcfa44e54
commit bbcfa44e54
parent cabd6bbb2c
1 changed files with 4 additions and 3 deletions
--- a/lib/bmp.py
+++ b/lib/bmp.py
@ -174,12 +174,13 @@ class BitMap(object):

    # write pixels
    self.bitarray.reverse()
+    rows = []
    for row in self.bitarray:
      for pixel in row:
        c = self.palette[pixel]
-        _bitmap += long24ToString(c)
-      for i in range(line_padding):
-        _bitmap += chr( 0 )
+        rows.append(long24ToString(c))
+      rows.append(chr(0) * line_padding)
+    _bitmap += ''.join(rows)

    return _bitmap