RanchiMall/flobank
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug fix that allowed taking loan without having sufficient deposit

Browse Source
This commit is contained in:
sairaj mote 2021-09-20 11:59:15 +05:30
parent f40ac9473d
commit 2e73e0e4c5
1 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
index.html
View File

@ -951,13 +951,13 @@
break; break;
case 'deposit': case 'deposit':
const { I_s } = bank_app.getRates() const { I_s } = bank_app.getRates()
getRef('deposit_interest_rate').textContent = `Make a deposit at ${I_s * 100}%.p.a` getRef('deposit_interest_rate').textContent = `Make a deposit at ${(I_s * 100).toFixed(2)}%.p.a`
// checks if there is transaction pending, if so then shows warning // checks if there is transaction pending, if so then shows warning
checkIfAllowed('deposit') checkIfAllowed('deposit')
break; break;
case 'loan': case 'loan':
const { I_b } = bank_app.getRates() const { I_b } = bank_app.getRates()
getRef('loan_interest_rate').textContent = `Get a loan at ${I_b * 100}%.p.a` getRef('loan_interest_rate').textContent = `Get a loan at ${(I_b * 100).toFixed(2)}%.p.a`
checkIfAllowed('loan') checkIfAllowed('loan')
break; break;
case 'transaction': case 'transaction':
@ -1726,7 +1726,6 @@
getRef('result__icon').innerHTML = utils.getRelatedIcon(status) getRef('result__icon').innerHTML = utils.getRelatedIcon(status)
getRef('result__icon').className = status getRef('result__icon').className = status
getRef('result__back_button').href = `#/${type}` getRef('result__back_button').href = `#/${type}`
debugger
switch (status) { switch (status) {
case 'pending': case 'pending':
getRef('result__title').textContent = `Sent ${type} request` getRef('result__title').textContent = `Sent ${type} request`
@ -12212,18 +12211,24 @@
let index = this.accMap[myFloID] ? this.accMap[myFloID].length : 0; let index = this.accMap[myFloID] ? this.accMap[myFloID].length : 0;
//check for validity of loan (ie, check if enough deposit is present) //check for validity of loan (ie, check if enough deposit is present)
let user = this.getUserDetails(myFloID) let user = this.getUserDetails(myFloID)
if (user.netTotal <= amount) if (user.depositTotal <= amount) {
return reject(`Deposit insufficient! Max eligible loan amount: ${user.netTotal}`); if (user.depositTotal) {
let request = { reject(`Deposit insufficient! Max eligible loan amount: ${user.depositTotal.toLocaleString(`en-IN`, { style: 'currency', currency: 'INR' })}`);
rtype: "openLoan", } else {
index: index, reject(`Deposit insufficient! Please make a deposit first greater than ${amount.toLocaleString(`en-IN`, { style: 'currency', currency: 'INR' })} to take loan.`);
amount: amount, }
sign: floCrypto.signData(this.util.istr + `open#${index}:loan|${amount}`, myPrivKey) } else {
let request = {
rtype: "openLoan",
index: index,
amount: amount,
sign: floCrypto.signData(this.util.istr + `open#${index}:loan|${amount}`, myPrivKey)
}
//send request to banker
floCloudAPI.sendApplicationData(request, "REQUEST")
.then(result => resolve(result))
.catch(error => reject(error))
} }
//send request to banker
floCloudAPI.sendApplicationData(request, "REQUEST")
.then(result => resolve(result))
.catch(error => reject(error))
}) })
}, },