Get blocks by height.

integration/index.js

@@ -45,7 +45,7 @@ describe('Basic Functionality', function() {
     });
   });
 
-  describe('will get correct block data', function() {
+  describe('get blocks by hash', function() {
 
     blockData.forEach(function(data) {
       var block = bitcore.Block.fromString(data);
@@ -58,4 +58,24 @@ describe('Basic Functionality', function() {
     });
   });
 
+  describe('get blocks by height', function() {
+
+    var knownHeights = [
+      [0, '000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f'],
+      [1, '00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048'],
+      [100000,'000000000003ba27aa200b1cecaad478d2b00432346c3f1f3986da1afd33e506'],
+      [314159, '00000000000000001bb82a7f5973618cfd3185ba1ded04dd852a653f92a27c45']
+    ];
+
+    knownHeights.forEach(function(data) {
+      it('block at height ' + data[0], function(done) {
+        bitcoind.getBlock(data[0], function(err, response) {
+          var block = bitcore.Block.fromBuffer(response);
+          block.hash.should.equal(data[1]);
+          done();
+        });
+      });
+    });
+  });
+
 });

src/bitcoindjs.cc

@@ -837,14 +837,20 @@ static void
 async_get_block(uv_work_t *req) {
   async_block_data* data = static_cast<async_block_data*>(req->data);
 
+  CBlockIndex* pblockindex;
   std::string strHash = data->hash;
   uint256 hash(strHash);
 
+  if (data->height != -1) {
+    pblockindex = chainActive[data->height];
+  } else {
     if (mapBlockIndex.count(hash) == 0) {
       data->err_msg = std::string("Block not found.");
+      return;
     } else {
-
+      pblockindex = mapBlockIndex[hash];
-    CBlockIndex* pblockindex = mapBlockIndex[hash];
+    }
+  }
 
   const CDiskBlockPos& pos = pblockindex->GetBlockPos();
 
@@ -876,7 +882,7 @@ async_get_block(uv_work_t *req) {
   data->buffer = buffer;
   data->size = size;
   data->cblock_index = pblockindex;
-  }
+
 }
 
 static void