RanchiMall/flocore-node
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1 from isocolsky/quota_tests

Browse Source 
Quota tests
This commit is contained in:
Matias Alejo Garcia 2014-12-01 18:29:26 -03:00
commit 56e26945bb
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/emailstore.js
View File

@ -396,6 +396,9 @@
emailPlugin.db.del(valueKey(email, key), function(error) { emailPlugin.db.del(valueKey(email, key), function(error) {
if (error) { if (error) {
logger.error(error); logger.error(error);
if (error.notFound) {
return callback(emailPlugin.errors.NOT_FOUND);
}
return callback(emailPlugin.errors.INTERNAL_ERROR); return callback(emailPlugin.errors.INTERNAL_ERROR);
} }
return emailPlugin.checkAndUpdateItemCounter(email, null, null, callback); return emailPlugin.checkAndUpdateItemCounter(email, null, null, callback);
@ -415,7 +418,7 @@
emailPlugin.db.del(validatedKey(email), cb); emailPlugin.db.del(validatedKey(email), cb);
} }
], function(err) { ], function(err) {
if (err) { if (err && !err.notFound) {
logger.error(err); logger.error(err);
return callback(emailPlugin.errors.INTERNAL_ERROR); return callback(emailPlugin.errors.INTERNAL_ERROR);
} }

17
test/test.EmailStore.js
View File

@ -288,6 +288,12 @@ describe('emailstore test', function() {
plugin.exists.onFirstCall().callsArgWith(1, null, false); plugin.exists.onFirstCall().callsArgWith(1, null, false);
plugin.savePassphrase = sinon.stub(); plugin.savePassphrase = sinon.stub();
plugin.savePassphrase.onFirstCall().callsArg(2); plugin.savePassphrase.onFirstCall().callsArg(2);
plugin.isConfirmed = sinon.stub();
plugin.isConfirmed.onFirstCall().callsArgWith(1, null, false);
plugin.checkSizeQuota = sinon.stub();
plugin.checkSizeQuota.onFirstCall().callsArgWith(3, null);
plugin.checkAndUpdateItemQuota = sinon.stub();
plugin.checkAndUpdateItemQuota.onFirstCall().callsArgWith(3, null);
plugin.saveEncryptedData = sinon.stub(); plugin.saveEncryptedData = sinon.stub();
plugin.saveEncryptedData.onFirstCall().callsArg(3); plugin.saveEncryptedData.onFirstCall().callsArg(3);
plugin.createVerificationSecretAndSendEmail = sinon.stub(); plugin.createVerificationSecretAndSendEmail = sinon.stub();
@ -317,6 +323,12 @@ describe('emailstore test', function() {
plugin.exists.onFirstCall().callsArgWith(1, null, true); plugin.exists.onFirstCall().callsArgWith(1, null, true);
plugin.checkPassphrase = sinon.stub(); plugin.checkPassphrase = sinon.stub();
plugin.checkPassphrase.onFirstCall().callsArgWith(2, null, true); plugin.checkPassphrase.onFirstCall().callsArgWith(2, null, true);
plugin.isConfirmed = sinon.stub();
plugin.isConfirmed.onFirstCall().callsArgWith(1, null, false);
plugin.checkSizeQuota = sinon.stub();
plugin.checkSizeQuota.onFirstCall().callsArgWith(3, null);
plugin.checkAndUpdateItemQuota = sinon.stub();
plugin.checkAndUpdateItemQuota.onFirstCall().callsArgWith(3, null);
plugin.saveEncryptedData = sinon.stub(); plugin.saveEncryptedData = sinon.stub();
plugin.saveEncryptedData.onFirstCall().callsArg(3); plugin.saveEncryptedData.onFirstCall().callsArg(3);
plugin.createVerificationSecretAndSendEmail = sinon.stub(); plugin.createVerificationSecretAndSendEmail = sinon.stub();
@ -385,6 +397,10 @@ describe('emailstore test', function() {
}); });
it('deletes a stored element (key)', function(done) { it('deletes a stored element (key)', function(done) {
leveldb_stub.del.onFirstCall().callsArg(1); leveldb_stub.del.onFirstCall().callsArg(1);
plugin.checkAndUpdateItemCounter = sinon.stub();
plugin.checkAndUpdateItemCounter.onFirstCall().callsArg(3);
plugin.deleteByEmailAndKey(fakeEmail, fakeKey, function(err) { plugin.deleteByEmailAndKey(fakeEmail, fakeKey, function(err) {
expect(err).to.be.undefined; expect(err).to.be.undefined;
done(); done();
@ -440,6 +456,7 @@ describe('emailstore test', function() {
response.send.onFirstCall().returnsThis(); response.send.onFirstCall().returnsThis();
plugin.addValidationHeader = sinon.stub().callsArg(2); plugin.addValidationHeader = sinon.stub().callsArg(2);
plugin.addValidationAndQuotaHeader = sinon.stub().callsArg(2);
plugin.retrieve(request, response); plugin.retrieve(request, response);