From 639463bb1b49bb341078e32580f5aa3e57c9821b Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Wed, 22 Oct 2014 22:26:02 -0700 Subject: [PATCH] comments. --- src/bitcoindjs.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bitcoindjs.cc b/src/bitcoindjs.cc index 14c3d987..9072b87b 100644 --- a/src/bitcoindjs.cc +++ b/src/bitcoindjs.cc @@ -3833,6 +3833,7 @@ NAN_METHOD(HookPackets) { } next = cur->next; + // XXX Figure out what to do here: // delete cur->pfrom; // cleaned up elsewhere? C++ I DON'T UNDERSTAND YOU free(cur->strCommand); // delete cur->vRecv; // cleaned up elsewhere? @@ -3945,6 +3946,8 @@ process_packet(CNode* pfrom, string strCommand, CDataStream& vRecv, int64_t nTim //cur->pfrom = pfrom; + // XXX Bad - sends version again and creates a new global peer + // XXX Figure out what to do here CNode *pfrom_ = new CNode(pfrom->hSocket, pfrom->addr, pfrom->addrName, pfrom->fInbound); // copy properties here: @@ -3994,7 +3997,6 @@ process_packet(CNode* pfrom, string strCommand, CDataStream& vRecv, int64_t nTim pfrom_->setKnown = pfrom->setKnown; pfrom_->setInventoryKnown = pfrom->setInventoryKnown; pfrom_->vInventoryToSend = pfrom->vInventoryToSend; - pfrom_->vInventoryToSend = pfrom->vInventoryToSend; //pfrom_->cs_inventory = pfrom->cs_inventory; pfrom_->mapAskFor = pfrom->mapAskFor; pfrom_->nPingNonceSent = pfrom->nPingNonceSent;