From 79ae3bb41245c6cb950637a908538d53945c9680 Mon Sep 17 00:00:00 2001
From: Patrick Nagurny <patrick@bitpay.com>
Date: Fri, 4 Sep 2015 13:12:56 -0400
Subject: [PATCH] handle getFee() error

---
 lib/services/address.js                     |  3 ++-
 test/scaffold/create.integration.js         |  3 +++
 test/scaffold/default-config.integration.js |  3 +++
 test/services/address.unit.js               | 19 +++++++++++++------
 4 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/lib/services/address.js b/lib/services/address.js
index 149c5106..5cdf2362 100644
--- a/lib/services/address.js
+++ b/lib/services/address.js
@@ -514,7 +514,8 @@ AddressService.prototype.getAddressHistoryForAddress = function(address, queryMe
           height: transaction.__height,
           confirmations: confirmations,
           timestamp: transaction.__timestamp,
-          fees: transaction.getFee(),
+          // TODO bitcore should return null instead of throwing error on coinbase
+          fees: !transaction.isCoinbase() ? transaction.getFee() : null,
           outputIndexes: [],
           inputIndexes: [],
           tx: transaction
diff --git a/test/scaffold/create.integration.js b/test/scaffold/create.integration.js
index 313a3908..ffa01224 100644
--- a/test/scaffold/create.integration.js
+++ b/test/scaffold/create.integration.js
@@ -53,6 +53,9 @@ describe('#create', function() {
   });
 
   it('will create scaffold files', function() {
+    delete process.env.BITCORENODE_DIR;
+    delete process.env.BITCORENODE_NETWORK;
+    delete process.env.BITCORENODE_PORT;
 
     create({
       cwd: testDir,
diff --git a/test/scaffold/default-config.integration.js b/test/scaffold/default-config.integration.js
index fba294d0..23f9c598 100644
--- a/test/scaffold/default-config.integration.js
+++ b/test/scaffold/default-config.integration.js
@@ -7,6 +7,9 @@ describe('#defaultConfig', function() {
 
   it('will return expected configuration', function() {
     var cwd = process.cwd();
+    delete process.env.BITCORENODE_DIR;
+    delete process.env.BITCORENODE_NETWORK;
+    delete process.env.BITCORENODE_PORT;
     var home = process.env.HOME;
     var info = defaultConfig();
     info.path.should.equal(cwd);
diff --git a/test/services/address.unit.js b/test/services/address.unit.js
index 570a2dbc..2b7c2a89 100644
--- a/test/services/address.unit.js
+++ b/test/services/address.unit.js
@@ -767,7 +767,8 @@ describe('Address Service', function() {
         height: 1,
         timestamp: 1438289011844,
         satoshis: 5000,
-        getFee: sinon.stub().returns(1000)
+        getFee: sinon.stub().throws(new Error('inputs not populated')),
+        isCoinbase: sinon.stub().returns(true)
       },
       {
         txid: 'tx3',
@@ -775,7 +776,8 @@ describe('Address Service', function() {
         height: 3,
         timestamp: 1438289031844,
         satoshis: 2000,
-        getFee: sinon.stub().returns(1000)
+        getFee: sinon.stub().returns(1000),
+        isCoinbase: sinon.stub().returns(false)
       },
       {
         txid: 'tx4',
@@ -785,7 +787,8 @@ describe('Address Service', function() {
         height: 4,
         timestamp: 1438289041844,
         satoshis: 3000,
-        getFee: sinon.stub().returns(1000)
+        getFee: sinon.stub().returns(1000),
+        isCoinbase: sinon.stub().returns(false)
       },
     ];
 
@@ -801,7 +804,8 @@ describe('Address Service', function() {
             }
           }
         ],
-        getFee: sinon.stub().returns(1000)
+        getFee: sinon.stub().returns(1000),
+        isCoinbase: sinon.stub().returns(false)
       },
       {
         txid: 'tx5',
@@ -815,7 +819,8 @@ describe('Address Service', function() {
             }
           }
         ],
-        getFee: sinon.stub().returns(1000)
+        getFee: sinon.stub().returns(1000),
+        isCoinbase: sinon.stub().returns(false)
       }
     ];
 
@@ -836,6 +841,7 @@ describe('Address Service', function() {
             transaction.__height = incoming[i].height;
             transaction.__timestamp = incoming[i].timestamp;
             transaction.getFee = incoming[i].getFee;
+            transaction.isCoinbase = incoming[i].isCoinbase;
             return callback(null, transaction);
           }
         }
@@ -850,6 +856,7 @@ describe('Address Service', function() {
             transaction.__timestamp = outgoing[i].timestamp;
             transaction.inputs = outgoing[i].inputs;
             transaction.getFee = outgoing[i].getFee;
+            transaction.isCoinbase = outgoing[i].isCoinbase;
             return callback(null, transaction);
           }
         }
@@ -890,7 +897,7 @@ describe('Address Service', function() {
         history[0].satoshis.should.equal(5000);
         history[0].height.should.equal(1);
         history[0].timestamp.should.equal(1438289011844);
-        history[0].fees.should.equal(1000);
+        should.equal(history[0].fees, null);
         history[1].tx.hash.should.equal('tx2');
         history[1].satoshis.should.equal(-5000);
         history[1].height.should.equal(2);