From afda35962b3513b93523367ef44c157c3ff0ca0d Mon Sep 17 00:00:00 2001
From: Braydon Fuller <courier@braydon.com>
Date: Mon, 18 Apr 2016 13:37:37 -0400
Subject: [PATCH] test: mempool helper method unit tests

---
 lib/services/bitcoind.js       |  2 +-
 test/services/bitcoind.unit.js | 65 ++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+), 1 deletion(-)

diff --git a/lib/services/bitcoind.js b/lib/services/bitcoind.js
index 58de911f..73c1ab74 100644
--- a/lib/services/bitcoind.js
+++ b/lib/services/bitcoind.js
@@ -769,7 +769,7 @@ Bitcoin.prototype._getTxidsFromMempool = function(deltas) {
 };
 
 Bitcoin.prototype._getHeightRangeQuery = function(options, clone) {
-  if (options.start >= 0 && options.end >=0) {
+  if (options.start >= 0 && options.end >= 0) {
     if (options.end > options.start) {
       throw new TypeError('"end" is expected to be less than or equal to "start"');
     }
diff --git a/test/services/bitcoind.unit.js b/test/services/bitcoind.unit.js
index dddad6bb..fb2fc7ca 100644
--- a/test/services/bitcoind.unit.js
+++ b/test/services/bitcoind.unit.js
@@ -1308,12 +1308,77 @@ describe('Bitcoin Service', function() {
   });
 
   describe('#_getBalanceFromMempool', function() {
+    it('will sum satoshis', function() {
+      var bitcoind = new BitcoinService(baseConfig);
+      var deltas = [
+        {
+          satoshis: -1000,
+        },
+        {
+          satoshis: 2000,
+        },
+        {
+          satoshis: -10,
+        }
+      ];
+      var sum = bitcoind._getBalanceFromMempool(deltas);
+      sum.should.equal(990);
+    });
   });
 
   describe('#_getTxidsMempool', function() {
+    it('will filter to txids', function() {
+      var bitcoind = new BitcoinService(baseConfig);
+      var deltas = [
+        {
+          txid: 'txid0',
+        },
+        {
+          txid: 'txid1',
+        },
+        {
+          txid: 'txid2',
+        }
+      ];
+      var txids = bitcoind._getTxidsFromMempool(deltas);
+      txids.length.should.equal(3);
+      txids[0].should.equal('txid0');
+      txids[1].should.equal('txid1');
+      txids[2].should.equal('txid2');
+    });
   });
 
   describe('#_getHeightRangeQuery', function() {
+    it('will detect range query', function() {
+      var bitcoind = new BitcoinService(baseConfig);
+      var options = {
+        start: 20,
+        end: 0
+      };
+      var rangeQuery = bitcoind._getHeightRangeQuery(options);
+      rangeQuery.should.equal(true);
+    });
+    it('will get range properties', function() {
+      var bitcoind = new BitcoinService(baseConfig);
+      var options = {
+        start: 20,
+        end: 0
+      };
+      var clone = {};
+      bitcoind._getHeightRangeQuery(options, clone);
+      clone.end.should.equal(20);
+      clone.start.should.equal(0);
+    });
+    it('will throw error with invalid range', function() {
+      var bitcoind = new BitcoinService(baseConfig);
+      var options = {
+        start: 0,
+        end: 20
+      };
+      (function() {
+        bitcoind._getHeightRangeQuery(options);
+      }).should.throw('"end" is expected');
+    });
   });
 
   describe('#getAddressTxids', function() {