RanchiMall/flocore-node
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bitcoind: handle block height number as string

Browse Source
This commit is contained in:
Braydon Fuller 2016-05-16 18:01:12 -04:00
parent 484b707589
commit fa6474e85f
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/services/bitcoind.js
View File

@ -1380,9 +1380,10 @@ Bitcoin.prototype.getAddressSummary = function(addressArg, options, callback) {
Bitcoin.prototype._maybeGetBlockHash = function(blockArg, callback) {
var self = this;
if (_.isNumber(blockArg)) {
if (_.isNumber(blockArg) || blockArg.length < 64) {
var height = parseInt(blockArg, 10);
self._tryAll(function(done) {
self.client.getBlockHash(blockArg, function(err, response) {
self.client.getBlockHash(height, function(err, response) {
if (err) {
return done(self._wrapRPCError(err));
}

19
test/services/bitcoind.unit.js
View File

@ -2789,6 +2789,25 @@ describe('Bitcoin Service', function() {
done();
});
});
it('will get the block hash if argument is a number (as string)', function(done) {
var bitcoind = new BitcoinService(baseConfig);
var getBlockHash = sinon.stub().callsArgWith(1, null, {
result: 'blockhash'
});
bitcoind.nodes.push({
client: {
getBlockHash: getBlockHash
}
});
bitcoind._maybeGetBlockHash('10', function(err, hash) {
if (err) {
return done(err);
}
hash.should.equal('blockhash');
getBlockHash.callCount.should.equal(1);
done();
});
});
it('will try multiple nodes if one fails', function(done) {
var bitcoind = new BitcoinService(baseConfig);
var getBlockHash = sinon.stub().callsArgWith(1, null, {