From ed0bcc962a873c3d830dde1a0822ea927d3002b9 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 23 Apr 2015 16:09:56 -0300 Subject: [PATCH] small changes after code review --- docs/messages.md | 2 +- lib/messages/message.js | 3 +-- test/messages/message.js | 4 +++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/messages.md b/docs/messages.md index c2721c3..7cfc274 100644 --- a/docs/messages.md +++ b/docs/messages.md @@ -36,7 +36,7 @@ For advanced usage, you can also customize which constructor is used for Block a var messages = new Messages({Block: MyBlock, Transaction: MyTransaction}); ``` -And additionally custom network: +And additionally a custom network: ```javascript var messages = new Messages({network: Networks.testnet}); diff --git a/lib/messages/message.js b/lib/messages/message.js index 3d04235..62feeff 100644 --- a/lib/messages/message.js +++ b/lib/messages/message.js @@ -2,7 +2,6 @@ var bitcore = require('bitcore'); var $ = bitcore.util.preconditions; -var Networks = bitcore.Networks; var BufferWriter = bitcore.encoding.BufferWriter; var Hash = bitcore.crypto.Hash; @@ -16,7 +15,7 @@ var Hash = bitcore.crypto.Hash; */ function Message(options) { this.command = options.command; - this.network = options.network || Networks.defaultNetwork; + this.network = options.network; } /** diff --git a/test/messages/message.js b/test/messages/message.js index 67767b8..115bb90 100644 --- a/test/messages/message.js +++ b/test/messages/message.js @@ -3,6 +3,7 @@ var should = require('chai').should(); var P2P = require('../../'); var Message = P2P.Messages.Message; +var Networks = require('bitcore').Networks; describe('Message', function() { @@ -23,7 +24,8 @@ describe('Message', function() { describe('#toBuffer', function() { it('serialize to a buffer', function() { var message = new Message({ - command: 'command' + command: 'command', + network: Networks.defaultNetwork }); message.getPayload = function() { return new Buffer(0);