From 449e947966eb5a7853499358e68c0e588abdb40e Mon Sep 17 00:00:00 2001
From: Sagiv Ofek <sagiv4@gmail.com>
Date: Sat, 23 Aug 2014 18:11:28 -0400
Subject: [PATCH] fix bug - 0 fee is not working!

if the user pass 0 fee (in fee or feeSat arguments) - there's a bug in the program that will add fee even if specified 0 fee:

- in case fee or feeSat is 0 the if statement `if (opts.fee || opts.feeSat)` will be false.
from some reason `0 || undefined` in js returns `undefined` and in case a user set the fee to 0 in options this condition will not happen.

- second fix: `var feeSat = this.givenFeeSat ? ...` fixed since if `this.givenFeeSat` is 0 the condition will return false (and we want true in this case) since `0 ? true : false` will return `false` in js language.
---
 lib/TransactionBuilder.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/TransactionBuilder.js b/lib/TransactionBuilder.js
index 40e544d..ce33313 100644
--- a/lib/TransactionBuilder.js
+++ b/lib/TransactionBuilder.js
@@ -112,6 +112,7 @@ function TransactionBuilder(opts) {
   if (opts.fee || opts.feeSat) {
     this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
   }
+  if (opts.fee == 0 || opts.feeSat == 0) this.givenFeeSat = 0;
   this.remainderOut = opts.remainderOut;
   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
 
@@ -358,7 +359,7 @@ TransactionBuilder.prototype._setFeeAndRemainder = function(txobj) {
     /* based on https://en.bitcoin.it/wiki/Transaction_fees */
     maxSizeK = parseInt(size / 1000) + 1;
 
-    var feeSat = this.givenFeeSat ?
+    var feeSat = this.givenFeeSat || this.givenFeeSat == 0  ?
       this.givenFeeSat : maxSizeK * FEE_PER_1000B_SAT;
 
     var neededAmountSat = this.valueOutSat.add(feeSat);