From 6e36baebc6c3c0a860de16062b9b4b1aa5d75518 Mon Sep 17 00:00:00 2001
From: Braydon Fuller <braydon@bitpay.com>
Date: Mon, 1 Dec 2014 17:55:57 -0500
Subject: [PATCH] Tests: Enable tests for network, include defaultNetwork,
 check each constant, build browser tests before running to make sure it's
 up-to-date

---
 gulpfile.js      |  2 +-
 lib/networks.js  |  1 -
 test/networks.js | 25 ++++++++++++-------------
 3 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/gulpfile.js b/gulpfile.js
index b227ceb..142f8db 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -110,7 +110,7 @@ gulp.task('browser-all', ['errors'], function(callback) {
   runSequence(['browser'], ['browser-test'], callback);
 });
 
-gulp.task('karma', testKarma);
+gulp.task('karma', ['browser-test'], testKarma);
 
 gulp.task('errors', shell.task([
   'node ./lib/errors/build.js'
diff --git a/lib/networks.js b/lib/networks.js
index 2419252..a37a5cf 100644
--- a/lib/networks.js
+++ b/lib/networks.js
@@ -69,6 +69,5 @@ module.exports = {
   defaultNetwork: livenet,
   livenet: livenet,
   testnet: testnet,
-  mainnet: livenet,
   get: getNetwork
 };
diff --git a/test/networks.js b/test/networks.js
index f58e9dd..af09951 100644
--- a/test/networks.js
+++ b/test/networks.js
@@ -2,24 +2,23 @@
 
 var should = require('chai').should();
 var bitcore = require('..');
-var Networks = bitcore.Networks;
+var networks = bitcore.Networks;
 
 describe('Networks', function() {
 
   it('should contain all Networks', function() {
-    should.exist(Networks.livenet);
-    should.exist(Networks.testnet);
-    should.exist(Networks.mainnet);
+    should.exist(networks.livenet);
+    should.exist(networks.testnet);
+    should.exist(networks.defaultNetwork);
   });
-  describe('contain all constants for livenet and testnet', function() {
-    var makeTest = function(key) {
-      Networks.testnet.hasOwnProperty(key).should.equal(true);
-    };
-    for (var key in Networks.livenet) {
-      if (Networks.livenet.hasOwnProperty(key)) {
-        it('all should contain ' + key, makeTest(key));
-      }
-    }
+
+  var constants = ['name', 'alias', 'pubkeyhash', 'scripthash', 'xpubkey', 'xprivkey'];
+
+  constants.forEach(function(key){
+    it('should have constant '+key+' for livenet and testnet', function(){
+      networks.testnet.hasOwnProperty(key).should.equal(true);
+      networks.livenet.hasOwnProperty(key).should.equal(true);
+    });
   });
 
 });