From 70d9f0db93012a4a1f2a018ac4104b2b601cef80 Mon Sep 17 00:00:00 2001 From: "Ryan X. Charles" Date: Wed, 17 Sep 2014 14:41:51 -0700 Subject: [PATCH] use base58check in extendedPublicKeyString --- lib/bip32.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/bip32.js b/lib/bip32.js index b5c34d1..a4e6876 100644 --- a/lib/bip32.js +++ b/lib/bip32.js @@ -140,12 +140,9 @@ BIP32.prototype.buildExtendedPublicKey = function() { BIP32.prototype.extendedPublicKeyString = function(format) { if (format === undefined || format === 'base58') { - var hash = Hash.sha256sha256(this.extendedPublicKey); - var checksum = hash.slice(0, 4); - var data = Buffer.concat([this.extendedPublicKey, checksum]); - return base58.encode(data); + return Base58Check.encode(this.extendedPublicKey); } else if (format === 'hex') { - return this.extendedPublicKey.toString('hex');; + return this.extendedPublicKey.toString('hex'); } else { throw new Error('bad format'); }