RanchiMall/flocore
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

allowing sign keys to be strings

Browse Source 
no need to pass array of one element to sign a transaction, you can simply pass the private key string (one or more separated by commas) and convert it to array. make user's life easier :)
This commit is contained in:
Sagiv Ofek 2014-08-22 20:14:17 -04:00 committed by Esteban Ordano
parent f21cb1d8b0
commit 9096fc4928
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/TransactionBuilder.js
View File

@ -744,8 +744,9 @@ fnToSign[Script.TX_SCRIPTHASH] = TransactionBuilder.prototype._signScriptHash;
// sign // sign
// ---- // ----
// Signs a transaction. // Signs a transaction.
// `keys`: an array of strings representing private keys to sign the // `keys`: an array of strings representing private keys to sign the transaction in WIF private key format
// transaction in WIF private key format OR bitcore's `WalletKey` objects // OR bitcore's `WalletKey` objects
// OR string representing private keys to sign the transaction in WIF private key format separated by commas
// //
// If multiple keys are given, each will be tested against the transaction's // If multiple keys are given, each will be tested against the transaction's
// scriptPubKeys. Only the valid private keys will be used to sign. // scriptPubKeys. Only the valid private keys will be used to sign.
@ -756,6 +757,7 @@ fnToSign[Script.TX_SCRIPTHASH] = TransactionBuilder.prototype._signScriptHash;
// //
// //
TransactionBuilder.prototype.sign = function(keys) { TransactionBuilder.prototype.sign = function(keys) {
if (typeof keys === "string") keys = keys.split(',');
if (!(keys instanceof Array)) if (!(keys instanceof Array))
throw new Error('parameter should be an array'); throw new Error('parameter should be an array');

2
test/test.TransactionBuilder.js
View File

@ -935,7 +935,7 @@ describe('TransactionBuilder', function() {
var b = getP2shBuilder(1); var b = getP2shBuilder(1);
(function() { (function() {
b.sign(testdata.dataUnspentSign.keyStringsP2sh[0]) b.sign(testdata.dataUnspentSign.keyStringsP2sh[0])
}).should.throw('array'); }).should.not.throw('array');
}); });