RanchiMall/flocore
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drop cached value for inputAmount and outputAmount

Browse Source
This commit is contained in:
Kirill Fomichev 2015-03-31 16:22:27 +03:00
parent 81fde862e6
commit c010cb8c50
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/transaction/transaction.js
View File

@ -570,6 +570,7 @@ Transaction.prototype.addInput = function(input, outputScript, satoshis) {
Transaction.prototype.uncheckedAddInput = function(input) { Transaction.prototype.uncheckedAddInput = function(input) {
$.checkArgumentType(input, Input, 'input'); $.checkArgumentType(input, Input, 'input');
this.inputs.push(input); this.inputs.push(input);
this._inputAmount = undefined;
this._updateChangeOutput(); this._updateChangeOutput();
return this; return this;
}; };
@ -805,6 +806,7 @@ Transaction.prototype._estimateSize = function() {
Transaction.prototype._removeOutput = function(index) { Transaction.prototype._removeOutput = function(index) {
var output = this.outputs[index]; var output = this.outputs[index];
this.outputs = _.without(this.outputs, output); this.outputs = _.without(this.outputs, output);
this._outputAmount = undefined;
}; };
Transaction.prototype.removeOutput = function(index) { Transaction.prototype.removeOutput = function(index) {
@ -864,6 +866,7 @@ Transaction.prototype.removeInput = function(txId, outputIndex) {
} }
var input = this.inputs[index]; var input = this.inputs[index];
this.inputs = _.without(this.inputs, input); this.inputs = _.without(this.inputs, input);
this._inputAmount = undefined;
this._updateChangeOutput(); this._updateChangeOutput();
}; };

8
test/transaction/transaction.js
View File

@ -498,17 +498,19 @@ describe('Transaction', function() {
var transaction = new Transaction() var transaction = new Transaction()
.from(simpleUtxoWith1BTC); .from(simpleUtxoWith1BTC);
transaction.inputs.length.should.equal(1); transaction.inputs.length.should.equal(1);
transaction.inputAmount.should.equal(simpleUtxoWith1BTC.satoshis);
transaction.removeInput(0); transaction.removeInput(0);
transaction.inputAmount.should.equal(0);
transaction.inputs.length.should.equal(0); transaction.inputs.length.should.equal(0);
transaction.inputAmount.should.equal(0);
}); });
it('can remove an input by transaction id', function() { it('can remove an input by transaction id', function() {
var transaction = new Transaction() var transaction = new Transaction()
.from(simpleUtxoWith1BTC); .from(simpleUtxoWith1BTC);
transaction.inputs.length.should.equal(1); transaction.inputs.length.should.equal(1);
transaction.inputAmount.should.equal(simpleUtxoWith1BTC.satoshis);
transaction.removeInput(simpleUtxoWith1BTC.txId, simpleUtxoWith1BTC.outputIndex); transaction.removeInput(simpleUtxoWith1BTC.txId, simpleUtxoWith1BTC.outputIndex);
transaction.inputAmount.should.equal(0);
transaction.inputs.length.should.equal(0); transaction.inputs.length.should.equal(0);
transaction.inputAmount.should.equal(0);
}); });
it('fails if the index provided is invalid', function() { it('fails if the index provided is invalid', function() {
var transaction = new Transaction() var transaction = new Transaction()
@ -522,8 +524,10 @@ describe('Transaction', function() {
.to(toAddress, 40000000) .to(toAddress, 40000000)
.to(toAddress, 40000000); .to(toAddress, 40000000);
transaction.outputs.length.should.equal(2); transaction.outputs.length.should.equal(2);
transaction.outputAmount.should.equal(80000000);
transaction.removeOutput(0); transaction.removeOutput(0);
transaction.outputs.length.should.equal(1); transaction.outputs.length.should.equal(1);
transaction.outputAmount.should.equal(40000000);
}); });
}); });