Commit Graph

826 Commits

Author SHA1 Message Date
Manuel Araoz
fe17f20a97 remove console.log 2015-04-29 18:57:17 -03:00
Manuel Araoz
d556a0c33d fix regressions 2015-04-29 18:55:42 -03:00
Manuel Araoz
dfc075e5d1 fix block parsing problem 2015-04-29 17:29:33 -03:00
Manuel Araoz
270413a655 add simpler test that fails 2015-04-29 15:54:41 -03:00
Manuel Araoz
722eddb894 add test that exposes bug 2015-04-29 15:31:46 -03:00
Braydon Fuller
a03daab866 Merge pull request #1196 from maraoz/script/coverage
increase script test coverage
2015-04-29 10:20:45 -04:00
Manuel Araoz
e1921429cf remove stray console.log 2015-04-28 19:17:45 -03:00
Manuel Araoz
100e370295 fix regressions after changes 2015-04-28 17:10:06 -03:00
Manuel Araoz
9a50958943 fix Block#toObject API 2015-04-28 16:42:56 -03:00
Manuel Araoz
dff0891871 add failing test for Block#toObject 2015-04-28 15:17:41 -03:00
Daniel Cousens
05a8cf9630 sighash: remove dead branch 2015-04-27 18:49:45 +10:00
Manuel Araoz
2cccf20c9d improve docs to show signatures type 2015-04-22 14:33:09 -03:00
Manuel Araoz
ee6f8d35ef increase script test coverage 2015-04-22 14:32:10 -03:00
Manuel Araoz
e25ffde6db refactor networks 2015-04-20 12:21:14 -03:00
Kirill Fomichev
ca96359f40 Immutable network Object 2015-04-11 17:05:46 +03:00
Braydon Fuller
bcd4efb724 Added checkState for positive integer in Output satoshis 2015-04-10 18:39:08 -04:00
Braydon Fuller
3005e19cbf Added precondition to transaction.to for a positive integer as an amount 2015-04-10 18:07:20 -04:00
Braydon Fuller
6367cbe368 Fixed typos in transaction.verify error messages 2015-04-08 12:46:18 -04:00
Manuel Araoz
e331c4ea49 allow addresses to have surrounding whitespace in validation 2015-03-31 17:54:06 -03:00
Kirill Fomichev
c010cb8c50 drop cached value for inputAmount and outputAmount 2015-03-31 16:22:27 +03:00
Manuel Aráoz
53d23e501c Merge pull request #1162 from fanatid/fix/isPublicKeyHashOut
[BUG] Script.isPublicKeyHashOut
2015-03-30 02:31:09 -03:00
eordano
662099a36e Use Networks.get with 2 args when possible 2015-03-29 22:57:31 -03:00
eordano
4f4b2b93fb Allow arrays as second arg to Networks.get 2015-03-29 22:56:29 -03:00
Kirill Fomichev
116024a7cb fix Script.isPublicKeyHashOut 2015-03-29 20:55:13 +03:00
Braydon Fuller
f034a71929 Network Fixes
- Fixed Address classification for a custom network
- Added ability to remove a custom network
- Increased test coverage for Address
2015-03-28 19:09:58 -04:00
Chris Arnesen
8af63ec8d0 update transaction.getFee() JSDoc 2015-03-26 15:41:41 -07:00
Eric Martindale
c759401373 Fix tests, address commentary from @braydonf. 2015-03-24 17:57:39 -04:00
Eric Martindale
9ece2f78ed Fix bug if no value is supplied. 2015-03-24 16:28:13 -04:00
Manuel Araoz
21266570d4 refactor code 2015-03-20 15:49:26 -03:00
Manuel Araoz
7da4c7925a lazy calc for xpubkey in HDPrivateKey 2015-03-20 15:49:26 -03:00
Manuel Araoz
ef7eafbb0c increase test coverage and fix some bugs 2015-03-18 18:58:41 -03:00
Manuel Araoz
e0b1ca0e10 move some script logic from Address to Script 2015-03-18 17:59:09 -03:00
Manuel Araoz
3619c7c9e2 fix problematic cases 2015-03-18 17:40:26 -03:00
Manuel Araoz
a9328d76ff add extra test 2015-03-18 17:22:32 -03:00
Manuel Araoz
62ea45a524 refactor Address<->Script relation 2015-03-18 16:54:16 -03:00
eordano
294ff097a1 Add error if shuffle function doesnt return an expected result 2015-03-11 15:49:42 -03:00
eordano
a37e7b140c Add functionality to randomize outputs 2015-03-11 15:38:53 -03:00
Manuel Araoz
b92fd915eb increase coverage for Input and Output, fix some bugs 2015-02-27 18:46:27 -03:00
Manuel Araoz
d5fd3919c9 add Transaction#inputAmount and outputAmount 2015-02-27 16:38:48 -03:00
Manuel Aráoz
220a5bb566 Merge pull request #1115 from eordano/fix/privCheck
Fix validation error
2015-02-24 17:58:42 -03:00
eordano
9409698e06 Fix validation error 2015-02-24 17:49:26 -03:00
eordano
405f4f43df Update dust amount 2015-02-24 17:24:22 -03:00
eordano
2f86f323c0 Add link when throwing a serialization error 2015-02-24 16:41:15 -03:00
eordano
97671abfdc Add more docs on serialization checks 2015-02-24 16:36:08 -03:00
eordano
b81624480a transaction: Fix verbosity of jsdocs 2015-02-24 16:34:52 -03:00
eordano
c5d7eacfac Add check for output amount > input amount 2015-02-24 16:34:52 -03:00
Esteban Ordano
bd172e7c09 Merge pull request #1110 from maraoz/fix/#1096
fix #1096: PrivateKey#toAddress(network)
2015-02-24 15:54:16 -03:00
Manuel Araoz
c4666044e9 fix #1096: PrivateKey#toAddress(network) 2015-02-24 15:34:44 -03:00
eordano
575993967c Standardize optional parameters to Closure syntax 2015-02-24 15:31:13 -03:00
eordano
fcc9081ddd Fix JSDocs from String to string 2015-02-24 15:31:12 -03:00
Manuel Aráoz
684dfd5283 Merge pull request #1102 from throughnothing/merkleblock
Add MerkleBlock
2015-02-24 14:59:19 -03:00
Braydon Fuller
fb01bc09e4 Added test to check that merkle nodes do not match, and misc jshint fixes. 2015-02-24 11:38:06 -05:00
eordano
f0f90c5d6a Change unnecesarily big name 2015-02-24 13:04:40 -03:00
eordano
a6df7a175e Better granularity on serialize() checks 2015-02-24 13:02:34 -03:00
William Wolf
3eb95b6576 _traverseMerkleTree state cleanup + improve hasTransactions() 2015-02-24 00:51:38 -08:00
William Wolf
bb0efd2108 Remove _validMerkleTree caching 2015-02-23 19:40:52 -08:00
William Wolf
a478e39524 Review Fixes 2015-02-23 10:05:45 -08:00
Manuel Aráoz
0031ae8089 Merge pull request #1104 from eordano/fix/1095
Fix bug on HDKeys not returning the correct network when requesting a PrivateKey/PublicKey from the HDKey
2015-02-23 12:29:08 -03:00
eordano
a07d90dfbf Fix error on public key for hdpublickey 2015-02-23 12:10:51 -03:00
eordano
89d78019d8 Fix bug on hdprivate key generation 2015-02-23 11:40:31 -03:00
William Wolf
a67084d176 cleanup 2015-02-23 01:06:22 -08:00
William Wolf
c558c4e34a hasTransaction(tx) + tests 2015-02-22 21:10:50 -08:00
William Wolf
611dae5b55 validMerkleTree() method plus more test blocks 2015-02-22 21:10:50 -08:00
William Wolf
a32d8dbab8 Add block/index.js 2015-02-22 21:10:50 -08:00
William Wolf
4b601c3711 Move block.js and blockheader.js into lib/block/ 2015-02-22 21:10:50 -08:00
William Wolf
32583fbbe3 Cleanup test 2015-02-22 21:10:49 -08:00
William Wolf
29c18e22f0 Add lib/block/merkleblock.js 2015-02-22 21:10:49 -08:00
dskloet
2c5219e32c typo 2015-02-21 19:46:26 +01:00
dskloet
38bae9a1da Fix JS doc annotations in publickey.js 2015-02-21 19:42:38 +01:00
eordano
9c3170cb3a HDPublicKey: Add precondition checks for static methods 2015-02-18 13:14:12 -03:00
eordano
0938eadab5 Add precondition checks to HDPrivateKey.from* 2015-02-18 13:14:12 -03:00
Manuel Aráoz
e2ff93b714 Merge pull request #1083 from eordano/feature/multisigchecks
Transaction: Check that threshold is less than amount of signatures
2015-02-18 12:01:58 -03:00
eordano
1a5780e35e Script/Address: Add check for valid number of threshold needed 2015-02-18 11:53:22 -03:00
eordano
c19d5c6501 Transaction: Check that threshold is less than amount of signatures 2015-02-18 11:52:50 -03:00
Manuel Aráoz
4c822e06c5 Merge pull request #1078 from eordano/fix/smallFee
Add check for small fees
2015-02-18 11:30:21 -03:00
Braydon Fuller
cb5648cbe4 Merge pull request #1084 from eordano/update/opreturn80
Script: Update max length for standard opreturn to 80
2015-02-18 09:09:28 -05:00
eordano
0bbde0c9de Script: Update max length for standard opreturn to 80 2015-02-18 10:46:47 -03:00
Esteban Ordano
5d904a393d Merge pull request #1074 from thofmann/cleanup/requirements
Cleanup/requirements
2015-02-18 09:58:16 -03:00
Elichai Turkel
4524400fe7 Added 2 more testnet DNSs
I added the missing testnet DNSs that exist in Bitcoin code: https://github.com/bitcoin/bitcoin/blob/master/src/chainparams.cpp#L212
2015-02-17 18:19:56 +02:00
eordano
7e88167891 Add check for small fees 2015-02-16 12:47:53 -03:00
Trevin Hofmann
374e43bed2 Properly capitalize Base58Check and Base58 2015-02-13 21:40:20 -06:00
Trevin Hofmann
59a9e40f13 Properly capitalize BufferUtil everywhere
Right out of CONTRIBUTING.md

https://github.com/bitpay/bitcore/blob/master/CONTRIBUTING.md#g6---naming-utility-namespaces
2015-02-13 21:21:06 -06:00
Trevin Hofmann
ea2a0163c4 Remove redundant util requirement
The Transaction class was requiring bitcore.util.js twice, as `util` and
`JSUtil`. It seems `JSUtil` is the standard name in other classes.
2015-02-13 21:06:51 -06:00
Trevin Hofmann
5bb750252d Add inspect method to Opcode. 2015-02-12 09:27:42 -06:00
Manuel Aráoz
a9533546b2 remove console.log 2015-02-11 19:28:15 -03:00
Esteban Ordano
cca1e2148c Improve test coverage on multisig 2015-02-11 19:10:57 -03:00
Manuel Aráoz
fe731371cf Merge pull request #1016 from yemel/fix/path-validation
Fix hd string path parsing
2015-02-11 12:54:00 -03:00
Manuel Aráoz
994ea957d4 Merge pull request #1061 from eordano/refactor/signature
Add Signature subclass for Transaction Signatures
2015-02-11 12:53:49 -03:00
Esteban Ordano
605be801af Add Signature subclass for Transaction Signatures 2015-02-11 12:35:47 -03:00
Manuel Araoz
0e1de0403e remove logs 2015-02-11 12:21:42 -03:00
Manuel Araoz
8ca396c34f refactor transaction input deserializtion 2015-02-11 11:40:24 -03:00
Manuel Araoz
0f17927fde fix 0 fee error 2015-02-10 18:29:14 -03:00
Manuel Araoz
aa1158097d fix bug in change calculation 2015-02-10 18:12:45 -03:00
Manuel Araoz
986264e181 add locktime docs and Transaction#getLockTime 2015-02-10 13:03:07 -03:00
Esteban Ordano
f8974b383a transaction: Change variable name from time to height 2015-02-10 10:29:29 -03:00
Esteban Ordano
7cf3b6eb91 Split setLockTime in two methods 2015-02-10 10:29:29 -03:00
Manuel Araoz
07c8c153f9 add Transaction#lockUntil stub 2015-02-10 10:29:29 -03:00
Braydon Fuller
904df59493 Added docs link to InvalidArgument message for preconditions.
- Error messages will appear as: "Invalid Argument: First argument is required, please include address data. Documentation: http://bitcore.io/guide/address.html"
2015-02-09 21:46:10 -05:00
Manuel Araoz
edda8ea723 fix broken tests 2015-02-09 16:06:18 -03:00
Manuel Araoz
85e938ba72 improve code style 2015-02-09 15:40:06 -03:00
Nathan Hernandez
80d444f60e Update transaction.js 2015-02-09 13:23:23 -05:00
Manuel Aráoz
ebf43b3f4a Merge pull request #1056 from eordano/docs/transaction
Rewrite of Transaction doc
2015-02-09 14:20:13 -03:00
Esteban Ordano
78189f61d9 Rewrite of Transaction doc 2015-02-09 14:11:51 -03:00
Esteban Ordano
8d642f3c7a Merge pull request #1044 from trustatom-oss/master
Add check to _hasDustOutputs if output has OP_RETURN
2015-02-09 12:45:06 -03:00
Yemel Jardi
6b3c448481 Merge pull request #1046 from eordano/input/errorMessage
Better error message on unsupported input types
2015-02-06 11:32:45 -03:00
Manuel Aráoz
6e27dc3a9a Merge pull request #1043 from eordano/performance/bn
Drop inherited and modified BN class for big improvement on performance
2015-02-06 11:28:02 -03:00
Yemel Jardi
5f5be614f5 Merge pull request #1047 from eordano/fix/inspect
Fix inspect method so it doesn't fail on incomplete TX
2015-02-06 11:03:43 -03:00
Esteban Ordano
4781c4328f Better error message on unsupported input types 2015-02-06 10:14:41 -03:00
Esteban Ordano
67164790ff Fix inspect method so it doesn't fail on incomplete TX 2015-02-06 10:10:29 -03:00
Esteban Ordano
36d854b255 HDPublicKey: Fix JSDocs 2015-02-06 09:38:21 -03:00
Esteban Ordano
9cafbd558d Dust outputs: Fix condition (one OP_RETURN was avoiding checks on other outputs) 2015-02-06 09:32:12 -03:00
Esteban Ordano
0bcfec9f2f Point: Return the curve point instead of instantiating each time 2015-02-06 09:19:57 -03:00
Gabriel Jaldon
89400c0a56 Add check to _hasDustOutputs if output has OP_RETURN 2015-02-06 13:31:27 +08:00
Esteban Ordano
73a973359b Fix invocations to binary operations called on numbers 2015-02-05 17:28:45 -03:00
Esteban Ordano
6b05f20397 Add the new operator when BN was used without it 2015-02-05 16:46:18 -03:00
Manuel Aráoz
ebcf3ae991 Merge pull request #1005 from eordano/g7/hdkeys
HDKeys: add toBuffer/fromBuffer
2015-02-05 16:27:19 -03:00
Manuel Aráoz
aee287feda Merge pull request #1006 from eordano/g7/privkey
Add fromBuffer and toBuffer to PrivateKey
2015-02-05 16:25:43 -03:00
Esteban Ordano
9b2ba6f2a2 Drop prototypal inheritance for bn 2015-02-05 16:17:46 -03:00
Esteban Ordano
69b466470a HDKeys: Return a copy buffer instead of the original instance 2015-02-05 15:06:01 -03:00
Esteban Ordano
7a73f582b4 HDKeys: add toBuffer/fromBuffer to HDPublicKey 2015-02-05 15:06:01 -03:00
Esteban Ordano
0ff4c9a922 HDKeys: Add jsdocs to hdprivatekey 2015-02-05 15:06:01 -03:00
Esteban Ordano
28a1eae0be HDKeys: add toBuffer/fromBuffer to HDPrivateKey 2015-02-05 15:06:00 -03:00
Esteban Ordano
0bae82fdf4 Add fromBuffer and toBuffer to PrivateKey 2015-02-05 15:05:47 -03:00
Esteban Ordano
7975c59ba7 UnspentOutput: Fix issue when 0 being feed as amount 2015-02-05 13:45:17 -03:00
Esteban Ordano
4f1e13a686 UnspentOutput: Fix issue when 0 being feed as amount 2015-02-05 12:00:44 -03:00
Matias Alejo Garcia
5fa384603f Update transaction.js
Fixes https://github.com/bitpay/bitcore/issues/1036
2015-02-05 10:40:45 -03:00
Esteban Ordano
979d284567 Transaction: add removeInput member 2015-02-04 17:53:16 -03:00
Manuel Aráoz
cd7e5d5a1e Merge pull request #1028 from eordano/transaction/changeupdate
Improvements to Transaction
2015-02-04 16:19:02 -03:00
Esteban Ordano
e568a8786c Transaction: Fix wrong logic on input addition 2015-02-04 15:57:34 -03:00
Manuel Araoz
c664f211d2 add BufferReader.readVarLengthBuffer 2015-02-04 13:04:55 -03:00
Esteban Ordano
1f45e88268 Add fee to serialization 2015-02-04 12:50:06 -03:00
Esteban Ordano
ed393dcb91 Update change on each output or input change 2015-02-04 12:50:03 -03:00
Esteban Ordano
bd97f20f1c Use addInput in _fromNonP2SH 2015-02-04 12:10:47 -03:00
Manuel Araoz
b9be679e09 add some checks 2015-02-04 11:49:09 -03:00
Braydon Fuller
688ac4912c Merge pull request #1025 from eordano/tohex
Add shorthand method toHex to Script
2015-02-03 23:13:11 -05:00
Esteban Ordano
03f794b4a3 Add shorthand method toHex to Script 2015-02-03 17:35:44 -03:00
Yemel Jardi
3bd361e27a Fix hd string path parsing. 2015-01-28 18:13:38 -03:00
Braydon Fuller
39484c755e Fixed typo in docs 2015-01-28 11:10:06 -05:00
Manuel Aráoz
c51b239b6a Merge pull request #1010 from eordano/feature/toSatoshisNumber
Allow satoshis to be a string on output creation
2015-01-28 12:30:21 -03:00
Esteban Ordano
614a228c79 Allow satoshis to be a string on output creation 2015-01-28 12:02:41 -03:00
Braydon Fuller
6fa7e7603a Networks: Added the ability to define a custom network. 2015-01-22 21:31:20 -05:00
Manuel Araoz
2b3ce4de12 adds a test and small fix for transaction 2015-01-19 18:02:26 -03:00
Braydon Fuller
59a6c926d7 Returned jsdoc for info.header, and removed nolonger used opts argument 2015-01-18 10:41:54 -05:00
Braydon Fuller
6aa0d14bb9 Removed magicnumber and size as properties of a block. 2015-01-17 00:07:37 -05:00
Braydon Fuller
116ddac345 If skipMagic is enabled do not set the magic or size on the block, the values would have been incorrect. 2015-01-17 00:07:09 -05:00
Braydon Fuller
38b8c211f3 Fix jshint complaints. 2015-01-17 00:07:09 -05:00
Esteban Ordano
b416655222 block serialization: Add option skip magic numbers 2015-01-17 00:07:09 -05:00
Yemel Jardi
42e2c6c525 Implement I5 on URI 2015-01-15 18:17:15 -03:00
Esteban Ordano
6923b9bed9 Drop explorers 2015-01-14 11:44:58 -03:00
Esteban Ordano
7d4cda171a Merge pull request #955 from maraoz/improve/error/system
new error system with no code generation
2015-01-13 20:25:20 -03:00