Commit Graph

789 Commits

Author SHA1 Message Date
Braydon Fuller
3d1dc7aafe Objects passed as arguments are unmodified. 2015-07-06 19:32:34 -04:00
Braydon Fuller
4a681f967e Added comment with reasoning for number or array BN instantiation. 2015-07-01 15:30:21 -04:00
Braydon Fuller
08a80d74d5 more optimizations for readUInt64lebn 2015-07-01 15:05:26 -04:00
Braydon Fuller
805182c500 Removed readReverse() precondition for a 2x block parsing improvement. 2015-07-01 15:05:26 -04:00
Braydon Fuller
e74a65fd0a Combined slice calls for performance improvement. 2015-07-01 15:05:26 -04:00
Braydon Fuller
8e6b0147b9 Fixed issue with incompatible buffer.toJSON for node 0.10 and 0.12 2015-07-01 15:05:26 -04:00
Braydon Fuller
a3dee0695d Improved performance of bufferReader.readUInt64LEBN() 2015-07-01 15:05:26 -04:00
mruddy
9b727afc71 fix signature hasDefinedHashtype method to be closer to the Bitcoin Core function IsDefinedHashtypeSignature 2015-07-01 07:11:08 -04:00
mruddy
02cad1645a fix root cause for bitcore.Transaction.sighash.sign not setting nhashtype.
added unit tests.
fixed an existing lint in a file that i touched.
2015-06-30 15:21:11 -04:00
Braydon Fuller
6dd599187c Merge pull request #1276 from greggzigler/feature/get-sigops-count
get-signature-count needed to measure txs with many inputs
2015-06-25 19:20:14 -04:00
Braydon Fuller
b5ada707bd Benchmarks for block serialization & 4x performance improvement. 2015-06-24 21:19:34 -04:00
Gregg Zigler
77645c7f03 remove skipped tests since equalivant boolean tests already exist 2015-06-24 14:44:27 -04:00
Gregg Zigler
183ffab02b match bitcore style standards, rename arg, set default to true 2015-06-24 14:18:55 -04:00
Gregg Zigler
a4b8c06a2d get-signature-count needed to measure txs with many inputs or outputs 2015-06-24 13:30:25 -04:00
Braydon Fuller
8e13b68405 Merge pull request #1268 from brandonrobertz/master
modularize network version check issues/1265 (2nd)
2015-06-23 18:02:14 -04:00
Brandon Roberts
783c59d99e removed Networks.all and associated test 2015-06-22 20:36:35 -07:00
Brandon Roberts
e07186df07 remove unnecessary filtering code 2015-06-20 14:26:01 -07:00
Braydon Fuller
37b5d3d588 Merge pull request #1264 from fanatid/fix/sortOutputs
fix Transaction.sortOutputs
2015-06-18 11:06:20 -04:00
Ivan Socolsky
0e6aec1c94 allow configuration of fee per kb 2015-06-10 22:17:12 -03:00
Ivan Socolsky
d9d5a26085 fix computation of fee without change output 2015-06-10 17:37:48 -03:00
Brandon Robertz
a38c0c2d93 modularize network version check/tests issues/1265 2015-06-09 14:06:22 -07:00
Kirill Fomichev
b9d52b79c8 fix Transaction.sortOutputs 2015-06-05 21:11:40 +03:00
Utente
d60d8cf2bc fixed PrivateKey initialization from JSON 2015-06-03 12:23:01 -07:00
Matias Alejo Garcia
37d0e1f956 Merge pull request #1258 from braydonf/bug/double-error
Removed double errors in publickey. Fixes #1256
2015-06-01 23:08:34 -03:00
Braydon Fuller
5e58adca5f Removed double errors in publickey. Fixes #1256 2015-06-01 13:40:52 -04:00
Braydon Fuller
a03e6b9385 Add base option for BN.fromString 2015-05-27 14:11:43 -04:00
Patrick Nagurny
4c1ba674c5 Merge pull request #1248 from braydonf/bug/misleading-error
Fixes bug with misleading error with getSerializationError. Closes #1236
2015-05-26 11:32:51 -06:00
Braydon Fuller
a5cd5a1407 Added support for uncompressed public keys to Signature.fromCompact 2015-05-25 23:57:46 -04:00
Braydon Fuller
589d017a14 Refactored transaction.getSerializationError to be more concise.
- _hasMoreOutputThanInput() and _isInvalidSatoshis() merged with getSerializationError()
- _isFeeDifferent(), _isFeeTooLarge() and _isFeeTooSmall merged with _hasFeeError()
2015-05-23 20:13:53 -04:00
David de Kloet
0b6eaf0f1e Call getUnspentValue() only once in getSerializationError(). 2015-05-23 20:13:53 -04:00
David de Kloet
3ace170ac5 Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled. 2015-05-23 20:13:53 -04:00
David de Kloet
ac2fbe2777 When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput. 2015-05-23 20:13:53 -04:00
David de Kloet
8c5b2c851b When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet. 2015-05-23 20:13:53 -04:00
Braydon Fuller
b53f249d02 Merge pull request #1235 from maraoz/transaction/clearOutputs
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
Braydon Fuller
c251c2bfd1 Merge pull request #1226 from dskloet/refactor/get-serialization-error
Simplify transaction.getSerializationError()
2015-05-18 15:08:50 -04:00
Braydon Fuller
7723dd302a Added test case for an empty OP_RETURN for script.getData() Fixes #1237 2015-05-18 10:39:15 -04:00
David de Kloet
99d8ac1957 Remove an unnecessary space. 2015-05-16 22:54:30 +02:00
David de Kloet
3d9560c0c5 Don't break lines at 80 characters. 2015-05-16 22:50:44 +02:00
David de Kloet
8a8412f04a Don't break lines at 80 characters. 2015-05-16 17:06:35 +02:00
Manuel Araoz
8a13a22baf add Transaction#clearOutputs 2015-05-15 15:29:05 -03:00
Braydon Fuller
458abe069e Fixed issue with handling invalid output scripts
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
2015-05-14 01:50:14 -04:00
Braydon Fuller
0dbd9db0ea Merge pull request #1233 from carnesen/typo
Typo "formated"
2015-05-13 18:59:31 -04:00
Chris Arnesen
ec2d726e49 typo "formated" 2015-05-13 15:48:23 -07:00
Braydon Fuller
beeb294e45 Merge pull request #1217 from fanatid/fix/writeable
fix typo: defineProperty.writeable
2015-05-13 09:22:56 -04:00
David de Kloet
26bd5a864a Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity. 2015-05-13 00:26:33 +02:00
Patrick Nagurny
de078a40d3 If output.script is InvalidBuffer, return null instead of throwing error 2015-05-12 17:23:56 -04:00
Braydon Fuller
a02258dfba Merge pull request #1218 from maraoz/docs/pubkeys
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
Eric Martindale
8e7528d13f Merge pull request #1219 from braydonf/coverage/transaction
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
Eric Martindale
993125428e Merge pull request #1213 from braydonf/bug/is-fully-signed
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
Braydon Fuller
53b6171547 Added coverage to transaction and fixed bug with serialization check. 2015-05-11 13:39:53 -04:00