Commit Graph

687 Commits

Author SHA1 Message Date
Braydon Fuller
53b6171547 Added coverage to transaction and fixed bug with serialization check. 2015-05-11 13:39:53 -04:00
Manuel Araoz
951a07c011 fix PublicKey.toObject 2015-05-11 12:24:45 -03:00
David de Kloet
b1e54101d3 Call the parent error of the fee errors FeeError for backwards compatibility. 2015-05-10 00:38:56 +02:00
David de Kloet
8da9c4a44a Give the 3 fee errors a common parent error. 2015-05-10 00:32:27 +02:00
David de Kloet
d1eb190626 Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change. 2015-05-09 21:06:40 +02:00
David de Kloet
16dc489b08 Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified. 2015-05-09 18:44:26 +02:00
Braydon Fuller
d8e90685f4 Fixed script.isPublicKeyHashIn bug with variable length signatures.
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
2015-05-08 22:09:42 -04:00
Braydon Fuller
b688334bf3 Added test case for zero in isNaturalNumber tests. 2015-05-06 13:37:17 -04:00
Braydon Fuller
f8ea7e39cc Included satoshis check during checked serialization. 2015-04-30 13:23:44 -04:00
Braydon Fuller
cd12164fae Added test coverage to transaction.verify 2015-04-30 12:09:59 -04:00
Braydon Fuller
3d447ded79 Update bn.js to 2.0.4 to handle 53 bit precision number input. 2015-04-30 11:20:09 -04:00
Manuel Araoz
a018a23b6b fix bug in recognizing p2sh input scripts 2015-04-30 03:24:15 -03:00
Manuel Araoz
bbd48f868d remove comment 2015-04-29 19:47:35 -03:00
Manuel Araoz
db6234b500 remove duplicate code, increase coverage 2015-04-29 19:45:41 -03:00
Manuel Araoz
d556a0c33d fix regressions 2015-04-29 18:55:42 -03:00
Manuel Araoz
dfc075e5d1 fix block parsing problem 2015-04-29 17:29:33 -03:00
Manuel Araoz
270413a655 add simpler test that fails 2015-04-29 15:54:41 -03:00
Manuel Araoz
722eddb894 add test that exposes bug 2015-04-29 15:31:46 -03:00
Braydon Fuller
a03daab866 Merge pull request #1196 from maraoz/script/coverage
increase script test coverage
2015-04-29 10:20:45 -04:00
Manuel Araoz
100e370295 fix regressions after changes 2015-04-28 17:10:06 -03:00
Manuel Araoz
9a50958943 fix Block#toObject API 2015-04-28 16:42:56 -03:00
Manuel Araoz
dff0891871 add failing test for Block#toObject 2015-04-28 15:17:41 -03:00
Manuel Araoz
ee6f8d35ef increase script test coverage 2015-04-22 14:32:10 -03:00
Kirill Fomichev
ca96359f40 Immutable network Object 2015-04-11 17:05:46 +03:00
Braydon Fuller
bcd4efb724 Added checkState for positive integer in Output satoshis 2015-04-10 18:39:08 -04:00
Braydon Fuller
3005e19cbf Added precondition to transaction.to for a positive integer as an amount 2015-04-10 18:07:20 -04:00
Manuel Araoz
aaa8c8aa67 fix index.html 2015-04-08 17:38:18 -03:00
Manuel Araoz
e331c4ea49 allow addresses to have surrounding whitespace in validation 2015-03-31 17:54:06 -03:00
Kirill Fomichev
c010cb8c50 drop cached value for inputAmount and outputAmount 2015-03-31 16:22:27 +03:00
Manuel Aráoz
53d23e501c Merge pull request #1162 from fanatid/fix/isPublicKeyHashOut
[BUG] Script.isPublicKeyHashOut
2015-03-30 02:31:09 -03:00
eordano
4f4b2b93fb Allow arrays as second arg to Networks.get 2015-03-29 22:56:29 -03:00
Kirill Fomichev
116024a7cb fix Script.isPublicKeyHashOut 2015-03-29 20:55:13 +03:00
Braydon Fuller
f034a71929 Network Fixes
- Fixed Address classification for a custom network
- Added ability to remove a custom network
- Increased test coverage for Address
2015-03-28 19:09:58 -04:00
Eric Martindale
c759401373 Fix tests, address commentary from @braydonf. 2015-03-24 17:57:39 -04:00
Eric Martindale
a7d75cb25b Add test for patch. 2015-03-24 16:38:02 -04:00
Manuel Araoz
56c1e8c000 fix test for hdkey cache 2015-03-20 16:01:05 -03:00
Manuel Araoz
7da4c7925a lazy calc for xpubkey in HDPrivateKey 2015-03-20 15:49:26 -03:00
Manuel Araoz
ef7eafbb0c increase test coverage and fix some bugs 2015-03-18 18:58:41 -03:00
Manuel Araoz
e0b1ca0e10 move some script logic from Address to Script 2015-03-18 17:59:09 -03:00
Manuel Araoz
3619c7c9e2 fix problematic cases 2015-03-18 17:40:26 -03:00
Manuel Araoz
a9328d76ff add extra test 2015-03-18 17:22:32 -03:00
Manuel Araoz
62ea45a524 refactor Address<->Script relation 2015-03-18 16:54:16 -03:00
eordano
294ff097a1 Add error if shuffle function doesnt return an expected result 2015-03-11 15:49:42 -03:00
eordano
a37e7b140c Add functionality to randomize outputs 2015-03-11 15:38:53 -03:00
Manuel Araoz
b685b5d28a add inputAmount and outputAmount to docs 2015-03-02 10:44:39 -03:00
Manuel Araoz
b92fd915eb increase coverage for Input and Output, fix some bugs 2015-02-27 18:46:27 -03:00
Manuel Araoz
d5fd3919c9 add Transaction#inputAmount and outputAmount 2015-02-27 16:38:48 -03:00
Manuel Aráoz
220a5bb566 Merge pull request #1115 from eordano/fix/privCheck
Fix validation error
2015-02-24 17:58:42 -03:00
eordano
9409698e06 Fix validation error 2015-02-24 17:49:26 -03:00
eordano
405f4f43df Update dust amount 2015-02-24 17:24:22 -03:00
eordano
c5d7eacfac Add check for output amount > input amount 2015-02-24 16:34:52 -03:00
Esteban Ordano
bd172e7c09 Merge pull request #1110 from maraoz/fix/#1096
fix #1096: PrivateKey#toAddress(network)
2015-02-24 15:54:16 -03:00
Manuel Araoz
c4666044e9 fix #1096: PrivateKey#toAddress(network) 2015-02-24 15:34:44 -03:00
eordano
427c9b3234 Less repetition on tests for skipping serialization checks 2015-02-24 15:31:26 -03:00
Manuel Aráoz
684dfd5283 Merge pull request #1102 from throughnothing/merkleblock
Add MerkleBlock
2015-02-24 14:59:19 -03:00
Braydon Fuller
fb01bc09e4 Added test to check that merkle nodes do not match, and misc jshint fixes. 2015-02-24 11:38:06 -05:00
eordano
a6df7a175e Better granularity on serialize() checks 2015-02-24 13:02:34 -03:00
William Wolf
3eb95b6576 _traverseMerkleTree state cleanup + improve hasTransactions() 2015-02-24 00:51:38 -08:00
William Wolf
bb0efd2108 Remove _validMerkleTree caching 2015-02-23 19:40:52 -08:00
William Wolf
a478e39524 Review Fixes 2015-02-23 10:05:45 -08:00
eordano
a07d90dfbf Fix error on public key for hdpublickey 2015-02-23 12:10:51 -03:00
eordano
89d78019d8 Fix bug on hdprivate key generation 2015-02-23 11:40:31 -03:00
William Wolf
a67084d176 cleanup 2015-02-23 01:06:22 -08:00
William Wolf
c558c4e34a hasTransaction(tx) + tests 2015-02-22 21:10:50 -08:00
William Wolf
611dae5b55 validMerkleTree() method plus more test blocks 2015-02-22 21:10:50 -08:00
William Wolf
3f11d8e927 One variable per var statement 2015-02-22 21:10:50 -08:00
William Wolf
32583fbbe3 Cleanup test 2015-02-22 21:10:49 -08:00
William Wolf
29c18e22f0 Add lib/block/merkleblock.js 2015-02-22 21:10:49 -08:00
eordano
eb8f59aa27 Drop duplicated code 2015-02-18 13:39:48 -03:00
eordano
9c3170cb3a HDPublicKey: Add precondition checks for static methods 2015-02-18 13:14:12 -03:00
eordano
0938eadab5 Add precondition checks to HDPrivateKey.from* 2015-02-18 13:14:12 -03:00
Esteban Ordano
20315b5fa4 Merge pull request #1068 from maraoz/check/docs
check that there is no inconsistency between docs and bitcore version
2015-02-18 12:12:04 -03:00
Manuel Aráoz
e2ff93b714 Merge pull request #1083 from eordano/feature/multisigchecks
Transaction: Check that threshold is less than amount of signatures
2015-02-18 12:01:58 -03:00
eordano
1a5780e35e Script/Address: Add check for valid number of threshold needed 2015-02-18 11:53:22 -03:00
eordano
c19d5c6501 Transaction: Check that threshold is less than amount of signatures 2015-02-18 11:52:50 -03:00
Manuel Aráoz
4c822e06c5 Merge pull request #1078 from eordano/fix/smallFee
Add check for small fees
2015-02-18 11:30:21 -03:00
Braydon Fuller
cb5648cbe4 Merge pull request #1084 from eordano/update/opreturn80
Script: Update max length for standard opreturn to 80
2015-02-18 09:09:28 -05:00
eordano
0bbde0c9de Script: Update max length for standard opreturn to 80 2015-02-18 10:46:47 -03:00
eordano
7e88167891 Add check for small fees 2015-02-16 12:47:53 -03:00
Trevin Hofmann
374e43bed2 Properly capitalize Base58Check and Base58 2015-02-13 21:40:20 -06:00
Trevin Hofmann
59a9e40f13 Properly capitalize BufferUtil everywhere
Right out of CONTRIBUTING.md

https://github.com/bitpay/bitcore/blob/master/CONTRIBUTING.md#g6---naming-utility-namespaces
2015-02-13 21:21:06 -06:00
Trevin Hofmann
2b137cc17c Add test for Opcode.inspect 2015-02-12 09:44:28 -06:00
Manuel Araoz
3ebd615d4c check that there is no inconsistency between docs and bitcore version 2015-02-12 11:17:14 -03:00
Manuel Araoz
b23d0bc7c9 add doc version test 2015-02-12 11:00:45 -03:00
Esteban Ordano
cca1e2148c Improve test coverage on multisig 2015-02-11 19:10:57 -03:00
Manuel Aráoz
fe731371cf Merge pull request #1016 from yemel/fix/path-validation
Fix hd string path parsing
2015-02-11 12:54:00 -03:00
Manuel Aráoz
994ea957d4 Merge pull request #1061 from eordano/refactor/signature
Add Signature subclass for Transaction Signatures
2015-02-11 12:53:49 -03:00
Esteban Ordano
605be801af Add Signature subclass for Transaction Signatures 2015-02-11 12:35:47 -03:00
Manuel Araoz
8ca396c34f refactor transaction input deserializtion 2015-02-11 11:40:24 -03:00
Manuel Araoz
a7fdcc13a0 weird -> anyone can spend 2015-02-11 10:59:07 -03:00
Manuel Araoz
eae1638b32 add coverage 2015-02-10 18:48:07 -03:00
Manuel Araoz
0f17927fde fix 0 fee error 2015-02-10 18:29:14 -03:00
Manuel Araoz
aa1158097d fix bug in change calculation 2015-02-10 18:12:45 -03:00
Manuel Araoz
986264e181 add locktime docs and Transaction#getLockTime 2015-02-10 13:03:07 -03:00
Esteban Ordano
f8974b383a transaction: Change variable name from time to height 2015-02-10 10:29:29 -03:00
Esteban Ordano
7cf3b6eb91 Split setLockTime in two methods 2015-02-10 10:29:29 -03:00
Manuel Araoz
edda8ea723 fix broken tests 2015-02-09 16:06:18 -03:00
Manuel Araoz
85e938ba72 improve code style 2015-02-09 15:40:06 -03:00
Manuel Aráoz
ebf43b3f4a Merge pull request #1056 from eordano/docs/transaction
Rewrite of Transaction doc
2015-02-09 14:20:13 -03:00
Esteban Ordano
78189f61d9 Rewrite of Transaction doc 2015-02-09 14:11:51 -03:00