RanchiMall/flocore
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,217 Commits 8 Branches 130 Tags 14 MiB
b4d607bfef
Commit Graph

258 Commits

Author SHA1 Message Date
Sagiv Ofek
b4d607bfef updated the code to 1-liner statements 
using typeof instead of 2 if checks.
 2014-08-24 01:38:31 -04:00
Sagiv Ofek
449e947966 fix bug - 0 fee is not working! 
if the user pass 0 fee (in fee or feeSat arguments) - there's a bug in the program that will add fee even if specified 0 fee:

- in case fee or feeSat is 0 the if statement `if (opts.fee || opts.feeSat)` will be false.
from some reason `0 || undefined` in js returns `undefined` and in case a user set the fee to 0 in options this condition will not happen. 

- second fix: `var feeSat = this.givenFeeSat ? ...` fixed since if `this.givenFeeSat` is 0 the condition will return false (and we want true in this case) since `0 ? true : false` will return `false` in js language.
 2014-08-23 18:11:28 -04:00
Aaron Caswell
e6190f9e9b Update Transaction.js 
Global leak fix
 2014-08-19 23:30:08 -07:00
Curtis Lacy
798f8ad1be Revised error message per feedback on PR. 2014-08-18 15:26:06 -04:00
Curtis Lacy
49bd46b8b1 Made the error message when we encounter an unknown script pubkey more clear. 2014-08-18 14:39:06 -04:00
Christopher Jeffrey
730e8236cf bip21: fix regex parse error. 2014-08-12 11:26:12 -04:00
Christopher Jeffrey
363e27d493 bip21: check for arg r= and set merchant. 2014-08-12 11:03:43 -04:00
Christopher Jeffrey
11ecfd1667 bip21: use triple equal for consistency. 2014-08-12 11:03:24 -04:00
Christopher Jeffrey
f46cc65aba bip21: use RegExp.exec instead of String.match. 2014-08-12 11:03:01 -04:00
Yemel Jardi
ea22f1361f Add validation of required arguments for future use 2014-08-11 17:57:28 -03:00
Yemel Jardi
ac525f226c Add BIP21 implementation 2014-08-11 17:57:28 -03:00
Ryan X. Charles
9f9e2f1d41 k should be 32 bytes, not 8 bytes 
This is a bug with security implications. It is much easier to guess the value
of k within a 64 byte range. This would lead to compromised private keys.

The cryptography interface of bitcore is extremely poor. I recommend:
* Get rid of the C++ code, since it makes everything more difficult with little benefit
* Refactor all crypto, and have easily auditable bignum, point, ecdsa, and key classes
* Then actually audit the crypto
 2014-08-10 21:25:52 -04:00
Manuel Aráoz
7d03056e09 Merge pull request #459 from ryanxcharles/feature/message-signing 
add support for signing messages in compressed format
 2014-08-06 10:56:07 -03:00
Manuel Aráoz
742edf9164 Merge pull request #478 from manan19/walletkey-params 
setting networks.livenet as the default for WalletKey
 2014-08-06 10:29:55 -03:00
Manan Patel
589418d66c setting networks.livenet as the default for WalletKey 2014-08-05 08:10:20 -07:00
Manuel Araoz
895046cc32 fix browser tests 2014-08-04 15:52:57 -03:00
Manuel Araoz
ca16817a1c generalize version numbers 2014-08-04 15:52:56 -03:00
Manuel Araoz
e44b2480aa add AuthMessage and fix browser tests 2014-08-04 15:52:56 -03:00
Ryan X. Charles
cd353ac02e Merge pull request #467 from maraoz/add/missing-tests 
Add missing tests for new methods added
 2014-07-30 14:50:52 -04:00
Christopher Jeffrey
124d1a2fc3 paypro: expose RootCerts on PayPro. 2014-07-29 10:58:35 -07:00
Manuel Araoz
80b5fcc614 add is* tests for Script 2014-07-28 14:40:16 -03:00
Manuel Araoz
b727cc0d7c add Script validation tests 2014-07-28 14:03:22 -03:00
Manuel Araoz
bed6ccaac0 start adding script tests 2014-07-28 10:20:11 -03:00
Ryan X. Charles
b9f3479b12 Merge pull request #455 from chjj/root-certs 
Root certs
 2014-07-25 19:19:47 -04:00
Ryan X. Charles
f87da3b5ba add support for signing messages in compressed format 
...this is the standard way to sign messages in bitcoin-qt. Note that the
format of a compressed signature, for messages, is quite distinct from DER
format, which is used in transactions. This commit also adds support for
recovering the public key from a signature, which is necessary for this. The
code for public key recover is taken from bitcoinjs-lib.
 2014-07-25 14:07:03 -07:00
Ryan X. Charles
9937ec6312 Merge pull request #458 from matiu/feature/builder03 
Fix loosing signatures after from-toObj roundtrip
 2014-07-25 16:29:53 -04:00
Matias Alejo Garcia
1c6ec69c48 fix lossing signatured after from-toObj roundtrip 2014-07-25 16:43:18 -03:00
Christopher Jeffrey
8a84092be9 root-certs: use hasOwnProperty check instead of __proto__=null. 2014-07-25 10:53:21 -07:00
Christopher Jeffrey
c533db4f42 minor: remove redundant toUpperCase calls. 2014-07-24 23:07:52 -07:00
Christopher Jeffrey
dd165ecf63 paypro: root certs - do not inherit from Object. 2014-07-24 23:07:52 -07:00
Christopher Jeffrey
5b4c4f3894 paypro: get root cert names. 2014-07-24 23:07:52 -07:00
Christopher Jeffrey
0020e289d8 paypro: allow identification of root certs. 2014-07-24 23:07:52 -07:00
Matias Alejo Garcia
1b37d88e9a accept amount a strings in setOutput 2014-07-24 20:02:41 -03:00
Manuel Aráoz
cbfd30af16 Merge pull request #453 from matiu/feature/builder01 
fix checkMerge, and tests
 2014-07-24 18:50:55 -03:00
Matias Alejo Garcia
8660120add fix checkMerge, and tests 2014-07-24 18:46:12 -03:00
Manuel Araoz
0cfd5e43a8 fix merge 2014-07-24 18:02:42 -03:00
Manuel Araoz
c0d51916df add support code for copay's new tx proposal check 2014-07-24 18:01:14 -03:00
Manuel Araoz
b222550dd0 add Transaction#getReceivingAddresses and send 2014-07-24 18:01:14 -03:00
Ryan X. Charles
552a18b760 Merge pull request #452 from matiu/feature/txproposal10 
TransactionBuilder .fromObj .toObj rewrite
 2014-07-24 16:57:36 -04:00
Manuel Araoz
f1d7662a70 fix browser tests 2014-07-24 17:44:57 -03:00
Manuel Araoz
8a88c3ccd0 finish basic tests 2014-07-24 17:44:57 -03:00
Manuel Araoz
2fb5d7d3a5 change test to use sinon 2014-07-24 17:44:57 -03:00
Manuel Araoz
837658034a one test passes 2014-07-24 17:44:57 -03:00
Manuel Araoz
f8d7d1da9d add Transaction#getReceivingAddresses and send 2014-07-24 17:44:56 -03:00
Manuel Araoz
486f2ae1dc starting NetworkMonitor implementation 2014-07-24 17:42:51 -03:00
Matias Alejo Garcia
68b1211c4c formated using js-beautify 2014-07-24 17:35:21 -03:00
Matias Alejo Garcia
8e1de31797 test passing. 2014-07-24 17:33:40 -03:00
Ryan X. Charles
0f737b4f00 Merge pull request #450 from matiu/feature/sin03 
Feature/sin03
 2014-07-24 16:25:02 -04:00
Matias Alejo Garcia
2f97390849 formatted with js-beautify 2014-07-24 16:48:45 -03:00
Matias Alejo Garcia
397fc8607f new to/from Obj. WIP 2014-07-24 16:34:57 -03:00