Commit Graph

57 Commits

Author SHA1 Message Date
Braydon Fuller
53b6171547 Added coverage to transaction and fixed bug with serialization check. 2015-05-11 13:39:53 -04:00
David de Kloet
b1e54101d3 Call the parent error of the fee errors FeeError for backwards compatibility. 2015-05-10 00:38:56 +02:00
David de Kloet
8da9c4a44a Give the 3 fee errors a common parent error. 2015-05-10 00:32:27 +02:00
David de Kloet
d1eb190626 Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change. 2015-05-09 21:06:40 +02:00
David de Kloet
16dc489b08 Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified. 2015-05-09 18:44:26 +02:00
Braydon Fuller
f8ea7e39cc Included satoshis check during checked serialization. 2015-04-30 13:23:44 -04:00
Braydon Fuller
cd12164fae Added test coverage to transaction.verify 2015-04-30 12:09:59 -04:00
Braydon Fuller
3005e19cbf Added precondition to transaction.to for a positive integer as an amount 2015-04-10 18:07:20 -04:00
Kirill Fomichev
c010cb8c50 drop cached value for inputAmount and outputAmount 2015-03-31 16:22:27 +03:00
eordano
294ff097a1 Add error if shuffle function doesnt return an expected result 2015-03-11 15:49:42 -03:00
eordano
a37e7b140c Add functionality to randomize outputs 2015-03-11 15:38:53 -03:00
Manuel Araoz
d5fd3919c9 add Transaction#inputAmount and outputAmount 2015-02-27 16:38:48 -03:00
eordano
405f4f43df Update dust amount 2015-02-24 17:24:22 -03:00
eordano
c5d7eacfac Add check for output amount > input amount 2015-02-24 16:34:52 -03:00
eordano
427c9b3234 Less repetition on tests for skipping serialization checks 2015-02-24 15:31:26 -03:00
eordano
a6df7a175e Better granularity on serialize() checks 2015-02-24 13:02:34 -03:00
Manuel Aráoz
e2ff93b714 Merge pull request #1083 from eordano/feature/multisigchecks
Transaction: Check that threshold is less than amount of signatures
2015-02-18 12:01:58 -03:00
eordano
c19d5c6501 Transaction: Check that threshold is less than amount of signatures 2015-02-18 11:52:50 -03:00
eordano
7e88167891 Add check for small fees 2015-02-16 12:47:53 -03:00
Manuel Araoz
8ca396c34f refactor transaction input deserializtion 2015-02-11 11:40:24 -03:00
Manuel Araoz
a7fdcc13a0 weird -> anyone can spend 2015-02-11 10:59:07 -03:00
Manuel Araoz
eae1638b32 add coverage 2015-02-10 18:48:07 -03:00
Manuel Araoz
0f17927fde fix 0 fee error 2015-02-10 18:29:14 -03:00
Manuel Araoz
aa1158097d fix bug in change calculation 2015-02-10 18:12:45 -03:00
Manuel Araoz
986264e181 add locktime docs and Transaction#getLockTime 2015-02-10 13:03:07 -03:00
Esteban Ordano
f8974b383a transaction: Change variable name from time to height 2015-02-10 10:29:29 -03:00
Esteban Ordano
7cf3b6eb91 Split setLockTime in two methods 2015-02-10 10:29:29 -03:00
Manuel Aráoz
ebf43b3f4a Merge pull request #1056 from eordano/docs/transaction
Rewrite of Transaction doc
2015-02-09 14:20:13 -03:00
Esteban Ordano
78189f61d9 Rewrite of Transaction doc 2015-02-09 14:11:51 -03:00
Esteban Ordano
d136715322 Dust: Add test: OP_RETURN is not dust 2015-02-06 09:25:17 -03:00
Esteban Ordano
979d284567 Transaction: add removeInput member 2015-02-04 17:53:16 -03:00
Manuel Aráoz
cd7e5d5a1e Merge pull request #1028 from eordano/transaction/changeupdate
Improvements to Transaction
2015-02-04 16:19:02 -03:00
Esteban Ordano
e568a8786c Transaction: Fix wrong logic on input addition 2015-02-04 15:57:34 -03:00
Esteban Ordano
1f45e88268 Add fee to serialization 2015-02-04 12:50:06 -03:00
Esteban Ordano
ed393dcb91 Update change on each output or input change 2015-02-04 12:50:03 -03:00
Esteban Ordano
614a228c79 Allow satoshis to be a string on output creation 2015-01-28 12:02:41 -03:00
Manuel Araoz
d862506fed fix code style 2015-01-19 18:27:35 -03:00
Manuel Araoz
2b3ce4de12 adds a test and small fix for transaction 2015-01-19 18:02:26 -03:00
Esteban Ordano
f3663e26d6 Don't add the same input twice 2015-01-12 11:59:15 -03:00
Manuel Aráoz
50a868cb8c Merge pull request #917 from eordano/transaction/updates
Changes to internal transaction and address
2015-01-09 17:44:13 -03:00
Esteban Ordano
26e688ae06 Add .toScriptHashOut() to scripts
- Also sort gulpfile dependencies
2015-01-09 16:09:36 -03:00
Manuel Aráoz
f6cc8c695b Merge pull request #916 from eordano/dusterror
Don't allow serialization if dust amounts are detected
2015-01-09 13:45:07 -03:00
Esteban Ordano
0f73c3f7a3 Throw error if dust amount is detected 2015-01-08 18:02:59 -03:00
Esteban Ordano
d99d1c9cc2 Add tests for serialization roundtrip of inputs 2015-01-08 17:42:41 -03:00
Esteban Ordano
d053599fd2 Improve test coverage 2015-01-08 17:24:29 -03:00
Yemel Jardi
5f59fd0d05 Merge pull request #903 from eordano/fix/addchange
Add `change` when serializing transaction
2015-01-08 17:00:14 -03:00
Esteban Ordano
fe86abc093 Add change when serializing transaction 2015-01-08 16:39:53 -03:00
Braydon Fuller
ff4a6f549d Fixed bugs in IE11 2015-01-05 23:27:20 -05:00
Esteban Ordano
dbf47ef78f transaction: better errors for signature methods
Closes #868
2014-12-31 02:10:51 -03:00
Esteban Ordano
9a73338c91 Add tests for changes to Transaction interface 2014-12-18 20:38:19 -03:00