Fix isCoinBase typo and add comments

This commit is contained in:
tenthirtyone 2017-08-16 12:39:12 -04:00
parent 958fc79204
commit 515884bf63

View File

@ -24,6 +24,7 @@ module.exports = function transactionAPI(router) {
`${error}`); `${error}`);
return res.status(404).send(); return res.status(404).send();
} }
// Catch JSON errors
try { try {
tx = JSON.parse(tx); tx = JSON.parse(tx);
} catch (e) { } catch (e) {
@ -36,6 +37,8 @@ module.exports = function transactionAPI(router) {
'No results found'); 'No results found');
return res.status(404).send(); return res.status(404).send();
} }
// Return UI JSON
return res.send({ return res.send({
txid: tx.hash, txid: tx.hash,
version: tx.version, version: tx.version,
@ -56,13 +59,16 @@ module.exports = function transactionAPI(router) {
}, },
value: output.value / 1e8, value: output.value / 1e8,
})), })),
isCoinbase: tx.inputs[0].prevout.hash === '0000000000000000000000000000000000000000000000000000000000000000', isCoinBase: tx.inputs[0].prevout.hash === '0000000000000000000000000000000000000000000000000000000000000000',
}); });
}); });
}); });
}); });
// /txs is overloaded. Next ver separate concerns // /txs is overloaded. Next ver separate concerns
// query by block
// query by address
// last n txs
router.get('/txs', (req, res) => { router.get('/txs', (req, res) => {
const pageNum = parseInt(req.query.pageNum) || 0; const pageNum = parseInt(req.query.pageNum) || 0;
const rangeStart = pageNum * MAX_TXS; const rangeStart = pageNum * MAX_TXS;
@ -83,6 +89,7 @@ module.exports = function transactionAPI(router) {
logger.log('error', logger.log('error',
`${error}`); `${error}`);
} }
// Catch JSON errors
try { try {
block = JSON.parse(block); block = JSON.parse(block);
} catch (e) { } catch (e) {
@ -95,6 +102,7 @@ module.exports = function transactionAPI(router) {
`${'No tx results'}`); `${'No tx results'}`);
res.status(404).send(); res.status(404).send();
} }
// Setup UI JSON
const totalPages = Math.ceil(block.txs.length / MAX_TXS); const totalPages = Math.ceil(block.txs.length / MAX_TXS);
block.txs = block.txs.slice(rangeStart, rangeEnd); block.txs = block.txs.slice(rangeStart, rangeEnd);
@ -132,12 +140,13 @@ module.exports = function transactionAPI(router) {
const height = blockHeight; const height = blockHeight;
const addr = req.query.address || ''; const addr = req.query.address || '';
return request(`${API_URL}/tx/address/${req.query.address}`, (error, localRes, txs) => { return request(`${API_URL}/tx/address/${addr}`, (error, localRes, txs) => {
if (error) { if (error) {
logger.log('error', logger.log('error',
`${error}`); `${error}`);
return res.status(404).send(); return res.status(404).send();
} }
// Catch JSON errors
try { try {
txs = JSON.parse(txs); txs = JSON.parse(txs);
} catch (e) { } catch (e) {
@ -145,6 +154,7 @@ module.exports = function transactionAPI(router) {
`${e}`); `${e}`);
return res.status(404).send(); return res.status(404).send();
} }
// Setup UI JSON
return res.send({ return res.send({
pagesTotal: 1, pagesTotal: 1,
txs: txs.map(tx => ({ txs: txs.map(tx => ({