From a554e43c079801f3469c9cf7f9eb4d5390016d6f Mon Sep 17 00:00:00 2001
From: Darren Nelsen <darren@bitpay.com>
Date: Mon, 14 Aug 2017 17:01:19 -0400
Subject: [PATCH 1/3] Added aggregateItems

---
 .../components/transaction/transaction.html   | 14 ++--
 app/src/components/transaction/transaction.ts | 72 +++++++++++++++++++
 2 files changed, 81 insertions(+), 5 deletions(-)

diff --git a/app/src/components/transaction/transaction.html b/app/src/components/transaction/transaction.html
index 75cc9b4..c5d29a5 100644
--- a/app/src/components/transaction/transaction.html
+++ b/app/src/components/transaction/transaction.html
@@ -27,19 +27,23 @@
       </ion-list>
 
       <ion-list [hidden]="tx.isCoinBase">
-        <ion-item *ngFor="let vin of tx.vin">
+        <ion-item *ngFor="let vin of aggregateItems(tx.vin)">
           <div>
-            <p><a (click)="goToAddress(vin.addr)">{{ vin.addr }}</a> <span item-end>{{ currency.getConversion(vin.value) }}</span></p>
+            <p><a (click)="goToAddress(vin.addr)">{{ vin.addr }}</a></p>
             <div [hidden]="!expanded">
               <p *ngIf="vin.confirmations"><b>Confirmations</b> {{vin.confirmations}}</p>
-              <p><b>scriptSig</b></p>
-              <div *ngIf="vin.scriptSig">
-                <div *ngFor="let item of vin.scriptSig.asm | split:' '" class="ellipsis">
+              <div *ngIf="vin.scriptSig" class="ellipsis">
+                <p><b>scriptSig</b></p>
+                <div *ngFor="let item of vin.scriptSig.asm | split:' '">
                   <p>{{item}}</p>
                 </div>
               </div>
             </div>
           </div>
+
+          <div item-end>
+            {{ currency.getConversion(vin.value) }}
+          </div>
         </ion-item>
       </ion-list>
 
diff --git a/app/src/components/transaction/transaction.ts b/app/src/components/transaction/transaction.ts
index b01a7bb..772fed1 100644
--- a/app/src/components/transaction/transaction.ts
+++ b/app/src/components/transaction/transaction.ts
@@ -15,6 +15,8 @@ import { CurrencyProvider } from '../../providers/currency/currency';
 })
 export class TransactionComponent {
 
+  private COIN: number = 100000000;
+
   public expanded: boolean = false;
   @Input() public tx: any = {};
 
@@ -44,4 +46,74 @@ export class TransactionComponent {
   public toggleExpanded(): void {
     this.expanded = !this.expanded;
   }
+
+  public aggregateItems(items: Array<any>): Array<any> {
+    console.log('aggregateItems called');
+    if (!items) return [];
+
+    let l: number = items.length;
+
+    let ret: Array<any> = [];
+    let tmp: any = {};
+    let u: number = 0;
+
+    for (let i: number = 0; i < l; i++) {
+
+      let notAddr: boolean = false;
+      // non standard input
+      if (items[i].scriptSig && !items[i].addr) {
+        items[i].addr = 'Unparsed address [' + u++ + ']';
+        items[i].notAddr = true;
+        notAddr = true;
+      }
+
+      // non standard output
+      if (items[i].scriptPubKey && !items[i].scriptPubKey.addresses) {
+        items[i].scriptPubKey.addresses = ['Unparsed address [' + u++ + ']'];
+        items[i].notAddr = true;
+        notAddr = true;
+      }
+
+      // multiple addr at output
+      if (items[i].scriptPubKey && items[i].scriptPubKey.addresses.length > 1) {
+        items[i].addr = items[i].scriptPubKey.addresses.join(',');
+        ret.push(items[i]);
+        continue;
+      }
+
+      let addr: string = items[i].addr || (items[i].scriptPubKey && items[i].scriptPubKey.addresses[0]);
+
+      if (!tmp[addr]) {
+        tmp[addr] = {};
+        tmp[addr].valueSat = 0;
+        tmp[addr].count = 0;
+        tmp[addr].addr = addr;
+        tmp[addr].items = [];
+      }
+      tmp[addr].isSpent = items[i].spentTxId;
+
+      tmp[addr].doubleSpentTxID = tmp[addr].doubleSpentTxID   || items[i].doubleSpentTxID;
+      tmp[addr].doubleSpentIndex = tmp[addr].doubleSpentIndex || items[i].doubleSpentIndex;
+      tmp[addr].dbError = tmp[addr].dbError || items[i].dbError;
+      tmp[addr].valueSat += Math.round(items[i].value * this.COIN);
+      tmp[addr].items.push(items[i]);
+      tmp[addr].notAddr = notAddr;
+
+      if (items[i].unconfirmedInput)
+        tmp[addr].unconfirmedInput = true;
+
+      tmp[addr].count++;
+    }
+
+    console.log('tmp is', tmp);
+
+    for (let v in tmp) {
+      let obj: any = tmp[v];
+      console.log('obj isb', obj);
+      obj.value = obj.value || parseInt(obj.valueSat) / this.COIN;
+      ret.push(obj);
+    }
+
+    return ret;
+  };
 }

From 0fe359bd1f92e867d3f9ef391ed6dcc7bf5fc178 Mon Sep 17 00:00:00 2001
From: Darren Nelsen <darren@bitpay.com>
Date: Mon, 14 Aug 2017 18:44:57 -0400
Subject: [PATCH 2/3] get scriptSigs working again in expanded view

---
 app/src/components/transaction/transaction.html | 14 +++++++++-----
 app/src/components/transaction/transaction.ts   |  4 ----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/src/components/transaction/transaction.html b/app/src/components/transaction/transaction.html
index c5d29a5..d46d07c 100644
--- a/app/src/components/transaction/transaction.html
+++ b/app/src/components/transaction/transaction.html
@@ -32,10 +32,14 @@
             <p><a (click)="goToAddress(vin.addr)">{{ vin.addr }}</a></p>
             <div [hidden]="!expanded">
               <p *ngIf="vin.confirmations"><b>Confirmations</b> {{vin.confirmations}}</p>
-              <div *ngIf="vin.scriptSig" class="ellipsis">
-                <p><b>scriptSig</b></p>
-                <div *ngFor="let item of vin.scriptSig.asm | split:' '">
-                  <p>{{item}}</p>
+              <p><b>scriptSig</b></p>
+              <div *ngFor="let item of vin.items">
+                <div *ngIf="item.scriptSig">
+                  <div *ngFor="let scriptSig of item.scriptSig.asm | split:' '">
+                    <div class="ellipsis">
+                      <p>{{ scriptSig }}</p>
+                    </div>
+                  </div>
                 </div>
               </div>
             </div>
@@ -60,7 +64,7 @@
               <p><b>Type</b> {{vout.scriptPubKey.type}}</p>
               <p><b>scriptPubKey</b></p>
               <div class="ellipsis">
-                <span>{{vout.scriptPubKey.asm}}</span>
+                <p>{{vout.scriptPubKey.asm}}</p>
               </div>
             </div>
           </div>
diff --git a/app/src/components/transaction/transaction.ts b/app/src/components/transaction/transaction.ts
index 772fed1..8d5cc19 100644
--- a/app/src/components/transaction/transaction.ts
+++ b/app/src/components/transaction/transaction.ts
@@ -48,7 +48,6 @@ export class TransactionComponent {
   }
 
   public aggregateItems(items: Array<any>): Array<any> {
-    console.log('aggregateItems called');
     if (!items) return [];
 
     let l: number = items.length;
@@ -105,11 +104,8 @@ export class TransactionComponent {
       tmp[addr].count++;
     }
 
-    console.log('tmp is', tmp);
-
     for (let v in tmp) {
       let obj: any = tmp[v];
-      console.log('obj isb', obj);
       obj.value = obj.value || parseInt(obj.valueSat) / this.COIN;
       ret.push(obj);
     }

From cf4d45cf591738dc2acde1b79b4b60d5fa1a93e6 Mon Sep 17 00:00:00 2001
From: Darren Nelsen <darren@bitpay.com>
Date: Tue, 15 Aug 2017 11:15:10 -0400
Subject: [PATCH 3/3] fixed responsiveness in the transaction grid

---
 .../components/transaction/transaction.html   | 22 +++++++++++++------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/app/src/components/transaction/transaction.html b/app/src/components/transaction/transaction.html
index d46d07c..78b2ea6 100644
--- a/app/src/components/transaction/transaction.html
+++ b/app/src/components/transaction/transaction.html
@@ -18,7 +18,7 @@
   </ion-row>
 
   <ion-row>
-    <ion-col col-5>
+    <ion-col col-12 col-md-5>
 
       <ion-list [hidden]="!tx.isCoinBase">
         <ion-item>
@@ -29,7 +29,9 @@
       <ion-list [hidden]="tx.isCoinBase">
         <ion-item *ngFor="let vin of aggregateItems(tx.vin)">
           <div>
-            <p><a (click)="goToAddress(vin.addr)">{{ vin.addr }}</a></p>
+            <div class="ellipsis">
+              <p><a (click)="goToAddress(vin.addr)">{{ vin.addr }}</a></p>
+            </div>
             <div [hidden]="!expanded">
               <p *ngIf="vin.confirmations"><b>Confirmations</b> {{vin.confirmations}}</p>
               <p><b>scriptSig</b></p>
@@ -52,14 +54,18 @@
       </ion-list>
 
     </ion-col>
-    <ion-col col-1 text-center>
+
+    <ion-col col-12 col-md-1 text-center>
       <ion-icon name="arrow-forward"></ion-icon>
     </ion-col>
-    <ion-col col-6>
+
+    <ion-col col-12 col-md-6>
       <ion-list>
         <ion-item *ngFor="let vout of tx.vout">
           <div>
-            <p><a (click)="goToAddress(getAddress(vout))">{{ getAddress(vout) }}</a></p>
+            <div class="ellipsis">
+              <p><a (click)="goToAddress(getAddress(vout))">{{ getAddress(vout) }}</a></p>
+            </div>
             <div [hidden]="!expanded">
               <p><b>Type</b> {{vout.scriptPubKey.type}}</p>
               <p><b>scriptPubKey</b></p>
@@ -80,11 +86,13 @@
   </ion-row>
 
   <ion-row>
-    <ion-col col-6>
+    <ion-col col-3>
       <span [hidden]="tx.isCoinBase">Fee {{ currency.getConversion(tx.fees) }}</span>
     </ion-col>
-    <ion-col col-6 text-right>
+    <ion-col col-6 text-center>
       {{ tx.confirmations }} Confirmations
+    </ion-col>
+    <ion-col col-3 text-right>
       <span class="">{{ currency.getConversion(tx.valueOut) }}</span>
     </ion-col>
   </ion-row>