From 8231ed6a1e456775332ddc77cb742eda93ae50a8 Mon Sep 17 00:00:00 2001 From: tenthirtyone Date: Fri, 18 Aug 2017 14:17:15 -0400 Subject: [PATCH] clean up console log and fix return statements --- server/lib/api/message.js | 6 ++---- server/lib/api/transaction.js | 4 +--- server/lib/db/blocks.js | 3 +-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/server/lib/api/message.js b/server/lib/api/message.js index 27c0703..a15802a 100644 --- a/server/lib/api/message.js +++ b/server/lib/api/message.js @@ -13,21 +13,19 @@ function verifyMessage(req, res) { } if (!address || !signature || !message) { - res.json({ + return res.json({ message: 'Missing parameters (expected "address", "signature" and "message")', code: 1, }); - return; } let valid; try { valid = new Message(message).verify(address, signature); } catch (err) { - res.json({ + return res.json({ message: `Unexpected error: ${err.message}`, code: 1, }); - return; } res.json({ result: valid }); } diff --git a/server/lib/api/transaction.js b/server/lib/api/transaction.js index da19698..5a93f14 100644 --- a/server/lib/api/transaction.js +++ b/server/lib/api/transaction.js @@ -210,7 +210,6 @@ module.exports = function transactionAPI(router) { `/txs getTopTransactions ${err}`); return res.status(404).send(err); } - console.log(txs.length); return res.json(txs); }); }); @@ -229,8 +228,7 @@ module.exports = function transactionAPI(router) { if (err) { logger.log('error', `${err}`); - res.status(400).send(err); - return; + return res.status(400).send(err); } res.json(true); diff --git a/server/lib/db/blocks.js b/server/lib/db/blocks.js index 5659d34..2b3bb75 100644 --- a/server/lib/db/blocks.js +++ b/server/lib/db/blocks.js @@ -60,9 +60,8 @@ function getBlock(params, options, limit, cb) { function getBestHeight() { getBlock({}, {}, 1, (err, block) => { if (err) { - logger.log('error', + return logger.log('error', `getBestHeight: ${err.err}`); - return; } bestBlockHeight = block.height; });