[IMPROVED] Added logging failed SQL queries to payouts

This commit is contained in:
Sebastian Grewe 2013-11-04 16:10:56 +01:00
parent e2623eb4cc
commit 172444d3d8
4 changed files with 13 additions and 17 deletions

View File

@ -209,15 +209,15 @@ foreach ($aAllBlocks as $iIndex => $aBlock) {
// Move counted shares to archive before this blockhash upstream share // Move counted shares to archive before this blockhash upstream share
if (!$share->moveArchive($iCurrentUpstreamId, $aBlock['id'], $iPreviousShareId)) if (!$share->moveArchive($iCurrentUpstreamId, $aBlock['id'], $iPreviousShareId))
$log->logError('Failed to copy shares to archive table'); $log->logError('Failed to copy shares to archive table: ' . $share->getError());
// Delete all accounted shares // Delete all accounted shares
if (!$share->deleteAccountedShares($iCurrentUpstreamId, $iPreviousShareId)) { if (!$share->deleteAccountedShares($iCurrentUpstreamId, $iPreviousShareId)) {
$log->logFatal("Failed to delete accounted shares from $iPreviousShareId to $iCurrentUpstreamId, aborting!"); $log->logFatal("Failed to delete accounted shares from $iPreviousShareId to $iCurrentUpstreamId, aborting! Error: " . $share->getError());
$monitoring->endCronjob($cron_name, 'E0016', 1, true); $monitoring->endCronjob($cron_name, 'E0016', 1, true);
} }
// Mark this block as accounted for // Mark this block as accounted for
if (!$block->setAccounted($aBlock['id'])) { if (!$block->setAccounted($aBlock['id'])) {
$log->logFatal("Failed to mark block as accounted! Aborting!"); $log->logFatal("Failed to mark block as accounted! Aborting! Error: " . $block->getError());
$monitoring->endCronjob($cron_name, 'E0014', 1, true); $monitoring->endCronjob($cron_name, 'E0014', 1, true);
} }
} else { } else {

View File

@ -146,23 +146,17 @@ foreach ($aAllBlocks as $iIndex => $aBlock) {
// Move shares to archive // Move shares to archive
if ($aBlock['share_id'] < $iLastShareId) { if ($aBlock['share_id'] < $iLastShareId) {
if (!$share->moveArchive($aBlock['share_id'], $aBlock['id'], @$iLastBlockShare)) if (!$share->moveArchive($aBlock['share_id'], $aBlock['id'], @$iLastBlockShare))
$log->logError("Archving failed"); $log->logError("Failed to copy shares to archive: " . $share->getError());
} }
// Delete shares // Delete shares
if ($aBlock['share_id'] < $iLastShareId && !$share->deleteAccountedShares($aBlock['share_id'], $iLastBlockShare)) { if ($aBlock['share_id'] < $iLastShareId && !$share->deleteAccountedShares($aBlock['share_id'], $iLastBlockShare)) {
$log->logFatal("Failed to delete accounted shares from " . $aBlock['share_id'] . " to " . $iLastBlockShare . ", aborting!"); $log->logFatal("Failed to delete accounted shares from " . $aBlock['share_id'] . " to " . $iLastBlockShare . ", aborting! Error: " . $share->getError());
$monitoring->setStatus($cron_name . "_active", "yesno", 0); $monitoring->endCronjob($cron_name, 'E0016', 1, true);
$monitoring->setStatus($cron_name . "_message", "message", "Failed to delete accounted shares from " . $aBlock['share_id'] . " to " . $iLastBlockShare);
$monitoring->setStatus($cron_name . "_status", "okerror", 1);
exit(1);
} }
// Mark this block as accounted for // Mark this block as accounted for
if (!$block->setAccounted($aBlock['id'])) { if (!$block->setAccounted($aBlock['id'])) {
$log->logFatal("Failed to mark block as accounted! Aborting!"); $log->logFatal("Failed to mark block as accounted! Aborting! Error: " . $block->getError());
$monitoring->setStatus($cron_name . "_active", "yesno", 0); $monitoring->endCronjob($cron_name, 'E0014', 1, true);
$monitoring->setStatus($cron_name . "_message", "message", "Failed to mark block " . $aBlock['height'] . " as accounted");
$monitoring->setStatus($cron_name . "_status", "okerror", 1);
exit(1);
} }
} }

View File

@ -105,15 +105,15 @@ foreach ($aAllBlocks as $iIndex => $aBlock) {
// Move counted shares to archive before this blockhash upstream share // Move counted shares to archive before this blockhash upstream share
if (!$share->moveArchive($iCurrentUpstreamId, $aBlock['id'], $iPreviousShareId)) if (!$share->moveArchive($iCurrentUpstreamId, $aBlock['id'], $iPreviousShareId))
$log->logError('Failed to copy shares to archive'); $log->logError('Failed to copy shares to archive: ' . $share->getError());
// Delete all accounted shares // Delete all accounted shares
if (!$share->deleteAccountedShares($iCurrentUpstreamId, $iPreviousShareId)) { if (!$share->deleteAccountedShares($iCurrentUpstreamId, $iPreviousShareId)) {
$log->logFatal('Failed to delete accounted shares from ' . $iPreviousShareId . ' to ' . $iCurrentUpstreamId . ', aborted'); $log->logFatal('Failed to delete accounted shares from ' . $iPreviousShareId . ' to ' . $iCurrentUpstreamId . ', aborted! Error: ' . $share->getError());
$monitoring->endCronjob($cron_name, 'E0016', 1, true); $monitoring->endCronjob($cron_name, 'E0016', 1, true);
} }
// Mark this block as accounted for // Mark this block as accounted for
if (!$block->setAccounted($aBlock['id'])) { if (!$block->setAccounted($aBlock['id'])) {
$log->logFatal('Failed to mark block as accounted! Aborted.'); $log->logFatal('Failed to mark block as accounted! Aborted! Error: ' . $block->getError());
$monitoring->endCronjob($cron_name, 'E0014', 1, true); $monitoring->endCronjob($cron_name, 'E0014', 1, true);
} }
} else { } else {

View File

@ -228,6 +228,7 @@ class Share Extends Base {
return true; return true;
} }
// Catchall // Catchall
$this->setErrorMessage('Archiving shares failed: ' . $this->mysqli->error);
return false; return false;
} }
@ -236,6 +237,7 @@ class Share Extends Base {
if ($this->checkStmt($stmt) && $stmt->bind_param('ii', $previous_upstream, $current_upstream) && $stmt->execute()) if ($this->checkStmt($stmt) && $stmt->bind_param('ii', $previous_upstream, $current_upstream) && $stmt->execute())
return true; return true;
// Catchall // Catchall
$this->setErrorMessage('Deleting shares failed: ' . $this->mysqli->error);
return false; return false;
} }
/** /**