From 963a8f7d27f3aa7653ede59a858c98c0351c0c7f Mon Sep 17 00:00:00 2001 From: Bart S Date: Tue, 20 Feb 2018 22:57:16 +0100 Subject: [PATCH 1/2] Fix: Calculate the efficiency correctly in API --- include/pages/api/getpoolstatus.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pages/api/getpoolstatus.inc.php b/include/pages/api/getpoolstatus.inc.php index 915132e0..6312e92e 100644 --- a/include/pages/api/getpoolstatus.inc.php +++ b/include/pages/api/getpoolstatus.inc.php @@ -12,7 +12,7 @@ $aLastBlock = $block->getLast(); // Efficiency $aShares = $statistics->getRoundShares(); -$aShares['valid'] > 0 ? $dEfficiency = round((100 - (100 / $aShares['valid'] * $aShares['invalid'])), 2) : $dEfficiency = 0; +$aShares['valid'] > 0 ? $dEfficiency = round((1 - ($aShares['invalid'] / ($aShares['valid'] + $aShares['invalid']))) * 100, 2) : $dEfficiency = 0; // Fetch RPC data if ($bitcoin->can_connect() === true){ From a598e6ecd6704b98b7ebc6396cb31324fdee8fcc Mon Sep 17 00:00:00 2001 From: Bart S Date: Wed, 21 Feb 2018 10:08:21 +0100 Subject: [PATCH 2/2] Don't divide by zero Small change I overlooked --- include/pages/api/getpoolstatus.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pages/api/getpoolstatus.inc.php b/include/pages/api/getpoolstatus.inc.php index 6312e92e..dd48358f 100644 --- a/include/pages/api/getpoolstatus.inc.php +++ b/include/pages/api/getpoolstatus.inc.php @@ -12,7 +12,7 @@ $aLastBlock = $block->getLast(); // Efficiency $aShares = $statistics->getRoundShares(); -$aShares['valid'] > 0 ? $dEfficiency = round((1 - ($aShares['invalid'] / ($aShares['valid'] + $aShares['invalid']))) * 100, 2) : $dEfficiency = 0; +$aShares['invalid'] > 0 ? $dEfficiency = round((1 - ($aShares['invalid'] / ($aShares['valid'] + $aShares['invalid']))) * 100, 2) : $dEfficiency = 100; // Fetch RPC data if ($bitcoin->can_connect() === true){