[FIX] Abort cron on locking failure

Fixes #1762

cronjobs/run-crons.sh

@@ -115,7 +115,10 @@ if [[ -e $PIDFILE ]]; then
 fi
 
 # Write our PID file
-echo $PID > $PIDFILE
+echo $PID 2>/dev/null 1> $PIDFILE || {
+  echo 'Failed to create PID file, aborting';
+  exit 1
+}
 
 for cron in $CRONS; do
   [[ $VERBOSE == 1 ]] && echo "Running $cron, check logfile for details"

cronjobs/run-maintenance.sh

@@ -115,7 +115,10 @@ if [[ -e $PIDFILE ]]; then
 fi
 
 # Write our PID file
-echo $PID > $PIDFILE
+echo $PID 2>/dev/null 1> $PIDFILE || {
+  echo 'Failed to create PID file, aborting';
+  exit 1
+}
 
 for cron in $CRONS; do
   [[ $VERBOSE == 1 ]] && echo "Running $cron, check logfile for details"

cronjobs/run-payout.sh

@@ -115,7 +115,10 @@ if [[ -e $PIDFILE ]]; then
 fi
 
 # Write our PID file
-echo $PID > $PIDFILE
+echo $PID 2>/dev/null 1> $PIDFILE || {
+  echo 'Failed to create PID file, aborting';
+  exit 1
+}
 
 for cron in $CRONS; do
   [[ $VERBOSE == 1 ]] && echo "Running $cron, check logfile for details"

cronjobs/run-statistics.sh

@@ -115,7 +115,10 @@ if [[ -e $PIDFILE ]]; then
 fi
 
 # Write our PID file
-echo $PID > $PIDFILE
+echo $PID 2>/dev/null 1> $PIDFILE || {
+  echo 'Failed to create PID file, aborting';
+  exit 1
+}
 
 for cron in $CRONS; do
   [[ $VERBOSE == 1 ]] && echo "Running $cron, check logfile for details"