Fixing intern view of completed tasks

This commit is contained in:
tripathyr 2025-08-25 14:39:42 +05:30 committed by GitHub
parent badd08f151
commit 0be87a1e9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -3277,19 +3277,30 @@
return `${year}-${month < 10 ? '0' : ''}${month}-${day < 10 ? '0' : ''}${day}`;
}
function markTaskAsCompleted() {
getConfirmation('Mark this task as completed?', { confirmText: 'Mark as completed' }).then(res => {
if (res) {
RIBC.admin.putTaskStatus('completed', appState.params.id, appState.params.branch, currentTask.dataset.taskId)
// remove task from displayed list
const taskId = `${appState.params.id}_${appState.params.branch}_${currentTask.dataset.taskId}`;
const filteredTasks = RIBC.getDisplayedTasks().filter(task => task !== taskId)
RIBC.admin.setDisplayedTasks(filteredTasks)
renderBranchTasks()
adminDataChanged();
notify('Task marked as completed', 'success')
}
})
getConfirmation('Mark this task as completed?', { confirmText: 'Mark as completed' }).then(res => {
if (!res) return;
RIBC.admin.putTaskStatus('completed', appState.params.id, appState.params.branch, currentTask.dataset.taskId);
const taskId = `${appState.params.id}_${appState.params.branch}_${currentTask.dataset.taskId}`;
// safer lookup before calling
const getAssigned = RIBC.getAssignedInterns || RIBC.admin?.getAssignedInterns;
const assignedInterns = (typeof getAssigned === 'function' ? getAssigned(taskId) : []) || [];
const completionDate = Date.now();
assignedInterns.forEach(internId => {
RIBC.admin.addCompletedTask(internId, taskId, 0, { completionDate });
});
const filteredTasks = RIBC.getDisplayedTasks().filter(task => task !== taskId);
RIBC.admin.setDisplayedTasks(filteredTasks);
renderBranchTasks();
adminDataChanged();
notify('Task marked as completed', 'success');
});
}
function saveTaskChanges() {
const changedDetails = {
title: getRef('edit_task_title').value.trim(),