bug fixes
This commit is contained in:
parent
f6c06deb8b
commit
c2c048ec9f
10
components/dist/chips.js
vendored
10
components/dist/chips.js
vendored
@ -242,6 +242,7 @@ customElements.define('sm-chips', class extends HTMLElement {
|
|||||||
threshold: 1,
|
threshold: 1,
|
||||||
});
|
});
|
||||||
this.chipsWrapper.addEventListener('option-clicked', e => {
|
this.chipsWrapper.addEventListener('option-clicked', e => {
|
||||||
|
e.stopPropagation();
|
||||||
if (this._value !== e.detail.value) {
|
if (this._value !== e.detail.value) {
|
||||||
this.setSelectedOption(e.detail.value);
|
this.setSelectedOption(e.detail.value);
|
||||||
this.fireEvent();
|
this.fireEvent();
|
||||||
@ -361,12 +362,17 @@ customElements.define('sm-chip', class extends HTMLElement {
|
|||||||
connectedCallback() {
|
connectedCallback() {
|
||||||
this.setAttribute('role', 'option');
|
this.setAttribute('role', 'option');
|
||||||
this.setAttribute('tabindex', '0');
|
this.setAttribute('tabindex', '0');
|
||||||
|
if (!this.hasAttribute('value')) {
|
||||||
|
console.error('sm-chip must have a value attribute');
|
||||||
|
}
|
||||||
|
if (this.hasAttribute('selected'))
|
||||||
|
this.fireEvent();
|
||||||
this.addEventListener('click', this.fireEvent);
|
this.addEventListener('click', this.fireEvent);
|
||||||
this.addEventListener('keydown', this.handleKeyDown);
|
this.addEventListener('keydown', this.handleKeyDown);
|
||||||
}
|
}
|
||||||
attributeChangedCallback(name, oldValue, newValue) {
|
attributeChangedCallback(name, oldValue, newValue) {
|
||||||
if (name === 'selected') {
|
if (name === 'selected') {
|
||||||
if (newValue !== null) {
|
if (this.hasAttribute('selected')) {
|
||||||
this.fireEvent();
|
this.fireEvent();
|
||||||
this.setAttribute('aria-selected', 'true');
|
this.setAttribute('aria-selected', 'true');
|
||||||
} else {
|
} else {
|
||||||
@ -380,4 +386,4 @@ customElements.define('sm-chip', class extends HTMLElement {
|
|||||||
this.removeEventListener('click', this.fireEvent);
|
this.removeEventListener('click', this.fireEvent);
|
||||||
this.removeEventListener('keydown', this.handleKeyDown);
|
this.removeEventListener('keydown', this.handleKeyDown);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
2
components/dist/chips.min.js
vendored
2
components/dist/chips.min.js
vendored
File diff suppressed because one or more lines are too long
Loading…
Reference in New Issue
Block a user