Commit Graph

4234 Commits

Author SHA1 Message Date
SomberNight
97296432a2
transaction.py: sign_txin. allow override for get_preimage_script. 2018-04-27 16:16:27 +02:00
SomberNight
1d6f000868
transaction.py: shortcut witness/scriptSig serialisation 2018-04-27 16:16:14 +02:00
SomberNight
b3110b3b46
bitcoin.py: implement add_number_to_script. 2018-04-27 16:15:44 +02:00
SomberNight
4b89b1e270
implement script_num_to_hex 2018-04-27 16:15:43 +02:00
Filip Gospodinov
61154794c8 electrum: cleanup plugin imports
`electrum_plugins` is imported in the `electrum` script
without being used - I assume it's done to make PyInstaller
find that package. But this can be achieved by avoiding
the usage of `__import__()` when importing `electrum_plugins`
where it's effectively used.
2018-04-26 06:12:20 +02:00
Filip Gospodinov
376a815458 exchange_rate: prefer relative imports (#4308)
As this project is currently structured, absolute
imports have the drawback that they'll load modules
from installed paths rather then from the local repo
when running unit tests. This somehow breaks the main
idea of unit tests which is being able to quickly test
newest development changes. Therefore, use a relative
import here.
2018-04-25 09:42:07 +02:00
Ben Woosley
53320470f5 Format the transaction window fee rate with 1 decimal place (#4286)
* Fix format_satoshi to properly handle non-integer values

Handling the integer and fraction parts together via string formatting
simplifies the initial composition because the default behavior manages
the - sign, and the incorporation of the fractional part.

* Limit fee rate output to one decimal place

Via a new precision arg

* Introduce format_fee_satoshis and use it for all fee display
2018-04-24 18:54:14 +02:00
SomberNight
0be73ed546
wallet.py: small optimisation for get_wallet_delta 2018-04-24 15:26:56 +02:00
mhitcher
5284aef820 added therocktrading exchange rate (#4272) 2018-04-24 09:28:38 +02:00
ThomasV
7cee37dfb8 show bitcoin price info in history summary 2018-04-19 14:05:19 +02:00
ThomasV
624fa4769d prepare release 3.1.3 2018-04-16 18:43:02 +02:00
Dimitris Apostolou
989c9c2b55 Fix typos 2018-04-15 20:34:40 +02:00
SomberNight
44bb1e9993
bitcoin.py: fix op_push
8cbc5c4be4/src/script/script.h (L464)
fdc2bc867b/txscript/scriptbuilder.go (L151)
2018-04-14 16:13:51 +02:00
SomberNight
8bdf863fca
fix: android HistoryScreen was not displaying fiat value of unconfirmed txns 2018-04-12 16:49:25 +02:00
SomberNight
3bf5afa61a
fix #4253 2018-04-12 12:17:24 +02:00
SomberNight
1935d7d165
wallet.py: remove local transactions that we don't have
fixes #4232
closes #4234
2018-04-11 19:53:33 +02:00
SomberNight
7dcefd999f
wallet.py: remove_transaction - make sure we pop from both txi and txo 2018-04-11 19:51:35 +02:00
SomberNight
4fed27610a
wallet.py: load unverified_tx in __init__ 2018-04-11 19:45:13 +02:00
SomberNight
86b1273ec0
wallet.py: minor reordering in __init__ 2018-04-11 19:45:12 +02:00
SomberNight
ebcc983566
wallet.py: build local history from txi and txo, not transactions 2018-04-11 19:45:12 +02:00
fivepiece
b4d71e651b add regtest support (#4242)
* add regtest support

* set default regtest ssl and tcp ports to 51002 and 51002

* regtest inherits parameters from testnet
2018-04-11 19:10:14 +02:00
SomberNight
b68f5645cb
fix #4254 2018-04-11 18:31:35 +02:00
SomberNight
1f937aa6cd
fix: 'oneserver' could only be set in the CLI 2018-04-11 11:16:29 +02:00
SomberNight
7b50790584
do not raise BaseException 2018-04-07 17:10:30 +02:00
SomberNight
76e67daadd
changed some asserts to raise-exceptions in lib 2018-04-07 17:01:38 +02:00
ghost43
cf88e239d7
fix parsing values in setconfig (#4225) 2018-04-06 18:53:13 +02:00
SomberNight
4ff3791cb9
fix #4236 2018-04-06 16:43:11 +02:00
SomberNight
0180abc179
blockchain.py: check header length
related: #4212
2018-04-05 16:12:34 +02:00
SomberNight
e4dad0a425
fix #4198 2018-04-05 12:52:21 +02:00
SomberNight
d2a1179087
fix #4227 2018-04-05 12:22:01 +02:00
ThomasV
ad6dd73a03 do not catch OSError in pipe.send (fix ANR on some versions of Android) 2018-04-05 11:27:12 +02:00
SomberNight
de4fe9db69
fix a race condition in synchronizer
wallet.synchronizer gets assigned a newly constructed Synchronizer instance.
Synchronizer in tx_response refers to the value of wallet.synchronizer.
If the wallet has a missing txn, there could be a race condition that synchronizer asks for a txn and we get the callback from the network WHILE the constructor is still running, in which case wallet.synchronizer would still be None and we would consider the callback "orphan", and the wallet would get "stuck" synchronizing.
2018-04-05 08:32:02 +02:00
ThomasV
eb4463063f
Merge pull request #4214 from SomberNight/payto_read_rbf_from_config
payto: get RBF setting from config
2018-04-04 15:26:49 +02:00
SomberNight
92c45ac29a
fix prev: txns might be added in any order 2018-04-04 01:22:49 +02:00
SomberNight
17512f7f47
wallet: speed up get_address_history 2018-04-03 22:16:29 +02:00
SomberNight
ffe69cb328
fix #4220 2018-04-03 19:18:10 +02:00
SomberNight
13bd10e1cb
wizard: add naive debug message to hw device scan if none are found 2018-04-03 14:21:22 +02:00
SomberNight
42582b6a64
fix #4219 2018-04-03 02:48:55 +02:00
SomberNight
5a508f7b8d
fix #4218 2018-04-03 01:50:37 +02:00
SomberNight
4d15d4e459
payto: get RBF setting from config 2018-04-02 05:30:58 +02:00
SomberNight
58273fc841
tests: xpub version bytes 2018-04-01 16:56:17 +02:00
SomberNight
ff57c198b4
fix prev 2018-04-01 16:52:24 +02:00
fivepiece
192288c025 change testnet p2wsh-p2sh prefix to 0x024289ef to reflect Upub (#4210)
* change testnet p2wsh-p2sh prefix to 0x024289ef to reflect Upub

* add testnet p2sh-p2wsh 2of2 multisig test
2018-04-01 16:48:54 +02:00
SomberNight
9de4d19c5a
tests: refactoring in test_wallet_vertical.py 2018-04-01 16:44:59 +02:00
SomberNight
1eae16aa3e
tests: class TestCaseForTestnet 2018-04-01 15:50:24 +02:00
SomberNight
5926438847 fix #3294 2018-03-27 23:40:46 +02:00
SomberNight
ec33463426 fix #4184 2018-03-27 20:17:37 +02:00
ThomasV
c9c7f34ddf prepare version 3.1.2 2018-03-27 18:26:23 +02:00
ThomasV
2886bf8a05
Merge pull request #4061 from Yuki-Inoue/feature/current_wallet_path
daemon status shows current wallet path
2018-03-27 11:04:46 +02:00
ThomasV
032f40640e revert previous commit, use #4062 2018-03-25 23:38:55 +02:00
ThomasV
d9c0591425 do not set cmd_runner.wallet when wallet is loaded. closes #4062 2018-03-25 23:08:25 +02:00
ThomasV
95780a39a3
Merge pull request #4169 from SomberNight/open_utf8
use explicit utf-8 encoding when opening files in text mode
2018-03-25 10:35:37 +02:00
SomberNight
fa91cbf762 network - send_subscriptions: copy subscribed_addresses before iterating
see #4146
(this should at least avoid the RuntimeError)
2018-03-24 18:34:51 +01:00
SomberNight
9b7536e75c use explicit utf-8 encoding when opening files in text mode 2018-03-23 21:47:51 +01:00
ThomasV
05342c5537
Merge pull request #4117 from SomberNight/pay_to_script
fix paying to script
2018-03-23 19:42:04 +01:00
SomberNight
d146c369bf fix #4164 2018-03-22 21:48:51 +01:00
ThomasV
800c783580
Merge pull request #4115 from SomberNight/disallow_adding_requests_w_invalid_addresses
disallow adding receive requests without valid is_mine addresses
2018-03-22 15:34:05 +01:00
ThomasV
bf67920f7f
Merge pull request #4133 from laseryuan/patch-1
Fix the error: locktime is always reset to zero when serialize the js…
2018-03-22 12:25:58 +01:00
ThomasV
f8f00188ed
Merge pull request #4148 from SomberNight/hw_wallet_output_ismine_der
trezor/keepkey/dbb: provide derivation info for all is_mine txn outputs
2018-03-22 12:18:59 +01:00
SomberNight
c0a42b756b fix #4159 2018-03-22 08:18:27 +01:00
SomberNight
a00439b6f8 fix #4158 2018-03-22 07:27:18 +01:00
SomberNight
77c8010517 bitcoin.py: parameterise a few address-related methods with network 2018-03-20 17:02:49 +01:00
SomberNight
7d11812f55 trezor/keepkey/dbb: provide info for all is_mine txn outputs 2018-03-20 02:04:41 +01:00
ThomasV
35ae2a0064
Merge pull request #4143 from SomberNight/wallet_file_exception
Catch wallet file related exceptions in Qt wizard
2018-03-19 11:57:24 +01:00
SomberNight
5fef1e7980 close #4125
perhaps not proper fix but at least more descriptive exception text
2018-03-19 01:26:57 +01:00
SomberNight
36d52dfd5a fix #4129 2018-03-19 01:04:02 +01:00
SomberNight
22061b4555 transaction.get_address_from_output_script now handles witness version > 0 2018-03-18 06:18:48 +01:00
SomberNight
85b36e027f fix a bug with hw devices.
if a device is unplugged and then replugged before we notice (via scan_devices) then it will get into an unusable state, throwing all kinds of low level exceptions when we don't expect it. affects ledger, keepkey, dbb, but for some reason not trezor.
2018-03-18 03:54:28 +01:00
SomberNight
61a45edee0 Catch wallet file related exceptions in Qt wizard. 2018-03-17 22:56:20 +01:00
SomberNight
c79de3ab3c fix #4139 2018-03-16 22:06:38 +01:00
Laser Yuan
8a5d27dcf4
Fix the error: locktime is always reset to zero when serialize the json data
The "lockTime" field in the json object was ignored due to the wrong attribute name "locktime" was called.
2018-03-16 12:06:33 +08:00
SomberNight
c0ae266d39 DeviceMgr: scan_devices can work without hid 2018-03-16 00:55:45 +01:00
SomberNight
aabd9f01ee wizard hw devices: only scan once 2018-03-15 20:03:12 +01:00
SomberNight
afa4cbfcbb fix #4082 2018-03-15 18:34:30 +01:00
SomberNight
8dd19a5920 wizard: remove unused method 2018-03-15 06:14:57 +01:00
SomberNight
37853ab939 trezor/keepkey: don't show empty error on PIN prompt cancel 2018-03-15 06:08:13 +01:00
ThomasV
5e5134b76f remove custom entropy option again (follow-up e0c38b3), because seeds can be extended with passphrase 2018-03-14 14:59:27 +01:00
ThomasV
4137ae94a0 flush certificate file; might fix #4059 2018-03-13 15:07:19 +01:00
SomberNight
b043c872eb fix paying to script 2018-03-13 06:37:02 +01:00
SomberNight
a6841cbd5f fix #4099: serialisation of txns with negative version number 2018-03-13 01:02:03 +01:00
SomberNight
8e79d09511 disallow adding receive requests without valid is_mine addresses 2018-03-12 21:50:56 +01:00
ThomasV
c3e26a1e2b fix #4098 2018-03-12 12:19:45 +01:00
ThomasV
152ec1447c fix #4100: spent_outpoints does not track everything 2018-03-12 11:56:00 +01:00
ThomasV
cf866adfe3 fix #4109 2018-03-12 10:30:56 +01:00
ThomasV
0603f9f2b4 fix #4108 2018-03-12 10:18:09 +01:00
SomberNight
a048a00594 close #4102
close #3337
2018-03-12 04:00:27 +01:00
SomberNight
e31c2d491d fix #4093 2018-03-11 07:18:07 +01:00
SomberNight
99647fc070 careful with exceptions.. 2018-03-10 08:16:19 +01:00
SomberNight
2c6cf7f80c careful with exceptions.. 2018-03-10 08:00:41 +01:00
SomberNight
d994d27704 hw wallet encryption unlock: clear session on incorrect passphrase 2018-03-10 03:59:01 +01:00
SomberNight
f3d254ff1e follow-up prev 2018-03-10 00:37:16 +01:00
SomberNight
6f5a4677d1 clean up imports in lib/plot.py 2018-03-10 00:23:51 +01:00
SomberNight
9372c31b5d fix #4084 2018-03-09 19:10:57 +01:00
SomberNight
08aee6a857 logging - use self.print_error instead of util.print_error 2018-03-09 14:58:13 +01:00
SomberNight
c13e057701 fix #4080 2018-03-09 03:18:53 +01:00
SomberNight
6f0a7ff420 fix #4077 2018-03-09 01:38:35 +01:00
ThomasV
2deae196d9 this probably fixes #4072 2018-03-08 10:14:32 +01:00
SomberNight
192e895933 hw plugins: catch exceptions for custom enumeration functions.
related: #4060
2018-03-07 16:11:20 +01:00
SomberNight
b02252d664 fix #4065 2018-03-07 14:43:14 +01:00
Yuki Inoue
fc9cb0ca1c daemon status shows current wallet path
All the jsonrpc calls against electrum daemon is affected by the
implicit parameter of wallet in the cmd_runner.  AFAIK, there is no way
to check the value of this wallet.  This can be trouble some if multiple
wallets are loaded, or load_wallet command is executed several times.

This patch makes it viewable on the `daemon status`.
2018-03-07 13:51:06 +09:00
SomberNight
e0cda39ae5 only cache expensive case 2018-03-06 17:15:14 +01:00
SomberNight
db0e3cd209 speed-up wallet.get_full_history: cache coin_price 2018-03-06 16:56:51 +01:00
SomberNight
d002549176 wallet.get_full_history: only do fiat calc, if enabled 2018-03-06 16:37:17 +01:00
SomberNight
0c2547543d fix openalias py3 2018-03-06 16:08:49 +01:00
SomberNight
f90c0d73db fix #4032 2018-03-06 16:07:33 +01:00
SomberNight
135c5e805d fix #4046 2018-03-06 12:41:37 +01:00
SomberNight
e5cba92564 transaction serialization: fix segwit coinbase case.
adjust unit tests so that they would have caught it.
2018-03-06 10:34:52 +01:00
ThomasV
ade7cce144 fix #4034 2018-03-06 07:13:35 +01:00
Johann Bauer
4c81a77ccc
Revert "Check if value has 'is_nan' before calling it"
This reverts commit 1451c66a8f.
2018-03-05 23:24:12 +01:00
Johann Bauer
1451c66a8f
Check if value has 'is_nan' before calling it
Fixes: #4034
2018-03-05 23:07:52 +01:00
SomberNight
2fdbfa6b81 wizard: rename option to "use a master key" 2018-03-05 12:58:03 +01:00
脇山P
122cb08dc6 Add JPY exchange rate (#4016) 2018-03-05 12:08:10 +01:00
SomberNight
81666bf9ac fix #4026 2018-03-05 11:44:03 +01:00
ThomasV
0bca97dd2f improve fee status message 2018-03-05 09:49:17 +01:00
SomberNight
219ea6588b update default server list 2018-03-05 06:00:24 +01:00
SomberNight
81b6d65764 refactor network constants 2018-03-04 22:10:59 +01:00
ThomasV
1526768cd6 kivy: simplify history screen, display either fiat or btc 2018-03-03 11:32:38 +01:00
SomberNight
0df6d1ec97 trezor: segwit offline signing 2018-03-03 02:39:49 +01:00
SomberNight
7816edc342 fix #4003 2018-03-03 00:05:57 +01:00
ThomasV
4b7cf297f5 fix #3998 2018-03-02 18:00:05 +01:00
SomberNight
02f2e5c599 wallet.add_transaction: adding to spent_outpoints, out of order case 2018-03-02 07:56:17 +01:00
ThomasV
9f5c76bf0b
Merge pull request #3995 from SomberNight/toggle_history_tab_capgains
toggle capital gains columns in qt history tab
2018-03-02 06:52:27 +01:00
ThomasV
968862076f fix sign 2018-03-01 19:09:24 +01:00
SomberNight
724ed874aa toggle capital gains columns in qt history tab 2018-03-01 19:05:51 +01:00
ThomasV
37e43d9c10 follow up prev commit 2018-03-01 18:31:16 +01:00
ThomasV
fb761b7c12 request fee historgam every minute. show fee in the send tab of kivy gui 2018-03-01 18:28:54 +01:00
ThomasV
4236adc552 fix date filtering 2018-02-28 09:50:28 +01:00
SomberNight
a821a3504e wizard: remove unused strings 2018-02-27 16:52:28 +01:00
ThomasV
a3554dc2b7 fix #3963 2018-02-27 16:00:56 +01:00
ThomasV
51630416fc fix expenditures sign 2018-02-27 15:26:39 +01:00
ThomasV
31edc419fa improve get_tx_status 2018-02-27 15:13:44 +01:00
ThomasV
afd39b2f42 Merge branch 'master' of github.com:spesmilo/electrum 2018-02-27 12:19:54 +01:00
ThomasV
c50d758c3e rename "Local only" as "Local" 2018-02-27 12:17:02 +01:00
Yuki Inoue
6687c1b336 daemon returns true only if the wallet is loaded 2018-02-27 18:43:00 +09:00
ThomasV
375d7965d7
Merge pull request #3978 from SomberNight/load_unverified_tx_offline
prepare self.unverified_tx regardless of network
2018-02-27 00:52:24 +01:00
ThomasV
03b40a3c0a
Merge pull request #3514 from SomberNight/2fa_testnet
make 2fa wallets work on testnet
2018-02-27 00:50:09 +01:00
SomberNight
3daa8b018f prepare self.unverified_tx regardless of network 2018-02-26 19:45:20 +01:00
SomberNight
a32d27b9d7 make 2fa wallets work on testnet 2018-02-26 18:21:36 +01:00
ThomasV
22daffbbea fix typo 2018-02-26 18:16:33 +01:00
ThomasV
aad0e276c0 wallet history: compute income and expenditures, remove redundant calculation of acquisition price 2018-02-26 18:13:39 +01:00
ThomasV
9fe24e32c0 test for NaN in Fiat.__str__ 2018-02-26 18:04:44 +01:00
SomberNight
649b5a7298 fix #3964 2018-02-24 22:37:03 +01:00
SomberNight
f1b7578218 fix #3960 2018-02-24 00:30:40 +01:00
SomberNight
55a0a6b7f0 fix #3962 2018-02-24 00:14:34 +01:00
ThomasV
050f9b7d3a
Merge branch 'master' into zbar_windows 2018-02-23 16:04:34 +01:00
ThomasV
0fbcb8229b
Merge pull request #3882 from SomberNight/storage_hw_encrypt_cli_support
cli support for hw encrypted wallets
2018-02-23 12:07:08 +01:00
ThomasV
18ba4319da
Merge pull request #3951 from SomberNight/file_import_export_unification
File import-export unification
2018-02-23 11:46:04 +01:00
ThomasV
aaf89d2325 fix #3858 2018-02-23 11:30:59 +01:00
ThomasV
24054ac399
Merge pull request #3943 from SomberNight/fee_cleanup
clean up fees a bit
2018-02-23 10:11:20 +01:00
ThomasV
d38a50b119 fix #3922: wrong parameter passed to connection_down 2018-02-23 09:35:07 +01:00
ThomasV
8329faf760 price_at_timestamp: minor fix 2018-02-23 09:11:25 +01:00
SomberNight
151aa9d135 fix prev; offset is relative to last forking height 2018-02-22 16:59:37 +01:00
SomberNight
02c7524d75 logging: some extra network-related lines 2018-02-22 16:44:22 +01:00
ThomasV
0928ac961a fix #3955: fix interference between verifier and catch_up 2018-02-22 16:33:39 +01:00
ThomasV
f3440f5a20 fix 3954 2018-02-21 21:09:07 +01:00
ThomasV
99710099fb fix #3952 2018-02-21 20:57:45 +01:00
SomberNight
500c0493d0 clean up prev commit 2018-02-21 19:22:07 +01:00
ThomasV
b7b592fd6e fix #3948 2018-02-21 19:04:33 +01:00
Abdussamad
5997c18aef better code organization
function parameters should be lowercase

Fix crash on invalid labels import

Added invoice exporting and reduced duplicate code

Better exception handling

removed json module import

some more cleanup

Cleaned up some stuff

Added exporting contacts
2018-02-21 19:00:41 +01:00
SomberNight
89e0f90e1f fix #3949 2018-02-21 16:45:34 +01:00
ThomasV
51f04d4e7b compute capital gains using wallet.txi and txo 2018-02-21 14:29:39 +01:00
ThomasV
9f7e256e39 cleanup get_full_history. fix #3939 2018-02-21 11:52:40 +01:00
ThomasV
1703e0036a
Merge pull request #3921 from SomberNight/fix_disabled_change_addrs
fix: disabling "use change addresses" did not work correctly
2018-02-21 11:18:59 +01:00
ThomasV
381de43cac
Merge pull request #3925 from SomberNight/wif_format_change
change WIF to "txin_type:old_wif"
2018-02-21 11:10:03 +01:00
SomberNight
6f5751977b local tx: restructure exception handling wrt wallet.add_transaction and QT 2018-02-21 04:04:27 +01:00
SomberNight
4ddda74dad clean up fees a bit 2018-02-21 03:22:26 +01:00
ThomasV
d77e522721 fix #3912: Use Decimal('NaN') instead of None when exchange rate is not available. 2018-02-20 23:22:36 +01:00
SomberNight
7b3c454542 wallet.add_transaction should not return if tx has already been added. only track spent_outpoints for is_mine inputs. 2018-02-20 18:16:25 +01:00
ThomasV
26d09b4915 fix timestamp of data in get_historical_rates 2018-02-20 10:52:11 +01:00
ThomasV
0a1542e249 fix #3929 2018-02-20 09:58:36 +01:00
ThomasV
395f9c9679
Merge pull request #3898 from SomberNight/bip32_versions_testnet
bip32 version numbers (xpub headers): use t/u/U/v/V for testnet
2018-02-20 09:53:01 +01:00
SomberNight
7a4338ea21 fix tests 2018-02-19 21:16:12 +01:00
SomberNight
51c235a8be privkeys WIF: store in extended WIF internally; export as "txin_type:old_wif" 2018-02-19 20:42:53 +01:00
ThomasV
9110c0542c follow-up previous commit 2018-02-19 14:16:11 +01:00
ThomasV
826cf467d8 Improve wallet history tab:
- use json-serializable types
- add toolbar to history tab
- add button to display time interval
2018-02-19 12:42:27 +01:00
SomberNight
72a443b688 fix: disabling "use change addresses" did not work correctly 2018-02-18 20:13:27 +01:00
SomberNight
008bffcea7 undo verification when removing txn 2018-02-17 16:28:15 +01:00
SomberNight
0d758a650d follow-up 586074cb0f 2018-02-17 15:51:33 +01:00
ThomasV
586074cb0f simplify local transactions:
- restrict conflict detection own inputs
 - save local transactions only if they are own
2018-02-17 11:02:00 +01:00
SomberNight
bd333f16e0 follow-up 76bf53b262 2018-02-16 15:17:55 +01:00
ThomasV
76bf53b262 simplify add_transaction 2018-02-16 13:54:18 +01:00
SomberNight
63e402c2d7 wallet.clear_history: clear txns and verified txns too 2018-02-16 13:37:38 +01:00
SomberNight
945ba8decf fix #3912 2018-02-16 13:20:56 +01:00
SomberNight
fe1e412f01 catch some exceptions during GUI init 2018-02-15 17:30:40 +01:00
ThomasV
7ff32877f7 replace test that should never happen 2018-02-15 15:31:27 +01:00
ThomasV
344b5e0a23
Merge pull request #3901 from SomberNight/fix_3899
fix #3899; and more aggressively catch exceptions in tx.deserialize()
2018-02-15 09:31:20 +01:00
Johann Bauer
e3a082d58d
Fix #3907 2018-02-14 21:58:35 +01:00
SomberNight
909c063eb1 contact/invoice import: better exception handling.
see #3904
2018-02-14 19:42:35 +01:00
SomberNight
063e40bf18 catch IndexError in parse_redeemScript 2018-02-14 16:20:22 +01:00
SomberNight
89b43ee0cb tests: copied valid transactions from bitcoin core unit tests. try to deserialize all. 2018-02-14 15:58:58 +01:00
ThomasV
acbad0a005 change names 2018-02-14 14:25:51 +01:00
ThomasV
8bfe342772 minor fixes 2018-02-14 13:55:01 +01:00
ThomasV
0f16bcdc1f Capital gains:
* Show acquisition price in history.
* Add summary to history command
2018-02-14 12:04:47 +01:00
ThomasV
b2c0350240 allow to use exchange rates while offline 2018-02-14 10:42:59 +01:00
SomberNight
4b6a3e2e5d fix #3899; and more aggressively catch exceptions in tx.deserialize() 2018-02-14 01:20:38 +01:00
SomberNight
ea66333e48 bip32 version numbers (xpub headers): use t/u/U/v/V for testnet 2018-02-13 16:45:41 +01:00
ThomasV
e0130cafcf
Merge pull request #3895 from SomberNight/fix_3890
locking in wallet.create_new_address
2018-02-13 09:52:16 +01:00
ThomasV
b3a67f7a1f Merge branch 'master' of github.com:spesmilo/electrum 2018-02-13 09:47:30 +01:00
ThomasV
2829de5d49 fix: missing parameter 2018-02-13 09:47:25 +01:00
SomberNight
15f7e09131 use config.is_dynfee and config.use_mempool_fees
also fixes #3894
2018-02-13 00:03:42 +01:00
SomberNight
7e77baf4fb fix #3890 2018-02-12 23:20:58 +01:00
SomberNight
2914090879 wallet.synchronize: remove dead code 2018-02-12 16:12:16 +01:00
ThomasV
4cbdd25c93 Capital gains: Let user enter fiat value of transactions. 2018-02-11 18:11:50 +01:00
SomberNight
4cc2575d72 cli support for hw encrypted wallets 2018-02-10 20:07:06 +01:00
ThomasV
264e80a7b7 cache historical exchange rates 2018-02-10 15:56:05 +01:00
ThomasV
0df42fe046 use Decimal for exchange rates 2018-02-10 15:03:45 +01:00
ThomasV
42a16d9c3e computation of capital gains for outgoing transactions 2018-02-09 20:43:42 +01:00
ThomasV
c32435c15e
Merge pull request #3737 from SomberNight/fix_sweep_into_same_wallet
fix: sweeping into same wallet
2018-02-09 15:48:12 +01:00
ThomasV
3f954a8b3d Factorize history export code used in GUI and command line.
Add options to export history limits and exchange rate.
Closes: #1752, #2604,
Replaces: #2715, 3724
2018-02-09 15:28:28 +01:00
ThomasV
670194b920
Merge pull request #3867 from SomberNight/check_trezor_version
check trezorlib version
2018-02-09 12:15:15 +01:00
ThomasV
94ebfd578d
Merge pull request #3879 from SomberNight/fee_calc_integer_satbyte
fee calculation: force back-end to use integer sat/bytes
2018-02-09 12:13:49 +01:00
ThomasV
cccf380753
Merge pull request #3878 from SomberNight/coinchooser_output_rounding
coinchooser: make output value rounding configurable
2018-02-09 12:13:26 +01:00
SomberNight
d8dad74267 fee calculation: force back-end to use integer sat/bytes 2018-02-09 00:16:11 +01:00
SomberNight
710eda1a56 coinchooser: make output value rounding configurable (config var, qt) 2018-02-08 23:10:44 +01:00
ThomasV
95c5815fe3 Fix CoinDesk exchange rates and update currencies.json 2018-02-08 22:39:55 +01:00
SomberNight
f4363e7967 zbar for windows 2018-02-08 05:56:54 +01:00
SomberNight
6c4756dc3d check trezorlib version 2018-02-07 17:51:52 +01:00
ThomasV
81bd8d8d67 fix: fee_to_depth 2018-02-07 17:30:08 +01:00
ThomasV
08bf966f32
Merge pull request #3863 from slush0/master
trezor: Add support for non-HID devices
2018-02-07 17:03:23 +01:00
SomberNight
41e836a9f4 storage upgrade: don't run older upgrade methods on newer version storage 2018-02-06 23:15:08 +01:00
slush
460e88ee53 hw plugins: Allow custom enumerate functions
trezor: Adding support for all supported transports (HID, WebUSB, UDP, Bridge)
2018-02-06 19:13:05 +01:00
ThomasV
aafd3b929b config: sanitize fee_level and depth_level 2018-02-06 11:09:42 +01:00
ThomasV
d9cf4c2b63
Merge pull request #3810 from SomberNight/conflicting_txns
conflicting transactions
2018-02-06 06:16:19 +01:00
SomberNight
ca19a36478 conflicting transactions 2018-02-06 05:39:40 +01:00
SomberNight
d6c1a933fe some local txns are not getting SPV verified 2018-02-06 05:13:37 +01:00
SomberNight
245cd24f34 follow-up f39f43d58c 2018-02-05 20:15:00 +01:00
ThomasV
73cc1293f1 initial release notes for version 3.1 2018-02-05 17:47:15 +01:00
ThomasV
f39f43d58c fix #3845 2018-02-05 16:08:57 +01:00
ThomasV
c3f3843cc3 Add memory pool based fee estimates
- fee estimates can use ETA or mempool
 - require protocol version 1.2
 - remove fee_unit preference
2018-02-05 12:23:32 +01:00
ThomasV
2c619ec41d
Merge pull request #3841 from SomberNight/qt_addr_filter_all
address filter: add "all" filter option besides "receiving" and "change"
2018-02-05 09:06:16 +01:00
SomberNight
ac2d4eb0ef fix #3508 2018-02-04 22:02:10 +01:00
SomberNight
0021dbfceb address filter: (qt gui) add "all" filter option besides "receiving" and "change" 2018-02-04 19:17:21 +01:00
SomberNight
ffdc36285b use string.format instead of old style (%) formatting 2018-02-04 07:26:55 +01:00
ThomasV
ea2a2aaf09 prepare release 3.0.6 2018-02-03 23:57:46 +01:00
ThomasV
c49335ed30
Merge pull request #3346 from SomberNight/encrypt_watch_only_wallets
allow encrypting watch-only wallets
2018-02-03 11:02:14 +01:00
ghost43
4737aa6c2a
migrated some commands from addr to scripthash (#3826)
* migrated some commands from addr to scripthash

* remove getproof command
2018-02-02 23:26:25 +01:00
SomberNight
5fc830580a add block explorer: blockonomics.co 2018-02-01 03:28:44 +01:00
SomberNight
48e8bbff69 Revert "fix conflicting local txns, e.g. when using RBF"
This reverts commit 8a71e46e9b.
2018-01-31 16:48:09 +01:00
SomberNight
3ae1dd3e64 allow coinchooser to spend local txns 2018-01-31 16:45:47 +01:00
SomberNight
e5f239dd28 follow-up 70aa1f1db9 2018-01-30 17:00:19 +01:00
ThomasV
34080187ff
Merge pull request #2339 from bauerj/error-window
Semi-automated crash reporting
2018-01-30 11:16:42 +01:00
Johann Bauer
91e44ba6fc Show error window for unhandled exceptions
Use exception hook from main thread for all threads

Use signal to delegate error window creation to GUI thread

Add more information to issue template

Update to PyQt5

Switch from Github to REST-Service

Report to web service instead of opening the browser

Fix imports

Change crashhub URL to electrum.org server

Explain that exception hooks are only used in the Qt Gui now
2018-01-30 10:49:31 +01:00
SomberNight
6faef7efe3 remove comment 2018-01-30 01:47:51 +01:00
ThomasV
acf473f7f2
Merge pull request #3777 from SomberNight/fix_wallet_check_history
fix wallet.check_history
2018-01-30 01:08:04 +01:00
ThomasV
64127a8bee
Merge pull request #3782 from SomberNight/opt_wallet_get_address_index
Optimisations in wallet.py
2018-01-30 01:06:44 +01:00
SomberNight
ac69f628fe clean-up wallet.get_address_index 2018-01-30 00:59:12 +01:00
SomberNight
d92a6d46eb wallet.is_mine: use inheritance for more readable code 2018-01-30 00:44:40 +01:00
ThomasV
2343894e0f Merge branch 'local_tx' 2018-01-30 00:22:02 +01:00
ThomasV
0e7e7e3dc5 Merge branch 'local_tx' 2018-01-30 00:18:44 +01:00
ThomasV
603345a172
Merge pull request #3791 from SomberNight/fix_3790
wallet.add_unverified_tx: test if self.verifier exists
2018-01-30 00:06:53 +01:00
SomberNight
704bdedea1 tx heights: replace magic numbers with named constants 2018-01-29 23:04:12 +01:00
SomberNight
889456dc77 follow-up prev commit. better handling of p2sh-segwit. added comment to describe the problem for native segwit. 2018-01-29 22:45:43 +01:00
SomberNight
2dca7bd39c subtle typo 2018-01-29 17:42:39 +01:00
SomberNight
8a71e46e9b fix conflicting local txns, e.g. when using RBF 2018-01-29 15:39:46 +01:00
SomberNight
70aa1f1db9 fix #3788 2018-01-29 02:00:43 +01:00
Johann Bauer
8676e870f3 Raise exception if transaction is not related to wallet 2018-01-28 22:56:33 +01:00
SomberNight
f0e7ae20f2 fix #3790 2018-01-28 22:20:27 +01:00
SomberNight
c811c5c9d9 allow encrypting watch-only wallets. initial support for hw wallet storage encryption. 2018-01-28 02:09:44 +01:00
SomberNight
743ef9ec8f fix #3783 2018-01-28 01:56:26 +01:00
SomberNight
d1e2ca4bc5 make wallet.is_change faster 2018-01-27 18:16:31 +01:00
SomberNight
1c67cfe01b optimise wallet.is_mine 2018-01-27 17:51:24 +01:00
SomberNight
7f3b627aa4 make wallet.get_address_index faster by storing an addr->index dict 2018-01-27 17:33:26 +01:00
SomberNight
d09138446f fix wallet.check_history 2018-01-27 04:24:15 +01:00
Johann Bauer
fbcee9a6f6 Also remove child transactions 2018-01-24 19:34:23 +01:00
Johann Bauer
887e06eebb Set icon for offline transactions 2018-01-23 23:50:02 +01:00
Serge Victor
98663d7e20 Intruduction of getfee command, fixes #3704 2018-01-19 16:01:22 +01:00
ThomasV
98daf2c7cc network: send version first 2018-01-19 15:58:39 +01:00
ThomasV
e6dd3e6ad8 allow to save unbroadcasted transactions in wallet 2018-01-18 11:56:21 +01:00
SomberNight
a20a3f9714 fix: sweeping into same wallet 2018-01-17 01:46:00 +01:00
ThomasV
6f843a7bb6
Merge pull request #3734 from SomberNight/websocket_scripthash
websocket: migrate to scripthashes
2018-01-16 18:19:48 +01:00
SomberNight
fbad16b95c revert adding handling of 'blockchain.address.subscribe' in network.py 2018-01-16 17:10:54 +01:00
SomberNight
d808bf057e fix notify command and migrate to use scripthashes 2018-01-16 16:35:29 +01:00
SomberNight
5ec3d2888f websocket: migrate to scripthashes 2018-01-16 16:02:58 +01:00
ThomasV
954897c281
Merge pull request #3732 from SomberNight/config_upgrade
Config upgrades
2018-01-16 13:50:04 +01:00
SomberNight
1c10d5dce1 remove --nossl option (follow-up dc388d4c7c) 2018-01-16 12:36:39 +01:00
SomberNight
f77f029d72 config v2: change server protocol to :s instead of removing it 2018-01-16 11:53:31 +01:00
SomberNight
0d1ea09ed1 fix tests 2018-01-16 10:52:41 +01:00
SomberNight
04a1809969 config: implement config upgrades. remove system config. 2018-01-16 10:31:06 +01:00
ThomasV
d580ecfb28
Merge pull request #3643 from SomberNight/fee_ui_feerounding
fee ui: rounding
2018-01-15 14:18:58 +01:00
SomberNight
a58d01ed54 setconfig rpcpassword: don't try to evaluate or reencode 2018-01-14 12:26:00 +01:00
ThomasV
c8e67e2bd0 fix #3635 2018-01-13 17:09:25 +01:00
SomberNight
f3f43c8f2a Revert "disable p2wpkh for hw wallets for now"
This reverts commit e218c4a305.
2018-01-12 18:46:08 +01:00
ThomasV
4a40b3a0b2 separate merchant UI from main project 2018-01-12 10:37:14 +01:00
ThomasV
d38303354c
Merge pull request #3683 from SomberNight/wizard_scriptnotsupported
wizard: allow to choose derivation again if script type is not supported
2018-01-11 16:45:55 +01:00
ThomasV
359882d0b1
Merge pull request #3630 from SomberNight/bip84
bip84 for sw seeds
2018-01-11 16:43:34 +01:00
SomberNight
d8a9c9720a follow-up 65eae139af 2018-01-10 18:39:25 +01:00
SomberNight
9416e5bc35 wizard: allow to choose derivation again if script type is not supported (instead of closing the wizard) 2018-01-09 21:10:32 +01:00
pooler
8bcefe6cfa Fix Blockchain.get_target() 2018-01-08 21:48:09 +01:00
ThomasV
eaeac4ca51 version 3.0.5 2018-01-08 01:22:12 +01:00
ThomasV
b076f45f8e
Merge pull request #3664 from SomberNight/json_rpc_pw
Password-protect the JSON RPC interface
2018-01-08 00:28:27 +01:00
ThomasV
1020449684 disable jsonrpc commands in the GUI 2018-01-08 00:20:46 +01:00
ThomasV
7c702b518d disable jsonrpc on android 2018-01-08 00:20:27 +01:00
SomberNight
af527b21fb Password-protect the JSON RPC interface 2018-01-07 19:30:23 +01:00
ThomasV
f8fad2fd29 release 3.0.4 2018-01-07 02:49:39 +01:00
ThomasV
6be7bda023
Merge pull request #3659 from mithrandi/patch-1
Stop allowing CORS for the JSON-RPC server
2018-01-06 20:51:55 +01:00
ThomasV
1fe18ab1ce
Merge pull request #3611 from SomberNight/mnemonic_enforce_num_words
avoid shorter seeds 'by luck'
2018-01-06 12:51:30 +01:00
ThomasV
c4e4d8a1dd
Merge pull request #3650 from SomberNight/daemon_lockfile_not_exec
make daemon lockfile not executable
2018-01-06 12:38:05 +01:00
Tristan Seligmann
0cf67997c0
Stop allowing CORS for the JSON-RPC server
As far as I can tell, there is no need to allow this, and doing so poses severe security risks (see #3374).
2018-01-06 08:42:54 +02:00
SomberNight
aeee5e907c enable some translations in base_wizard.py 2018-01-05 13:42:06 +01:00
SomberNight
f9e9597381 make daemon lockfile not executable 2018-01-04 23:41:10 +01:00
SomberNight
6d88eab005 tests: added 2fa seed case to test_wallet_vertical.py 2018-01-04 22:21:05 +01:00
SomberNight
563aae0dbd fix #3411 2018-01-04 03:40:35 +01:00
SomberNight
7033125186 fee ui - rounding: display info icon with tooltip. show pre-rounding values in ui. 2018-01-03 18:08:10 +01:00
Andrew Chow
0a83b3af22 Avoid modifying self.transactions in prepare_for_verifier
In python3, the `.keys()` function returns an iterator, not a list,
so to get a list that can be iterated over, use `list()` instead to
avoid modification of a list while in use.
2018-01-01 18:03:00 -05:00
ThomasV
7ae1a4cdeb
Merge pull request #3593 from SomberNight/scan_qr_textedit_allow_multi
ScanQRTextEdit optionally allows to concat data
2017-12-31 18:04:21 +01:00
SomberNight
6c2b974796 change default relay fee to 1000 sat/kbyte 2017-12-31 05:06:52 +01:00
SomberNight
e218c4a305 disable p2wpkh for hw wallets for now 2017-12-31 02:42:02 +01:00
SomberNight
e3164286d0 implement bip84: bip43 purpose/der path for p2wpkh scripts 2017-12-31 02:20:58 +01:00
SomberNight
6f954090e6 fix fee ui: offline case 2017-12-30 01:13:36 +01:00
SomberNight
295dc12612 avoid shorter seeds 'by luck' 2017-12-27 18:26:50 +01:00
SomberNight
c04ebe9571 wizard: added derivation presets for bip44/49 2017-12-27 17:01:47 +01:00
SomberNight
aef0444867 fix #3439: ScanQRTextEdit optionally allows to concat data 2017-12-24 03:30:04 +01:00
SomberNight
e2c05c2400 RBF/sweep: use BIP_LI01_sort() 2017-12-22 02:33:22 +01:00
SomberNight
fc574ee514 fix #3578 2017-12-21 23:31:59 +01:00
ThomasV
f3a6491df4
Merge pull request #3575 from SomberNight/fix_imported_wallet_addr_filters
fix: address filters for Imported_Wallet: wallet.is_used()
2017-12-21 12:16:31 +01:00
ThomasV
fe41c61be4
Merge pull request #3574 from SomberNight/coinchooser_uses_weights
more precise fee calculation
2017-12-21 11:56:44 +01:00
SomberNight
3ba864bbca connect fee edits together 2017-12-21 11:17:20 +01:00
SomberNight
32b248245e fix: address filters for Imported_Wallet: wallet.is_used() 2017-12-21 03:22:21 +01:00
SomberNight
aaf5e32207 coinchooser fee calculation now uses tx weights. more precise fee calculation for segwit and mixed-segwit txns. 2017-12-21 01:45:35 +01:00
ThomasV
4bab8b63e1 fix too short headers file 2017-12-20 12:37:45 +01:00
ThomasV
dc388d4c7c replace SSL checkbox in GUI with command line option 2017-12-18 14:15:10 +01:00
Charles Bell
295d678e09 Fix segfault when using a specific camera device 2017-12-17 20:45:03 +01:00
SomberNight
9f908c32e3 tests: add missing info in vertical wallet tests 2017-12-13 19:54:39 +01:00
ThomasV
83da45a7d2 Add checkpoints file for testnet. Check that received headers are after max_checkpoint 2017-12-13 14:22:46 +01:00
ThomasV
de01008992 blockchain: do not load forks that cannot connect to the main headers file 2017-12-13 13:43:51 +01:00
SomberNight
650f504fbf fix: testnet datadir could not be created first 2017-12-13 12:00:16 +01:00
ThomasV
9966dc3b0c
Merge pull request #3488 from scrool/plot_empty_outgoing_transactions
Handle empty outgoing transactions for plot
2017-12-12 17:58:49 +01:00
ThomasV
936ee47d3a
Merge pull request #3496 from SomberNight/coinchooser1
CoinChooser: privacy prefers confirmed and is default
2017-12-12 17:19:19 +01:00
ThomasV
44a83c2401 read checkpoints file in NetworkConstants, add it to setup.py 2017-12-12 11:10:50 +01:00
ThomasV
40e13224f7 follow-up d1b8a6fae6 2017-12-12 10:48:05 +01:00
ThomasV
d1b8a6fae6 Replace initial headers download with hardcoded checkpoints 2017-12-12 10:20:44 +01:00
ThomasV
a13775e533
Merge pull request #3502 from SomberNight/tx_size_est_multisig
fix: tx size estimation for multisig
2017-12-12 05:45:19 +01:00
SomberNight
b751e5e7d3 fix: tx size estimation for multisig 2017-12-12 05:43:34 +01:00
ThomasV
8ae1717772
Merge pull request #3500 from SomberNight/fix_sweep_2fa
fix sweeping for 2fa wallets
2017-12-12 05:31:07 +01:00
ThomasV
22d5d29b81 version 3.0.3 2017-12-12 05:27:49 +01:00
SomberNight
ec99304ae1 fix sweeping for 2fa wallets 2017-12-11 17:37:10 +01:00
SomberNight
2a3c41b24f coinchooser: "privacy" policy now prefers confirmed coins. removed "priority" policy. 2017-12-11 14:49:53 +01:00
SomberNight
4e4a7746fc clean-up: use is_segwit_input in wallet.py 2017-12-11 01:49:38 +01:00
Pavol Babincak
a3f2845650 Handle empty outgoing transactions for plot
Previously dialog with error:

    need more than 0 values to unpack

was displayed and not a plot.

After this change plot is displayed without any dialog without graph of
outgoing transactions and without legend for outgoing transactions.

Fixes: #3487
2017-12-09 20:39:07 +01:00
SomberNight
38e3143bd0 fix command: createmultisig 2017-12-06 18:30:02 +01:00
SomberNight
0aee9bbbb0 fix spending from multisig (broken by 8be777e882) 2017-12-06 16:02:40 +01:00
SomberNight
65c15c5a03 fix verifymessage command 2017-12-04 17:36:57 +01:00
SomberNight
e65b598756 use the send tab when sweeping (qt gui) 2017-11-30 12:27:00 +01:00
cluelessperson
151e3ab8e0 minor 2017-11-29 18:14:39 -06:00
ThomasV
f715caa27d fix #3413 2017-11-29 19:04:18 +01:00
ThomasV
2ea59aad14 fix #3345: do not require a wallet in order to sweep 2017-11-29 13:45:02 +01:00
ThomasV
9425319dcd
Merge pull request #3367 from SomberNight/tx_size_est_uncompressed_pk
tx size estimation: handle uncompressed pubkeys
2017-11-24 10:26:08 +01:00
Marko Bencun
116026dee0 DeviceMgr: nicer message when pairing
The experience is a bit better if the user is prompted to connect,
instead of showing an error.
2017-11-24 10:12:53 +01:00
SomberNight
8be777e882 tx size estimation: handle uncompressed pubkeys 2017-11-24 04:24:54 +01:00
ThomasV
9edffd1754
Merge pull request #3335 from SomberNight/cmd_getprivkeys
more robust getprivatekeys() and is_segwit_address()
2017-11-23 10:03:18 +01:00